From: Jens Axboe <axboe@kernel.dk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-block <linux-block@vger.kernel.org>
Subject: Re: [GIT PULL] Follow up block changes for this merge window
Date: Wed, 22 Aug 2018 15:05:36 -0600 [thread overview]
Message-ID: <0180fdfe-ac2f-5388-dc0d-e33a173bb85b@kernel.dk> (raw)
In-Reply-To: <CA+55aFyHYPATi0wTbKBBTEQvtoh4=rdFRz5zBQOnEzfT4h67og@mail.gmail.com>
On 8/22/18 2:39 PM, Linus Torvalds wrote:
> On Wed, Aug 22, 2018 at 10:54 AM Jens Axboe <axboe@kernel.dk> wrote:
>>
>> - Set of bcache fixes and changes (Coly)
>
> Some of those bcache style fixes look questionable.
>
> Maybe we should push back on some of the checkpatch rules instead?
>
> Like having argument names in declarations - sometimes descriptive
> names can be good documentation. And sometimes they are just noise,
> because the type is what describes it.
>
> Oh well. Taken.
Thanks - fwiw, I don't disagree, and I tend to push back harder on
this in core code than drivers. Especially for newer maintainers,
as it can sometimes be a way to dabble around in the code and
find "real" issues.
--
Jens Axboe
prev parent reply other threads:[~2018-08-22 21:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 17:54 [GIT PULL] Follow up block changes for this merge window Jens Axboe
2018-08-22 20:39 ` Linus Torvalds
2018-08-22 21:05 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0180fdfe-ac2f-5388-dc0d-e33a173bb85b@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.