Re: [PATCH mptcp-net 2/2] mptcp: fix duplicate data handling

[Matthieu Baerts <matttbe@kernel.org>]

Hi Paolo, Mat,

On 26/07/2024 02:42, Mat Martineau wrote:
> On Thu, 25 Jul 2024, Paolo Abeni wrote:
> 
>> When a subflow receives and discards duplicate data, the mptcp
>> stack assumes that the consumed offset inside the current skb is
>> zero.
>>
>> With multiple subflows receiving data simultaneously such assertion
>> does not held true. As a result the subflow-level copied_seq will
>> be incorrectly increased and later on the same subflow will observe
>> a bad mapping, leading to subflow reset.

Thank you for the patches and the reviews!

>> Address the issue tacking in account the skb consumed offset in
> 
> Just one fix but Matthieu can adjust: "Address the issue taking into
> account..."

Just did, thanks!

Now in our tree (fixes for -net)

New patches for t/upstream-net and t/upstream:
- 6d60c2cf352d: mptcp: fix bad RCVPRUNED mib accounting
- 2e6def94f212: mptcp: fix duplicate data handling
- Results: a1f9b538328a..0e547869a341 (export-net)
- Results: 8149d851361f..9a749f3dd928 (export)

Tests are now in progress:

- export-net:
https://github.com/multipath-tcp/mptcp_net-next/commit/865fc5f5109629347844c647fa71a50484d02dec/checks
- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/166ef45101617d160bacd4c3330e32f8f71fcf17/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.