From: Pavel Fedin <p.fedin@samsung.com>
To: 'Eric Auger' <eric.auger@linaro.org>,
eric.auger@st.com, linux-arm-kernel@lists.infradead.org,
marc.zyngier@arm.com, christoffer.dall@linaro.org,
andre.przywara@arm.com, kvmarm@lists.cs.columbia.edu,
kvm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, patches@linaro.org, pbonzini@redhat.com
Subject: RE: [PATCH 1/7] KVM: api: add kvm_irq_routing_extended_msi
Date: Thu, 02 Jul 2015 11:41:07 +0300 [thread overview]
Message-ID: <018f01d0b4a2$d74e29f0$85ea7dd0$@samsung.com> (raw)
In-Reply-To: <011f01d0b498$6a17aeb0$3e470c10$@samsung.com>
Hello!
> What if we use KVM_MSI_VALID_DEVID flag instead of new KVM_IRQ_ROUTING_EXTENDED_MSI
> definition? I
> believe this would make an API more consistent and introduce less new definitions.
I have just found one more flaw in your implementation. If you take a look at irqfd_wakeup()...
--- cut ---
/* An event has been signaled, inject an interrupt */
if (irq.type == KVM_IRQ_ROUTING_MSI)
kvm_set_msi(&irq, kvm, KVM_USERSPACE_IRQ_SOURCE_ID, 1,
false);
else
schedule_work(&irqfd->inject);
--- cut ---
You apparently missed KVM_IRQ_ROUTING_EXTENDED_MSI here, as well as in irqfd_update(). But, if you
accept my API proposal, this becomes irrelevant.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
WARNING: multiple messages have this Message-ID (diff)
From: p.fedin@samsung.com (Pavel Fedin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/7] KVM: api: add kvm_irq_routing_extended_msi
Date: Thu, 02 Jul 2015 11:41:07 +0300 [thread overview]
Message-ID: <018f01d0b4a2$d74e29f0$85ea7dd0$@samsung.com> (raw)
In-Reply-To: <011f01d0b498$6a17aeb0$3e470c10$@samsung.com>
Hello!
> What if we use KVM_MSI_VALID_DEVID flag instead of new KVM_IRQ_ROUTING_EXTENDED_MSI
> definition? I
> believe this would make an API more consistent and introduce less new definitions.
I have just found one more flaw in your implementation. If you take a look at irqfd_wakeup()...
--- cut ---
/* An event has been signaled, inject an interrupt */
if (irq.type == KVM_IRQ_ROUTING_MSI)
kvm_set_msi(&irq, kvm, KVM_USERSPACE_IRQ_SOURCE_ID, 1,
false);
else
schedule_work(&irqfd->inject);
--- cut ---
You apparently missed KVM_IRQ_ROUTING_EXTENDED_MSI here, as well as in irqfd_update(). But, if you
accept my API proposal, this becomes irrelevant.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
next prev parent reply other threads:[~2015-07-02 8:41 UTC|newest]
Thread overview: 147+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-29 15:37 [PATCH 0/7] KVM: arm/arm64: gsi routing support Eric Auger
2015-06-29 15:37 ` Eric Auger
2015-06-29 15:37 ` Eric Auger
2015-06-29 15:37 ` [PATCH 1/7] KVM: api: add kvm_irq_routing_extended_msi Eric Auger
2015-06-29 15:37 ` Eric Auger
2015-06-29 15:37 ` Eric Auger
2015-07-02 7:26 ` Pavel Fedin
2015-07-02 7:26 ` Pavel Fedin
2015-07-02 7:26 ` Pavel Fedin
2015-07-02 8:41 ` Pavel Fedin [this message]
2015-07-02 8:41 ` Pavel Fedin
2015-07-02 14:50 ` Eric Auger
2015-07-02 14:50 ` Eric Auger
2015-07-02 14:50 ` Eric Auger
2015-07-02 14:49 ` Eric Auger
2015-07-02 14:49 ` Eric Auger
2015-07-02 14:49 ` Eric Auger
2015-07-02 15:14 ` Andre Przywara
2015-07-02 15:14 ` Andre Przywara
2015-07-02 15:14 ` Andre Przywara
2015-07-02 15:22 ` Eric Auger
2015-07-02 15:22 ` Eric Auger
2015-07-02 15:39 ` Pavel Fedin
2015-07-02 15:39 ` Pavel Fedin
2015-07-02 15:39 ` Pavel Fedin
2015-07-02 15:41 ` Eric Auger
2015-07-02 15:41 ` Eric Auger
2015-07-03 15:29 ` Pavel Fedin
2015-07-03 15:29 ` Pavel Fedin
2015-07-03 15:29 ` Pavel Fedin
2015-07-03 15:42 ` Eric Auger
2015-07-03 15:42 ` Eric Auger
2015-07-03 15:42 ` Eric Auger
2015-07-03 9:05 ` Andre Przywara
2015-07-03 9:05 ` Andre Przywara
2015-07-03 9:05 ` Andre Przywara
2015-07-03 15:53 ` Andre Przywara
2015-07-03 15:53 ` Andre Przywara
2015-07-03 15:53 ` Andre Przywara
2015-07-06 6:42 ` Pavel Fedin
2015-07-06 6:42 ` Pavel Fedin
2015-07-06 6:42 ` Pavel Fedin
2015-07-06 8:30 ` Andre Przywara
2015-07-06 8:30 ` Andre Przywara
2015-07-06 8:30 ` Andre Przywara
2015-07-06 9:30 ` Christoffer Dall
2015-07-06 9:30 ` Christoffer Dall
2015-07-06 9:30 ` Christoffer Dall
2015-07-06 10:05 ` Andre Przywara
2015-07-06 10:05 ` Andre Przywara
2015-07-06 10:05 ` Andre Przywara
2015-07-06 10:37 ` Christoffer Dall
2015-07-06 10:37 ` Christoffer Dall
2015-07-06 10:37 ` Christoffer Dall
2015-07-06 11:07 ` Paolo Bonzini
2015-07-06 11:07 ` Paolo Bonzini
2015-07-06 11:23 ` Andre Przywara
2015-07-06 11:23 ` Andre Przywara
2015-07-06 11:23 ` Andre Przywara
2015-07-06 11:51 ` Paolo Bonzini
2015-07-06 11:51 ` Paolo Bonzini
2015-07-06 13:32 ` Pavel Fedin
2015-07-06 13:32 ` Pavel Fedin
2015-07-06 15:01 ` Eric Auger
2015-07-06 15:01 ` Eric Auger
2015-07-06 15:01 ` Eric Auger
2015-07-06 15:52 ` Andre Przywara
2015-07-06 15:52 ` Andre Przywara
2015-07-06 15:52 ` Andre Przywara
2015-07-06 17:02 ` Eric Auger
2015-07-06 17:02 ` Eric Auger
2015-07-07 7:23 ` Pavel Fedin
2015-07-07 7:23 ` Pavel Fedin
2015-07-07 7:23 ` Pavel Fedin
2015-07-07 7:43 ` Eric Auger
2015-07-07 7:43 ` Eric Auger
2015-07-07 7:43 ` Eric Auger
2015-07-06 15:37 ` Andre Przywara
2015-07-06 15:37 ` Andre Przywara
2015-07-06 15:37 ` Andre Przywara
2015-07-06 15:54 ` Paolo Bonzini
2015-07-06 15:54 ` Paolo Bonzini
2015-07-06 15:54 ` Paolo Bonzini
2015-07-06 16:08 ` Andre Przywara
2015-07-06 16:08 ` Andre Przywara
2015-07-06 16:08 ` Andre Przywara
2015-07-07 7:16 ` Pavel Fedin
2015-07-07 7:16 ` Pavel Fedin
2015-07-07 7:16 ` Pavel Fedin
2015-07-07 10:02 ` Andre Przywara
2015-07-07 10:02 ` Andre Przywara
2015-07-07 10:02 ` Andre Przywara
2015-07-07 10:57 ` Pavel Fedin
2015-07-07 10:57 ` Pavel Fedin
2015-07-07 10:57 ` Pavel Fedin
2015-07-06 12:08 ` Christoffer Dall
2015-07-06 12:08 ` Christoffer Dall
2015-07-06 13:33 ` Pavel Fedin
2015-07-06 13:33 ` Pavel Fedin
2015-07-06 13:33 ` Pavel Fedin
2015-07-06 15:09 ` Andre Przywara
2015-07-06 15:09 ` Andre Przywara
2015-07-06 15:09 ` Andre Przywara
2015-06-29 15:37 ` [PATCH 2/7] KVM: kvm_host: add kvm_extended_msi Eric Auger
2015-06-29 15:37 ` Eric Auger
2015-06-29 15:37 ` Eric Auger
2015-07-02 17:03 ` Andre Przywara
2015-07-02 17:03 ` Andre Przywara
2015-07-02 17:03 ` Andre Przywara
2015-06-29 15:37 ` [PATCH 3/7] KVM: irqchip: convey devid to kvm_set_msi Eric Auger
2015-06-29 15:37 ` Eric Auger
2015-06-29 15:37 ` Eric Auger
2015-06-29 15:37 ` [PATCH 4/7] KVM: arm/arm64: enable irqchip routing Eric Auger
2015-06-29 15:37 ` Eric Auger
2015-06-29 15:37 ` Eric Auger
2015-06-30 13:39 ` Andre Przywara
2015-06-30 13:39 ` Andre Przywara
2015-06-30 13:39 ` Andre Przywara
2015-06-30 14:02 ` Eric Auger
2015-06-30 14:02 ` Eric Auger
2015-06-30 14:02 ` Eric Auger
2015-06-29 15:37 ` [PATCH 5/7] KVM: arm/arm64: build a default routing table Eric Auger
2015-06-29 15:37 ` Eric Auger
2015-06-29 15:37 ` Eric Auger
2015-06-29 15:37 ` [PATCH 6/7] KVM: arm/arm64: enable MSI routing Eric Auger
2015-06-29 15:37 ` Eric Auger
2015-06-29 15:37 ` Eric Auger
2015-06-29 15:37 ` [PATCH 7/7] KVM: arm: implement kvm_set_msi by gsi direct mapping Eric Auger
2015-06-29 15:37 ` Eric Auger
2015-06-29 15:37 ` Eric Auger
2015-07-02 7:53 ` Pavel Fedin
2015-07-02 7:53 ` Pavel Fedin
2015-07-02 15:02 ` Eric Auger
2015-07-02 15:02 ` Eric Auger
2015-07-02 15:02 ` Eric Auger
2015-07-02 15:37 ` Pavel Fedin
2015-07-02 15:37 ` Pavel Fedin
2015-07-02 15:37 ` Pavel Fedin
2015-07-02 17:10 ` Andre Przywara
2015-07-02 17:10 ` Andre Przywara
2015-07-02 17:10 ` Andre Przywara
2015-07-03 5:34 ` Eric Auger
2015-07-03 5:34 ` Eric Auger
2015-07-03 5:34 ` Eric Auger
2015-07-05 19:40 ` [PATCH 0/7] KVM: arm/arm64: gsi routing support Christoffer Dall
2015-07-05 19:40 ` Christoffer Dall
2015-07-05 19:40 ` Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='018f01d0b4a2$d74e29f0$85ea7dd0$@samsung.com' \
--to=p.fedin@samsung.com \
--cc=andre.przywara@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=eric.auger@linaro.org \
--cc=eric.auger@st.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.