From: "Tjernlund" <tjernlund@tjernlund.se>
To: <i2c@lm-sensors.org>
Cc: linuxppc-dev@ozlabs.org
Subject: i2c-mpc.c driver issues
Date: Wed, 24 Oct 2007 23:06:13 +0200 [thread overview]
Message-ID: <019001c81681$b5d449c0$5267a8c0@Jocke> (raw)
While browsing the i2c-mpc.c driver I noticed some things that look odd
to me so I figured I report them. Could not find a maintainer in the MAINTANERS file
so I sent here, cc:ed linuxppc-dev as well.
1) There are a lot of return -1 error code that is propagated back to
userspace. Should be changed to proper -Exxx codes.
2) mpc_read(), according to the comment below it sends a STOP condition here but
this function does not known if this is the last read or not. mpc_xfer is
the one that knows when the transaction is over and should send the stop, which it already
does.
/* Generate stop on last byte */
if (i == length - 1)
writeccr(i2c, CCR_MIEN | CCR_MEN | CCR_TXAK);
Jocke
next reply other threads:[~2007-10-24 21:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 21:06 Tjernlund [this message]
2007-10-24 22:44 ` i2c-mpc.c driver issues Jon Smirl
2007-10-26 9:53 ` [i2c] " Jean Delvare
2007-10-26 11:21 ` Joakim Tjernlund
2007-10-27 20:52 ` Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='019001c81681$b5d449c0$5267a8c0@Jocke' \
--to=tjernlund@tjernlund.se \
--cc=i2c@lm-sensors.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.