All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Fedin <p.fedin@samsung.com>
To: 'Eric Auger' <eric.auger@linaro.org>,
	qemu-devel@nongnu.org, shlomopongratz@gmail.com,
	'Shlomo Pongratz' <shlomo.pongratz@huawei.com>
Subject: Re: [Qemu-devel] [PATCH RFC V2 2/4] Implment GIC-500
Date: Fri, 22 May 2015 17:52:04 +0300	[thread overview]
Message-ID: <019801d0949e$debee360$9c3caa20$@samsung.com> (raw)
In-Reply-To: <555F28BD.8080001@linaro.org>

 Hello!

> Please find some more comments inline.

 Since there are notes about code style, i would add one more thing. structures of v3
implementation keep old names (like GICState), and i would suggest to rename these things
(like GICv3State) in order to avoid confusion.

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia

  reply	other threads:[~2015-05-22 14:52 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-06 14:04 [Qemu-devel] [PATCH RFC V2 0/4] Implement GIC-500 from GICv3 family for arm64 shlomopongratz
2015-05-06 14:04 ` [Qemu-devel] [PATCH RFC V2 1/4] Use Aff1 with mpidr shlomopongratz
2015-05-21 15:54   ` Pavel Fedin
2015-05-21 16:20     ` Shlomo Pongratz
2015-05-22  6:49       ` Pavel Fedin
2015-05-23  9:22         ` Shlomo Pongratz
2015-05-27 16:12   ` Igor Mammedov
2015-05-27 18:03     ` Pavel Fedin
2015-05-28  0:53       ` Shannon Zhao
2015-05-28  6:34         ` Pavel Fedin
2015-05-28  7:23     ` Shlomo Pongratz
2015-05-28  9:30       ` Igor Mammedov
2015-05-28 12:02         ` Shlomo Pongratz
2015-05-28 14:10           ` Pavel Fedin
2015-06-02 15:44           ` Igor Mammedov
2015-06-03 10:51             ` Pavel Fedin
2015-06-01 10:59     ` Shlomo Pongratz
2015-06-02 15:51       ` Igor Mammedov
2015-05-06 14:04 ` [Qemu-devel] [PATCH RFC V2 2/4] Implment GIC-500 shlomopongratz
2015-05-22 13:01   ` Eric Auger
2015-05-22 14:52     ` Pavel Fedin [this message]
2015-05-23  9:30       ` Shlomo Pongratz
2015-05-23  9:28     ` Shlomo Pongratz
2015-05-25 15:26     ` Pavel Fedin
2015-05-26  8:19       ` Shlomo Pongratz
2015-05-06 14:04 ` [Qemu-devel] [PATCH RFC V2 3/4] GICv3 support shlomopongratz
2015-05-06 14:04 ` [Qemu-devel] [PATCH RFC V2 4/4] Add virtv2 machine that uses GIC-500 shlomopongratz
2015-05-07  6:40   ` Pavel Fedin
2015-05-07  7:37     ` Shlomo Pongratz
2015-05-07  8:11       ` Pavel Fedin
2015-05-07  8:56         ` Shlomo Pongratz
2015-05-07 12:46           ` Pavel Fedin
2015-05-07 13:12             ` Pavel Fedin
2015-05-07 13:44             ` Shlomo Pongratz
2015-05-19 14:39   ` Eric Auger
2015-05-19 15:07     ` Shlomo Pongratz
2015-05-25  7:42       ` Pavel Fedin
2015-05-25 11:07   ` Pavel Fedin
2015-05-25 11:47     ` Pavel Fedin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='019801d0949e$debee360$9c3caa20$@samsung.com' \
    --to=p.fedin@samsung.com \
    --cc=eric.auger@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=shlomo.pongratz@huawei.com \
    --cc=shlomopongratz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.