From: swise@opengridcomputing.com (Steve Wise)
Subject: [PATCH v6 2/2] nvmet-rdma: support max(16KB, PAGE_SIZE) inline data
Date: Tue, 26 Jun 2018 12:55:34 -0500 [thread overview]
Message-ID: <019801d40d76$e29c67b0$a7d53710$@opengridcomputing.com> (raw)
In-Reply-To: <ee7f57ae-7813-8d39-291d-49e2562b9526@grimberg.me>
> -----Original Message-----
> From: Linux-nvme <linux-nvme-bounces at lists.infradead.org> On Behalf Of
> Sagi Grimberg
> Sent: Tuesday, June 26, 2018 6:13 AM
> To: Steve Wise <swise at opengridcomputing.com>; axboe at kernel.dk;
> hch at lst.de; keith.busch at intel.com; linux-nvme at lists.infradead.org
> Cc: linux-rdma at vger.kernel.org; maxg at mellanox.com;
> dledford at redhat.com; jgg at mellanox.com; parav at mellanox.com
> Subject: Re: [PATCH v6 2/2] nvmet-rdma: support max(16KB, PAGE_SIZE)
> inline data
>
>
> > - pr_info("enabling port %d (%pISpcs)\n",
> > - le16_to_cpu(port->disc_addr.portid), (struct sockaddr
> *)&addr);
> > + pr_info("enabling port %d (%pISpcs) inline_data_size %d\n",
> > + le16_to_cpu(port->disc_addr.portid), (struct sockaddr
> *)&addr,
> > + port->inline_data_size);
>
> We can lose the info here, its should be visible via configfs.
>
> otherwise looks fine,
>
> Reviewed-by: Sagi Grimberg <sagi at grimberg.me>
Thanks Sagi.
Hey Christoph, I think this is ready to merge. Feel free to remove the
pr_info() if you agree. Or I can repost one more time.
Steve.
next prev parent reply other threads:[~2018-06-26 17:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 14:51 [PATCH v6 0/2] NVMF/RDMA 16K Inline Support Steve Wise
2018-06-20 14:15 ` [PATCH v6 1/2] nvme-rdma: support up to 4 segments of inline data Steve Wise
2018-06-20 14:15 ` [PATCH v6 2/2] nvmet-rdma: support max(16KB, PAGE_SIZE) " Steve Wise
2018-06-26 11:12 ` Sagi Grimberg
2018-06-26 17:55 ` Steve Wise [this message]
2018-06-29 9:05 ` [PATCH v6 0/2] NVMF/RDMA 16K Inline Support Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='019801d40d76$e29c67b0$a7d53710$@opengridcomputing.com' \
--to=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.