From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuehaibing Subject: Re: [PATCH -next] gpu: host1x: Fix compile test failure Date: Fri, 1 Nov 2019 19:33:41 +0800 Message-ID: <01997f01-27d7-7468-c331-9b2920ad8193@huawei.com> References: <20191030135458.27960-1-yuehaibing@huawei.com> <283304d6-bf23-8107-29b6-9f3e7dda943c@gmail.com> <20191101094757.GA1167505@ulmo> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20191101094757.GA1167505@ulmo> Sender: linux-kernel-owner@vger.kernel.org To: Thierry Reding Cc: Dmitry Osipenko , mperttunen@nvidia.com, arnd@arndb.de, seanpaul@chromium.org, dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-tegra@vger.kernel.org On 2019/11/1 17:47, Thierry Reding wrote: > On Thu, Oct 31, 2019 at 09:33:38PM +0800, Yuehaibing wrote: >> On 2019/10/31 6:26, Dmitry Osipenko wrote: >>> 30.10.2019 16:54, YueHaibing пишет: >>>> If IOMMU_SUPPORT is not set, but IOMMU_IOVA is m and >>>> COMPILE_TEST is y, building fails: >>>> >>>> drivers/gpu/host1x/dev.o: In function `host1x_remove': >>>> dev.c:(.text+0x624): undefined reference to `put_iova_domain' >>>> dev.c:(.text+0x624): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `put_iova_domain' >>>> dev.c:(.text+0x62c): undefined reference to `iova_cache_put' >>>> dev.c:(.text+0x62c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `iova_cache_put' >>>> >>>> Select IOMMU_IOVA while COMPILE_TEST is set to fix this. >>>> >>>> Reported-by: Hulk Robot >>>> Fixes: 52499a6ad2ae ("gpu: host1x: select IOMMU_IOVA") >>>> Signed-off-by: YueHaibing >>>> --- >>>> drivers/gpu/host1x/Kconfig | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig >>>> index cf987a3..354232d 100644 >>>> --- a/drivers/gpu/host1x/Kconfig >>>> +++ b/drivers/gpu/host1x/Kconfig >>>> @@ -2,7 +2,7 @@ >>>> config TEGRA_HOST1X >>>> tristate "NVIDIA Tegra host1x driver" >>>> depends on ARCH_TEGRA || (ARM && COMPILE_TEST) >>>> - select IOMMU_IOVA if IOMMU_SUPPORT >>>> + select IOMMU_IOVA if (IOMMU_SUPPORT || COMPILE_TEST) >>>> help >>>> Driver for the NVIDIA Tegra host1x hardware. >>>> >>>> >>> >>> It should be better to unconditionally select IOMMU_IOVA here. >>> >>> The same could be done for drivers/staging/media/tegra-vde/ and >>> drivers/gpu/host1x/, please see [1]. >> >> Yep, I will repost, thanks! > > No need to resend, I already have patches for that. Ok, thanks! > > Thierry > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23A7DCA9ECF for ; Fri, 1 Nov 2019 22:51:16 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5837217D9 for ; Fri, 1 Nov 2019 22:51:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5837217D9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D0F1E6F895; Fri, 1 Nov 2019 22:51:10 +0000 (UTC) Received: from huawei.com (szxga06-in.huawei.com [45.249.212.32]) by gabe.freedesktop.org (Postfix) with ESMTPS id 12B1B6F7C2 for ; Fri, 1 Nov 2019 11:33:48 +0000 (UTC) Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id D808A592C0034E188BBA; Fri, 1 Nov 2019 19:33:45 +0800 (CST) Received: from [127.0.0.1] (10.133.213.239) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.439.0; Fri, 1 Nov 2019 19:33:42 +0800 Subject: Re: [PATCH -next] gpu: host1x: Fix compile test failure To: Thierry Reding References: <20191030135458.27960-1-yuehaibing@huawei.com> <283304d6-bf23-8107-29b6-9f3e7dda943c@gmail.com> <20191101094757.GA1167505@ulmo> From: Yuehaibing Message-ID: <01997f01-27d7-7468-c331-9b2920ad8193@huawei.com> Date: Fri, 1 Nov 2019 19:33:41 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20191101094757.GA1167505@ulmo> X-Originating-IP: [10.133.213.239] X-CFilter-Loop: Reflected X-Mailman-Approved-At: Fri, 01 Nov 2019 22:51:09 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: arnd@arndb.de, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, mperttunen@nvidia.com, seanpaul@chromium.org, linux-tegra@vger.kernel.org, Dmitry Osipenko Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191101113341.eo6JKYBh7FaVO18S4GLE4fSQie1i6EehjQEjIKagQXw@z> T24gMjAxOS8xMS8xIDE3OjQ3LCBUaGllcnJ5IFJlZGluZyB3cm90ZToKPiBPbiBUaHUsIE9jdCAz MSwgMjAxOSBhdCAwOTozMzozOFBNICswODAwLCBZdWVoYWliaW5nIHdyb3RlOgo+PiBPbiAyMDE5 LzEwLzMxIDY6MjYsIERtaXRyeSBPc2lwZW5rbyB3cm90ZToKPj4+IDMwLjEwLjIwMTkgMTY6NTQs IFl1ZUhhaWJpbmcg0L/QuNGI0LXRgjoKPj4+PiBJZiBJT01NVV9TVVBQT1JUIGlzIG5vdCBzZXQs IGJ1dCBJT01NVV9JT1ZBIGlzIG0gYW5kCj4+Pj4gQ09NUElMRV9URVNUIGlzIHksIGJ1aWxkaW5n IGZhaWxzOgo+Pj4+Cj4+Pj4gZHJpdmVycy9ncHUvaG9zdDF4L2Rldi5vOiBJbiBmdW5jdGlvbiBg aG9zdDF4X3JlbW92ZSc6Cj4+Pj4gZGV2LmM6KC50ZXh0KzB4NjI0KTogdW5kZWZpbmVkIHJlZmVy ZW5jZSB0byBgcHV0X2lvdmFfZG9tYWluJwo+Pj4+IGRldi5jOigudGV4dCsweDYyNCk6IHJlbG9j YXRpb24gdHJ1bmNhdGVkIHRvIGZpdDogUl9BQVJDSDY0X0NBTEwyNiBhZ2FpbnN0IHVuZGVmaW5l ZCBzeW1ib2wgYHB1dF9pb3ZhX2RvbWFpbicKPj4+PiBkZXYuYzooLnRleHQrMHg2MmMpOiB1bmRl ZmluZWQgcmVmZXJlbmNlIHRvIGBpb3ZhX2NhY2hlX3B1dCcKPj4+PiBkZXYuYzooLnRleHQrMHg2 MmMpOiByZWxvY2F0aW9uIHRydW5jYXRlZCB0byBmaXQ6IFJfQUFSQ0g2NF9DQUxMMjYgYWdhaW5z dCB1bmRlZmluZWQgc3ltYm9sIGBpb3ZhX2NhY2hlX3B1dCcKPj4+Pgo+Pj4+IFNlbGVjdCBJT01N VV9JT1ZBIHdoaWxlIENPTVBJTEVfVEVTVCBpcyBzZXQgdG8gZml4IHRoaXMuCj4+Pj4KPj4+PiBS ZXBvcnRlZC1ieTogSHVsayBSb2JvdCA8aHVsa2NpQGh1YXdlaS5jb20+Cj4+Pj4gRml4ZXM6IDUy NDk5YTZhZDJhZSAoImdwdTogaG9zdDF4OiBzZWxlY3QgSU9NTVVfSU9WQSIpCj4+Pj4gU2lnbmVk LW9mZi1ieTogWXVlSGFpYmluZyA8eXVlaGFpYmluZ0BodWF3ZWkuY29tPgo+Pj4+IC0tLQo+Pj4+ ICBkcml2ZXJzL2dwdS9ob3N0MXgvS2NvbmZpZyB8IDIgKy0KPj4+PiAgMSBmaWxlIGNoYW5nZWQs IDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4+Pj4KPj4+PiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvaG9zdDF4L0tjb25maWcgYi9kcml2ZXJzL2dwdS9ob3N0MXgvS2NvbmZpZwo+Pj4+ IGluZGV4IGNmOTg3YTMuLjM1NDIzMmQgMTAwNjQ0Cj4+Pj4gLS0tIGEvZHJpdmVycy9ncHUvaG9z dDF4L0tjb25maWcKPj4+PiArKysgYi9kcml2ZXJzL2dwdS9ob3N0MXgvS2NvbmZpZwo+Pj4+IEBA IC0yLDcgKzIsNyBAQAo+Pj4+ICBjb25maWcgVEVHUkFfSE9TVDFYCj4+Pj4gIAl0cmlzdGF0ZSAi TlZJRElBIFRlZ3JhIGhvc3QxeCBkcml2ZXIiCj4+Pj4gIAlkZXBlbmRzIG9uIEFSQ0hfVEVHUkEg fHwgKEFSTSAmJiBDT01QSUxFX1RFU1QpCj4+Pj4gLQlzZWxlY3QgSU9NTVVfSU9WQSBpZiBJT01N VV9TVVBQT1JUCj4+Pj4gKwlzZWxlY3QgSU9NTVVfSU9WQSBpZiAoSU9NTVVfU1VQUE9SVCB8fCBD T01QSUxFX1RFU1QpCj4+Pj4gIAloZWxwCj4+Pj4gIAkgIERyaXZlciBmb3IgdGhlIE5WSURJQSBU ZWdyYSBob3N0MXggaGFyZHdhcmUuCj4+Pj4gIAo+Pj4+Cj4+Pgo+Pj4gSXQgc2hvdWxkIGJlIGJl dHRlciB0byB1bmNvbmRpdGlvbmFsbHkgc2VsZWN0IElPTU1VX0lPVkEgaGVyZS4KPj4+Cj4+PiBU aGUgc2FtZSBjb3VsZCBiZSBkb25lIGZvciBkcml2ZXJzL3N0YWdpbmcvbWVkaWEvdGVncmEtdmRl LyBhbmQKPj4+IGRyaXZlcnMvZ3B1L2hvc3QxeC8sIHBsZWFzZSBzZWUgWzFdLgo+Pgo+PiBZZXAs IEkgd2lsbCByZXBvc3QsIHRoYW5rcyEKPiAKPiBObyBuZWVkIHRvIHJlc2VuZCwgSSBhbHJlYWR5 IGhhdmUgcGF0Y2hlcyBmb3IgdGhhdC4KCk9rLCB0aGFua3MhCgo+IAo+IFRoaWVycnkKPiAKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1237DCA9ECF for ; Fri, 1 Nov 2019 11:33:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E429221855 for ; Fri, 1 Nov 2019 11:33:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729713AbfKALdr (ORCPT ); Fri, 1 Nov 2019 07:33:47 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:57094 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725904AbfKALdr (ORCPT ); Fri, 1 Nov 2019 07:33:47 -0400 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id D808A592C0034E188BBA; Fri, 1 Nov 2019 19:33:45 +0800 (CST) Received: from [127.0.0.1] (10.133.213.239) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.439.0; Fri, 1 Nov 2019 19:33:42 +0800 Subject: Re: [PATCH -next] gpu: host1x: Fix compile test failure To: Thierry Reding References: <20191030135458.27960-1-yuehaibing@huawei.com> <283304d6-bf23-8107-29b6-9f3e7dda943c@gmail.com> <20191101094757.GA1167505@ulmo> CC: Dmitry Osipenko , , , , , , From: Yuehaibing Message-ID: <01997f01-27d7-7468-c331-9b2920ad8193@huawei.com> Date: Fri, 1 Nov 2019 19:33:41 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20191101094757.GA1167505@ulmo> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.133.213.239] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/11/1 17:47, Thierry Reding wrote: > On Thu, Oct 31, 2019 at 09:33:38PM +0800, Yuehaibing wrote: >> On 2019/10/31 6:26, Dmitry Osipenko wrote: >>> 30.10.2019 16:54, YueHaibing пишет: >>>> If IOMMU_SUPPORT is not set, but IOMMU_IOVA is m and >>>> COMPILE_TEST is y, building fails: >>>> >>>> drivers/gpu/host1x/dev.o: In function `host1x_remove': >>>> dev.c:(.text+0x624): undefined reference to `put_iova_domain' >>>> dev.c:(.text+0x624): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `put_iova_domain' >>>> dev.c:(.text+0x62c): undefined reference to `iova_cache_put' >>>> dev.c:(.text+0x62c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `iova_cache_put' >>>> >>>> Select IOMMU_IOVA while COMPILE_TEST is set to fix this. >>>> >>>> Reported-by: Hulk Robot >>>> Fixes: 52499a6ad2ae ("gpu: host1x: select IOMMU_IOVA") >>>> Signed-off-by: YueHaibing >>>> --- >>>> drivers/gpu/host1x/Kconfig | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig >>>> index cf987a3..354232d 100644 >>>> --- a/drivers/gpu/host1x/Kconfig >>>> +++ b/drivers/gpu/host1x/Kconfig >>>> @@ -2,7 +2,7 @@ >>>> config TEGRA_HOST1X >>>> tristate "NVIDIA Tegra host1x driver" >>>> depends on ARCH_TEGRA || (ARM && COMPILE_TEST) >>>> - select IOMMU_IOVA if IOMMU_SUPPORT >>>> + select IOMMU_IOVA if (IOMMU_SUPPORT || COMPILE_TEST) >>>> help >>>> Driver for the NVIDIA Tegra host1x hardware. >>>> >>>> >>> >>> It should be better to unconditionally select IOMMU_IOVA here. >>> >>> The same could be done for drivers/staging/media/tegra-vde/ and >>> drivers/gpu/host1x/, please see [1]. >> >> Yep, I will repost, thanks! > > No need to resend, I already have patches for that. Ok, thanks! > > Thierry >