From: pvorel <pvorel@suse.de>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 02/13] lib: Replace path_exist() with tst_path_exists()
Date: Mon, 10 Feb 2025 12:53:45 +0100 [thread overview]
Message-ID: <01a16c47a0920ed4c60db277087f9ea7@suse.de> (raw)
In-Reply-To: <20250210113212.29520-3-chrubis@suse.cz>
Hi Cyril,
On 2025-02-10 12:32, Cyril Hrubis wrote:
> Move and rename the path_exist() function from
> testcases/kernel/mem/lib/ to the to level library.
>
> This removes mem.h dependency from mem/cpuset/ test.
>
> Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> ---
> include/tst_fs.h | 10 ++++++++++
> lib/tst_path_exists.c | 23 +++++++++++++++++++++++
The only thing I don't like is creating file for single functions.
My long term plan was to have fewer files with more functions.
I'm sorry I did not point this out in v1, thus feel free to ignore it.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-02-10 11:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 11:31 [LTP] [PATCH v2 00/13] Cyril Hrubis
2025-02-10 11:32 ` [LTP] [PATCH v2 01/13] lib: tst_sys_conf: Add two functions Cyril Hrubis
2025-02-10 11:32 ` [LTP] [PATCH v2 02/13] lib: Replace path_exist() with tst_path_exists() Cyril Hrubis
2025-02-10 11:53 ` pvorel [this message]
2025-02-10 13:07 ` Cyril Hrubis
2025-02-10 13:44 ` pvorel
2025-02-10 13:54 ` Cyril Hrubis
2025-02-11 5:44 ` Li Wang
2025-02-12 9:59 ` Cyril Hrubis
2025-02-10 11:32 ` [LTP] [PATCH v2 03/13] lib: Add tst_mapping_in_range() Cyril Hrubis
2025-02-10 11:32 ` [LTP] [PATCH v2 04/13] testcases/kernel/mem: Move get_a_numa_node() Cyril Hrubis
2025-02-10 11:32 ` [LTP] [PATCH v2 05/13] testcases/kernel/mem: Move update_shm_size() Cyril Hrubis
2025-02-10 11:32 ` [LTP] [PATCH v2 06/13] testcases/kernel/mem: Move check_hugepage() + PATH_THP Cyril Hrubis
2025-02-10 11:32 ` [LTP] [PATCH v2 07/13] testcases/kernel/mem: Move NUMA bits to numa_helper.h Cyril Hrubis
2025-02-10 11:32 ` [LTP] [PATCH v2 08/13] testcases/kernel/mem: Move oom() fucntions to oom tests Cyril Hrubis
2025-02-10 11:32 ` [LTP] [PATCH v2 09/13] testcases/kernel/mem: Move KSM bits to ksm tests Cyril Hrubis
2025-02-10 13:20 ` pvorel
2025-02-10 11:32 ` [LTP] [PATCH v2 10/13] mem/swapping: Remove mem/lib refrence Cyril Hrubis
2025-02-10 11:32 ` [LTP] [PATCH v2 11/13] mem/vma: Remove mem/lib dependency Cyril Hrubis
2025-02-10 11:32 ` [LTP] [PATCH v2 12/13] mem/hugetlb: Remove mem/lib depenency Cyril Hrubis
2025-02-10 11:32 ` [LTP] [PATCH v2 13/13] testcases/kernel/mem: Remove library Cyril Hrubis
2025-02-10 11:45 ` [LTP] [PATCH v2 00/13] Get rid of testcases/kernel/mem/lib library Cyril Hrubis
2025-02-13 12:39 ` [LTP] [PATCH v2 00/13] Jan Stancek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01a16c47a0920ed4c60db277087f9ea7@suse.de \
--to=pvorel@suse.de \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.