From: Andrew Cooper <andrew.cooper3@citrix.com>
To: "Ahmed S. Darwish" <darwi@linutronix.de>,
Borislav Petkov <bp@alien8.de>, Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, John Ogness <john.ogness@linutronix.de>,
x86-cpuid@lists.linux.dev, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 07/12] tools/x86/kcpuid: Add rudimentary CPU vendor detection
Date: Thu, 6 Mar 2025 21:07:48 +0000 [thread overview]
Message-ID: <01a2a955-98a5-47f6-aeb2-275ba840a9fa@citrix.com> (raw)
In-Reply-To: <20250306205000.227399-8-darwi@linutronix.de>
On 06/03/2025 8:49 pm, Ahmed S. Darwish wrote:
> @@ -145,6 +166,40 @@ static inline bool has_subleafs(u32 f)
> return false;
> }
>
> +/*
> + * Leaf 0x0 EDX output, CPU vendor ID string bytes 4 - 7.
> + */
> +enum {
> + EDX_INTEL = fourcc('i', 'n', 'e', 'I'), /* Genu_ineI_ntel */
> + EDX_AMD = fourcc('e', 'n', 't', 'i'), /* Auth_enti_cAMD */
> + EDX_HYGON = fourcc('n', 'G', 'e', 'n'), /* Hygo_nGen_uine */
> + EDX_TRANSMETA = fourcc('i', 'n', 'e', 'T'), /* Genu_ineT_Mx86 */
> + EDX_CENTAUR = fourcc('a', 'u', 'r', 'H'), /* Cent_aurH_auls */
> + EDX_ZHAOXIN = fourcc('a', 'n', 'g', 'h'), /* Sh_angh_ai */
> +};
> +
> +static enum cpu_vendor identify_cpu_vendor(void)
> +{
> + u32 eax = 0, ebx, ecx = 0, edx;
> +
> + cpuid(&eax, &ebx, &ecx, &edx);
> +
> + switch (edx) {
> + case EDX_INTEL:
> + return VENDOR_INTEL;
> + case EDX_AMD:
> + case EDX_HYGON:
> + return VENDOR_AMD;
> + case EDX_TRANSMETA:
> + return VENDOR_TRANSMETA;
> + case EDX_CENTAUR:
> + case EDX_ZHAOXIN:
> + return VENDOR_CENTAUR;
> + default:
> + return VENDOR_UNKNOWN;
> + }
Many CPUs have ways of overriding the vendor string, thanks to
GenuineIntel being hardcoded in too many pieces of software.
I suggest you check all registers, lest you find yourself on a CPU
claiming EBX=0x68747541, ECX=0x6C65746E, EDX=0x6E65476E
~Andrew
next prev parent reply other threads:[~2025-03-06 21:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 20:49 [PATCH v1 00/12] tools/x86/kcpuid: x86-cpuid-db v2.2 update Ahmed S. Darwish
2025-03-06 20:49 ` [PATCH v1 01/12] tools/x86/kcpuid: Fix error handling Ahmed S. Darwish
2025-03-06 20:49 ` [PATCH v1 02/12] tools/x86/kcpuid: Remove unused local variable Ahmed S. Darwish
2025-03-06 20:49 ` [PATCH v1 03/12] tools/x86/kcpuid: Remove unused global variable Ahmed S. Darwish
2025-03-06 20:49 ` [PATCH v1 04/12] tools/x86/kcpuid: Simplify usage() handling Ahmed S. Darwish
2025-03-06 20:49 ` [PATCH v1 05/12] tools/x86/kcpuid: Refactor CPUID range handling for future expansion Ahmed S. Darwish
2025-03-06 20:49 ` [PATCH v1 06/12] tools/x86/kcpuid: Extend CPUID index mask macro Ahmed S. Darwish
2025-03-06 20:49 ` [PATCH v1 07/12] tools/x86/kcpuid: Add rudimentary CPU vendor detection Ahmed S. Darwish
2025-03-06 21:07 ` Andrew Cooper [this message]
2025-03-07 14:06 ` Ahmed S. Darwish
2025-03-06 22:00 ` Dave Hansen
2025-03-07 13:48 ` Ahmed S. Darwish
2025-03-07 15:46 ` H. Peter Anvin
2025-03-07 15:03 ` Dave Hansen
2025-03-10 14:21 ` Ahmed S. Darwish
2025-03-06 20:49 ` [PATCH v1 08/12] tools/x86/kcpuid: Restrict CPUID scanning to valid vendor ranges Ahmed S. Darwish
2025-03-06 20:49 ` [PATCH v1 09/12] tools/x86/kcpuid: Define Transmeta and Centaur index ranges Ahmed S. Darwish
2025-03-06 20:49 ` [PATCH v1 10/12] tools/x86/kcpuid: Update bitfields to x86-cpuid-db v2.0 Ahmed S. Darwish
2025-03-07 3:18 ` H. Peter Anvin
2025-03-07 15:07 ` Ahmed S. Darwish
2025-03-07 15:27 ` H. Peter Anvin
2025-03-10 14:47 ` Ahmed S. Darwish
2025-03-06 20:49 ` [PATCH v1 11/12] tools/x86/kcpuid: Update bitfields to x86-cpuid-db v2.2 Ahmed S. Darwish
2025-03-06 20:50 ` [PATCH v1 12/12] MAINTAINERS: Include kcpuid under X86 CPUID DATABASE Ahmed S. Darwish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01a2a955-98a5-47f6-aeb2-275ba840a9fa@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=darwi@linutronix.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86-cpuid@lists.linux.dev \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.