From: Fernando Fernandez Mancera <fmancera@suse.de>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
pablo@netfilter.org, phil@nwl.cc, VEGA <vega@nebusec.ai>
Subject: Re: [PATCH nf] netfilter: nfnetlink_queue: keep socket ownership when expanding skb
Date: Fri, 30 Oct 2026 16:12:19 +0100 [thread overview]
Message-ID: <01a502da-e5fa-4046-9d24-2dd84e8d5098@suse.de> (raw)
In-Reply-To: <auSysrRmBdIesdue@strlen.de>
On 10/30/26 4:07 PM, Florian Westphal wrote:
> Fernando Fernandez Mancera <fmancera@suse.de> wrote:
>> On 10/30/26 3:53 PM, Florian Westphal wrote:
>>> If you think its worth doing, then by all means, go for it!
>>
>> The ownership fix is trivial and already done so why not? Anyway, let's
>> see what does Pablo think and decide based on that. FWIW, I won't go for
>> the whole memory issue fix you mentioned before.
>
> Its not trivial, unfortunately, this needs wmem adjustments depending
> on destructor type, else accouting is off and sk cannot be released
> anymore (or we release to early if truesize was reduced).
Ah that is right. I missed it. Thanks Florian, let me take a look if
this does not take too much effort I might fix it. Otherwise let's drop
it. Although we might hear about this in the future due to LLMs.
next prev parent reply other threads:[~2026-10-30 15:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 13:57 [PATCH nf] netfilter: nfnetlink_queue: keep socket ownership when expanding skb Fernando Fernandez Mancera
2026-10-30 14:35 ` Florian Westphal
2026-10-30 14:40 ` Fernando Fernandez Mancera
2026-10-30 14:53 ` Florian Westphal
2026-10-30 14:57 ` Fernando Fernandez Mancera
2026-10-30 15:07 ` Florian Westphal
2026-10-30 15:12 ` Fernando Fernandez Mancera [this message]
2026-10-30 15:28 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01a502da-e5fa-4046-9d24-2dd84e8d5098@suse.de \
--to=fmancera@suse.de \
--cc=coreteam@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
--cc=vega@nebusec.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.