From: Sangbeom Kim <sbkim73@samsung.com>
To: "'Axel Lin'" <axel.lin@gmail.com>, linux-kernel@vger.kernel.org
Cc: "'Liam Girdwood'" <lrg@ti.com>,
"'Mark Brown'" <broonie@opensource.wolfsonmicro.com>
Subject: RE: [PATCH RFC 2/4] regulator: Rework s5m8767_set_voltage to support both LDOs and BUCKs
Date: Tue, 03 Apr 2012 14:40:48 +0900 [thread overview]
Message-ID: <01af01cd115c$52c63fc0$f852bf40$@com> (raw)
In-Reply-To: <1332131021.26765.4.camel@phoenix>
On Mon, Mar 19, 2012 at 1:24 PM, Axel Lin wrote:
> s5m8767_set_voltage not only implement set_voltage callbacks for LDOs,
> but also for BUCKs when s5m8767->buck_gpioindex is not set.
> s5m8767_set_voltage_buck actually only for buck[2|3|4] when
> s5m8767->buck_gpioindex is set.
> Conditionally calling s5m8767_set_voltage in s5m8767_set_voltage_buck makes
> the code hard to read.
>
> I think merging s5m8767_set_voltage_buck and s5m8767_set_voltage actually
> simplifies things. It's easy to use buck234_vol pointer to differentiate if
> we need to control voltage for buck[2|3|4] by DVS GPIOs.
>
> This patch reworks s5m8767_set_voltage to support both LDOx and BUCKx in all
> cases.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Sangbeom Kim <sbkim73@samsung.com>
Thanks,
Sangbeom.
next prev parent reply other threads:[~2012-04-03 5:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 4:22 [PATCH RESEND 1/4] regulator: Fix setting new voltage in s5m8767_set_voltage Axel Lin
2012-03-19 4:23 ` [PATCH RFC 2/4] regulator: Rework s5m8767_set_voltage to support both LDOs and BUCKs Axel Lin
2012-04-02 23:16 ` Sangbeom Kim
2012-04-03 0:00 ` Axel Lin
2012-04-03 5:40 ` Sangbeom Kim [this message]
2012-03-19 4:24 ` [PATCH RFC 3/4] regulator: Use one s5m8767_ops for " Axel Lin
2012-04-03 5:42 ` Sangbeom Kim
2012-03-19 4:25 ` [PATCH RFC 4/4] regulator: Replace regulator_desc_[ldo|buck] by s5m8767_regulator_desc macro Axel Lin
2012-04-03 5:54 ` Sangbeom Kim
2012-03-29 12:41 ` [PATCH RESEND 1/4] regulator: Fix setting new voltage in s5m8767_set_voltage Axel Lin
2012-03-30 5:56 ` Sangbeom Kim
2012-03-31 10:33 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01af01cd115c$52c63fc0$f852bf40$@com' \
--to=sbkim73@samsung.com \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.