From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49D74C43217 for ; Thu, 24 Nov 2022 15:09:27 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CCDC08560D; Thu, 24 Nov 2022 16:09:24 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=kontron.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=mysnt.onmicrosoft.com header.i=@mysnt.onmicrosoft.com header.b="X1SmTTkT"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 39DF885621; Thu, 24 Nov 2022 16:09:23 +0100 (CET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2070d.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e1a::70d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 107CD8560D for ; Thu, 24 Nov 2022 16:09:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=kontron.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=frieder.schrempf@kontron.de ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i+M8/OUFFFW5yL4KHVS9qQj24Y0ZkEEEGUzAZOjnd7EUD20Jmro/1FSveh4fgmyu0fjq9kl541datDeIAeixfn31Xaqx87lDUfvGt4d6VBjTW5xxrM768SO6W/Oxa1jI+GDWRgB0bTluhnNKcsmYIxkkRLhG4CtnuwZ7iQZJcRc5QzOQquJqPXv3BNMK+PQR0b9fL3vHlxm4/ZoV2LJuxTwVk2zU2+mfYzmyTMhSx3H3q2tHrjNQBq1Ikav3cisiwwyi5Fmb7LaXVF9kxO2ulSjj3ThBdd9MVWSg+K56LUXbNKLLmPMHxdxywct1vQ7MgoH0LtEjonFzsd6+3Y6Kxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dJaZELupEbdV6zC9k2I1l9ALkPyr2oAuLzmrzSBqN34=; b=L6P7n8/X6wSVVe5DlmM/zqO9g7SbWDma+IeqVJgH3alFxBGHEpwDCrzoHE5Fk6qOLKVHyFarCcUNB+kApVbZrFUv1LUNapo/9OD8ZszzAivsvZdfF6YBE2RFntrgDvHAPrpT+F1DE9b9MILtBUXFE9e9nCan1sbpVXt/ADRRsffaaETKtUppsQXlVLoOCIZcmAKhv8H6Ysr+8YGzaf3E9DbjsasgOV0lC7/3GjqK2Xu0eVYQhhB8QbtPugk4Rp/G+00xUizgnaVO3xW5KeFg6C65oxuERaH0tTiviSEB70/ySVxeOZFf0E2LwPRjLS1btofA8WdYil9Z7TFlxnjUmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=kontron.de; dmarc=pass action=none header.from=kontron.de; dkim=pass header.d=kontron.de; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mysnt.onmicrosoft.com; s=selector2-mysnt-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dJaZELupEbdV6zC9k2I1l9ALkPyr2oAuLzmrzSBqN34=; b=X1SmTTkTyxPvOYSnRt3GbF7Cn3zC4wY7JcVPmw6XSf8goxJa31zaBJQhgfkdO5kNzNPgA1Va/yrenGnulLWWaZSB3MSPADZ6aTJ6GDwgT0w+HxP+7Pl7dJ1hTelwz+X+Dw8XbQ4XybbI7V+h1RxSZEHRO4ESGgZoaHZY2k41wec= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=kontron.de; Received: from PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:263::10) by AS2PR10MB6544.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:55f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19; Thu, 24 Nov 2022 15:09:19 +0000 Received: from PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM ([fe80::f209:bc86:3574:2ae6]) by PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM ([fe80::f209:bc86:3574:2ae6%4]) with mapi id 15.20.5834.015; Thu, 24 Nov 2022 15:09:19 +0000 Message-ID: <01af52fa-dba6-d256-2f50-2bf39ac3c488@kontron.de> Date: Thu, 24 Nov 2022 16:09:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 1/7] mtd: replace name of 'rfree' field with 'free' in struct mtd_ooblayout_ops to better match it's description Content-Language: en-US To: Fabio Estevam , Michael Nazzareno Trimarchi Cc: mikhail.kshevetskiy@iopsys.eu, Simon Glass , u-boot@lists.denx.de, Dario Binacchi , Stefan Roese , agnau@iopsys.eu References: <20221006031501.110290-1-mikhail.kshevetskiy@iopsys.eu> From: Frieder Schrempf In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0075.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::17) To PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:263::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR10MB5681:EE_|AS2PR10MB6544:EE_ X-MS-Office365-Filtering-Correlation-Id: f459d675-3288-4185-db5b-08dace2ddc83 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cN/Ofl7exfcji5W7x2HU712P9m13MjWjC+/K2LHOsxBp8ymNsTFHZ0z7AqVgctz0RgqC4Zv4MMdSXQU1i/96BQRskCyOrSzyvEl0VYAHYE5Wm9LF0p8FmrjSLPUjWn96G0unuofKIEFo/L5tavRZVgcdj7QYdXmy41y7loiASQO26s5/xqZ+Q4XpiJrtULQoX7hZ/I/EzCv6LyV3HsZbUPsqbBZG7mOxQ1ETN7+NqcD3FNeHZG4PW4rxeaGrwCAfoflRBD4DsW2JeQL38CjDOEnDgMjbX+CBgB0msjSLQwTEEqONFj9tLT/y/64ZWdoukUCxKHt3umyVsGBX0qOgzZuK1+kcVm7LYPAl6flg4JZ+LUEjuiuIUWKsdNZxmYtqVsrNlYNxp+dT5Z8NAym4DfUGcxPAV4vk53udpMRjGXMa0GGAHKkdXGeJd1tlsiP87nnD7UhQFxr3GNvxsQs0xbEyZlj1a4ATaUuoF1FIUs2UNoV2427ea3Nnr/9UISGcEdZLPyx+B0dQamtOPGgtUfHs4AG+mecVVaF+aMkZ2+aAv9xa5YelVOqJ9LVyGYdIbDsLbwI1jCN9P3sKih4wQc1GA9N5XjT7Q7duCFWcf/7e2ZGzTIFQLTgycJC+sZ8dPeR9DMUfjyBLSkThkd/eZ9WQ9aW6k/y+WWNqg/AyLc4qx7ekCkwJSFUMs78b2Z44QixSHajoxCQujAs9kYvbacnm+yKquWD9Ri+Pij4dJzQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230022)(4636009)(396003)(136003)(39860400002)(366004)(376002)(346002)(451199015)(83380400001)(31686004)(31696002)(54906003)(6506007)(6486002)(110136005)(86362001)(36756003)(38100700002)(6512007)(2616005)(186003)(53546011)(5660300002)(44832011)(478600001)(41300700001)(8936002)(66556008)(4326008)(66946007)(66476007)(2906002)(8676002)(316002)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c3EwV0xkaU1BYkhjY2E4Y2dNbUdudU5Gb0xhYUFZUUcyMVV4bVk3WU8yWGp4?= =?utf-8?B?YW1hVlRxV2NJSGo5YXFpb2dWZ0l4MzIwT1o0TWRtZmlXTEZRdkVRa1BXamJ0?= =?utf-8?B?VktBUjJwY1JDdm5kMXp1REh1VEVpZGdaanQ4b0JXaVdzYkhoZTgvTnIraGM1?= =?utf-8?B?cFhEUzIyK0dmTk1PNDBBTlRMVkxZZm1RVTNVU1FEUVBVWU5kZElnbm4vZk1v?= =?utf-8?B?b1VCVGRlUGVzbVdqTzlGVVJHbWs3QkhjSUVnRC9wT1N5eVllU09kak41R0tY?= =?utf-8?B?S1JBMit6WGJyL2oyQ1RJQThadU1qV0Y0ZS9WNkUzcnMzRFlVMllVVFZ0Vmtt?= =?utf-8?B?SXpMRFpWNWV2TjVWNzNjbEY3cDU4MGJldGZrVG1mSElSZVdTYlNVSlJ0cWxM?= =?utf-8?B?WHQ3ZkNnbG9WaitYakt1Z3poNEJWUnc1VWUvVFFBTytIUVFlYUw0T3hFejFV?= =?utf-8?B?SHJzKzVMSzJNeGhSaWVCR1M0RlljRGlJd0lKNDhWMlFiRFdoSzYrdnpxdXZ4?= =?utf-8?B?WE9pd2dlZW5wamp2NVBBUzI4aU81WWtjbVJZRkRlT0xNa0Y1Q1ZmK2pCSVpT?= =?utf-8?B?NU1MQkN3ZkZ5L2hjbVgrd3c5WEV3UnFuK2tkU2tiK0VPeUk2OU1YRy9Jai95?= =?utf-8?B?WWMxNWtlSDMydXBwbVI2ei9MWjl1KzZ4akE2aytHSThibStxM2t2MDFNemhu?= =?utf-8?B?dWdPYTByNC80SUY3aEg5OWdqRXdUNERGaWZYQkN3cUg0QUFmR2hsenNVMmxi?= =?utf-8?B?Q2xOaTZUQWxUT1I1QTRmSVVwdWIvSTNVa3NmSTEveTA1R2ZyYU1RNE52SGpY?= =?utf-8?B?MUNVbWtER1h6LzdRb1pTNzJ6OXJXMXlDVjlUUWYycEpCWkZPWlNNTEtJQXJa?= =?utf-8?B?MnF1MGNram1PT1lLM3k5NTNKWXFDNTFnc2JjL0tibjhiQmRBV1pLSDlFWi83?= =?utf-8?B?Vk9iMlhEZC9yWis4eGc2QnFZYTg1eE5vTENHcDFDWFI2VHJNYjJobWkxdzFl?= =?utf-8?B?a2xYVnZ2WGVBa1Ribm9FL1Y2dFFHU1dHOVdtekNlbTJFQy9Ea1JvSzhrUExK?= =?utf-8?B?a1AxZFc0bkZUMlBtd3lwN0JOOTlzQVVTaUFPeVFBZzdLVUxlQUxlelg4Ymg3?= =?utf-8?B?ZHpCemFpQmI1YzZ3ZTV0U08wRTVyeVplQWtJaEl1Q3RwY0tkMk9IdUNlUmFQ?= =?utf-8?B?elhJa3JKYjM3dGhSYTd3c01mVEFRSktxR0RxeEplbzNMd2ZRUXJzbmtuVXhh?= =?utf-8?B?M0tCclg4NDZwMTJhajkycGh4ZGV6ZC9iNEVVMHduOUt5a2NuYXIxN1gxZkJk?= =?utf-8?B?eGQrKzl2aTB4NlBZWHVCenNsM0pBdkhjRUIvM2YvcHZxenFOYVpxb0hYYlcw?= =?utf-8?B?M3VXeW92cmZpTGVROW9GSlFWbnljR2x4NERGUmphbFRzZWRSOTArVHN4cnFZ?= =?utf-8?B?S1MxbC9HWTBSbW9BK2JYakZZQ1lmRTdOcmpSQVg0RjNRbHhPZHBDdFFyZ2Ns?= =?utf-8?B?cDU2TkU2YTZselRXT0thNWxWblh5Q1RJTnVnM1hERkI3RWNPWlJKUXdQQk41?= =?utf-8?B?QWdmaFdhQ3BjbEVGUFRsNXptQmlWY1pMakFpRU9KVkpCSVRFZkJLOGN2alZH?= =?utf-8?B?Q3VLQU1OUldQQk1RMkdaRWorNmNFQVJYbFkzR3NyNnpqL2pEbHpsWjM3UEhT?= =?utf-8?B?aWtTNHNDU0RPQ1NBT1QxWnVDRENMR2tML2RwRkIyRGUvZ0JOQjMyQWViQlpF?= =?utf-8?B?L1h1SmplZHc1OVRLVnZvK0F2aDFiRnJYeUl0T3RPeWtBbXZzWlFlaHRVRWxT?= =?utf-8?B?L3VLVXg0dWQrMllGL2g1bnhMVDY1UXdvSzk1SEtSQzVpayt6dFpSU3NXKzJz?= =?utf-8?B?d0tJWmlHYTg1dU9DN3hIL0pYaTdXZS9mYWFienAwQUtCYmVSQXp2dGcvNGt5?= =?utf-8?B?djU0VkVzU0t4b2JaMnRKbE5KVHdud2cyR0JEZjRPRUk4c2lrb1pRamUyWDBs?= =?utf-8?B?UEx5aC9FdUhaU21QWlRjdVREVHdBWEQzQ2ZTeVpnNldHYVF2V1N3dUtGWC9H?= =?utf-8?B?VGd4UlNqbyt4V0xQVVh6V1Y5eGUyWjFlYWtmN1VISmI3OGlOZ0tneGt6NWhR?= =?utf-8?B?b2YwUnhFdkJxUXdnWmIxUndQZmxrcDIzeDgxRlJZeExvaHAxV2pCeC9vb0dR?= =?utf-8?Q?FN6ieWkVa/jZm9u6zCKSfaNaQYVdEf3Wu1SY711WeDZN?= X-OriginatorOrg: kontron.de X-MS-Exchange-CrossTenant-Network-Message-Id: f459d675-3288-4185-db5b-08dace2ddc83 X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2022 15:09:19.6700 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GcOoY6blcWbtNJJO8en5KrESL1/GsZMmzCohJDe3EDGU3yMnLOZYDTMigBBvDAGPrRyjPXyCRJIudyHzJbiEu57eI2W1c/KJ6HbLT1s5jh0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR10MB6544 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 07.10.22 13:58, Fabio Estevam wrote: > On Fri, Oct 7, 2022 at 8:34 AM Michael Nazzareno Trimarchi > wrote: > >> About this change, there was a commit from Simon 8d38a8459b0 >> that was renamed. You ask basically to revert it > > Correct, what about fixing it like this? > > diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h > index ff635bd716..09f5269887 100644 > --- a/include/linux/mtd/mtd.h > +++ b/include/linux/mtd/mtd.h > @@ -122,7 +122,7 @@ struct mtd_oob_region { > * @ecc: function returning an ECC region in the OOB area. > * Should return -ERANGE if %section exceeds the total number of > * ECC sections. > - * @free: function returning a free region in the OOB area. > + * @rfree: function returning a free region in the OOB area. > * Should return -ERANGE if %section exceeds the total number of > * free sections. > */ But do we really want to stay out of sync with the Linux kernel code? Is the reasoning behind Simon's change in 8d38a8459b0 still valid today?