From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53380)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1ZFOfZ-000536-QR
	for qemu-devel@nongnu.org; Wed, 15 Jul 2015 11:32:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1ZFOfU-00032W-PG
	for qemu-devel@nongnu.org; Wed, 15 Jul 2015 11:32:25 -0400
Received: from mailout4.w1.samsung.com ([210.118.77.14]:19510)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1ZFOfU-00031n-KY
	for qemu-devel@nongnu.org; Wed, 15 Jul 2015 11:32:20 -0400
Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245])
	by mailout4.w1.samsung.com
	(Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5
	2014)) with ESMTP id <0NRJ00DYCCHR7X80@mailout4.w1.samsung.com> for
	qemu-devel@nongnu.org; Wed, 15 Jul 2015 16:32:15 +0100 (BST)
From: Pavel Fedin <p.fedin@samsung.com>
References: <cover.1436859955.git.p.fedin@samsung.com>
	<d1f4fb3c680fbf3fb67bd6cf5fa8bd2428f5fbb1.1436859955.git.p.fedin@samsung.com>
	<55A6704E.4050500@freescale.com>
In-reply-to: <55A6704E.4050500@freescale.com>
Date: Wed, 15 Jul 2015 18:32:14 +0300
Message-id: <01b801d0bf13$6d44be90$47ce3bb0$@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii
Content-transfer-encoding: 7bit
Content-language: ru
Subject: Re: [Qemu-devel] [PATCH v4 4/5] Initial implementation of vGICv3
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: 'Diana Craciun' <diana.craciun@freescale.com>, qemu-devel@nongnu.org
Cc: 'Peter Maydell' <peter.maydell@linaro.org>, 'Shlomo Pongratz' <shlomopongratz@gmail.com>, 'Shlomo Pongratz' <shlomo.pongratz@huawei.com>, 'Christoffer Dall' <christoffer.dall@linaro.org>, 'Eric Auger' <eric.auger@linaro.org>

 Hello!

> Here GICV3_INTERNAL is used, but kvm_arch_gicv3_set_irq relies on
> kvm_arm_gic_set_irq which is using GIC_INTERNAL, so the GICv3 related
> code is using both defines.

 The change relies on these definitions being equal. Ok, i agree this is a kind of hack and will
redo this in v5.

> As we do not have yet support for ITS implementation in QEMU the device
> tree for a GICv3 guest will have a msi-parent property in the device
> tree which will point to nothing:
> 
> "msi-parent = <0x0>"

 Oops, thank you, i forgot about this. Will fix.

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia