From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 294F8C433EF for ; Wed, 20 Oct 2021 07:04:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 040B26112D for ; Wed, 20 Oct 2021 07:04:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229820AbhJTHHI (ORCPT ); Wed, 20 Oct 2021 03:07:08 -0400 Received: from mga11.intel.com ([192.55.52.93]:61598 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229741AbhJTHHH (ORCPT ); Wed, 20 Oct 2021 03:07:07 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10142"; a="226171625" X-IronPort-AV: E=Sophos;i="5.87,166,1631602800"; d="scan'208";a="226171625" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2021 00:04:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,166,1631602800"; d="scan'208";a="483605079" Received: from dengjie-mobl1.ccr.corp.intel.com (HELO [10.239.154.68]) ([10.239.154.68]) by orsmga007.jf.intel.com with ESMTP; 20 Oct 2021 00:04:46 -0700 Subject: Re: [PATCH 1/2] i2c: virtio: disable timeout handling To: Viresh Kumar Cc: Greg KH , Wolfram Sang , Vincent Whitchurch , virtualization@lists.linux-foundation.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@axis.com References: <20211019074647.19061-2-vincent.whitchurch@axis.com> <20211019080913.oajrvr2msz5enzvz@vireshk-i7> <20211019094203.3kjzch7ipbdv7peg@vireshk-i7> <20211019143748.wrpqopj2hmpvblh4@vireshk-i7> <94aa39ab-4ed6-daee-0402-f58bfed0cadd@intel.com> <8e182ea8-5016-fa78-3d77-eefba7d58612@intel.com> <20211020064128.y2bjsbdmpojn7pjo@vireshk-i7> From: Jie Deng Message-ID: <01d9c992-28cc-6644-1e82-929fc46f91b4@intel.com> Date: Wed, 20 Oct 2021 15:04:45 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211020064128.y2bjsbdmpojn7pjo@vireshk-i7> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On 2021/10/20 14:41, Viresh Kumar wrote: > On 20-10-21, 14:35, Jie Deng wrote: >> Yes, but we need to know what's the best value to be configured for a >> specific "other side". >> >> I think the "other side" should be more aware of what value is reasonable to >> be used. > If we _really_ need that, then it would require an update to the > specification first. > > I am not sure if the other side is the only party in play here. It > depends on the entire setup and not just the hardware device. > Specially with virtualisation things become really slow because of > context switches, etc. It may be better for the guest userspace to > decide on the value. > > Since this is specially for virtualisation, the kernel may set the > value to few HZ by default, lets say 10 (Yeah its really high) :). I'm OK with this way for the simplicity. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21122C433F5 for ; Wed, 20 Oct 2021 07:04:58 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E0DB600EF for ; Wed, 20 Oct 2021 07:04:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9E0DB600EF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 69E0240656; Wed, 20 Oct 2021 07:04:57 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MxeKeDJnShIM; Wed, 20 Oct 2021 07:04:56 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id 253DB40649; Wed, 20 Oct 2021 07:04:56 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id ECBBEC0011; Wed, 20 Oct 2021 07:04:55 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id C7F1CC000D for ; Wed, 20 Oct 2021 07:04:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id A394C60838 for ; Wed, 20 Oct 2021 07:04:54 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3qaEk3SU8Q6E for ; Wed, 20 Oct 2021 07:04:53 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by smtp3.osuosl.org (Postfix) with ESMTPS id 1E41560766 for ; Wed, 20 Oct 2021 07:04:52 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10142"; a="228659418" X-IronPort-AV: E=Sophos;i="5.87,166,1631602800"; d="scan'208";a="228659418" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2021 00:04:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,166,1631602800"; d="scan'208";a="483605079" Received: from dengjie-mobl1.ccr.corp.intel.com (HELO [10.239.154.68]) ([10.239.154.68]) by orsmga007.jf.intel.com with ESMTP; 20 Oct 2021 00:04:46 -0700 Subject: Re: [PATCH 1/2] i2c: virtio: disable timeout handling To: Viresh Kumar References: <20211019074647.19061-2-vincent.whitchurch@axis.com> <20211019080913.oajrvr2msz5enzvz@vireshk-i7> <20211019094203.3kjzch7ipbdv7peg@vireshk-i7> <20211019143748.wrpqopj2hmpvblh4@vireshk-i7> <94aa39ab-4ed6-daee-0402-f58bfed0cadd@intel.com> <8e182ea8-5016-fa78-3d77-eefba7d58612@intel.com> <20211020064128.y2bjsbdmpojn7pjo@vireshk-i7> From: Jie Deng Message-ID: <01d9c992-28cc-6644-1e82-929fc46f91b4@intel.com> Date: Wed, 20 Oct 2021 15:04:45 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211020064128.y2bjsbdmpojn7pjo@vireshk-i7> Content-Language: en-US Cc: Greg KH , Vincent Whitchurch , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Wolfram Sang , kernel@axis.com, linux-i2c@vger.kernel.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On 2021/10/20 14:41, Viresh Kumar wrote: > On 20-10-21, 14:35, Jie Deng wrote: >> Yes, but we need to know what's the best value to be configured for a >> specific "other side". >> >> I think the "other side" should be more aware of what value is reasonable to >> be used. > If we _really_ need that, then it would require an update to the > specification first. > > I am not sure if the other side is the only party in play here. It > depends on the entire setup and not just the hardware device. > Specially with virtualisation things become really slow because of > context switches, etc. It may be better for the guest userspace to > decide on the value. > > Since this is specially for virtualisation, the kernel may set the > value to few HZ by default, lets say 10 (Yeah its really high) :). I'm OK with this way for the simplicity. _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization