From: "Jaehoon Chung" <jh80.chung@samsung.com>
To: "'Patrick DELAUNAY'" <patrick.delaunay@foss.st.com>,
"'Patrice Chotard'" <patrice.chotard@foss.st.com>,
<u-boot@lists.denx.de>
Cc: "'U-Boot STM32'" <uboot-stm32@st-md-mailman.stormreply.com>,
"'Peng Fan'" <peng.fan@nxp.com>,
"'Sean Anderson'" <seanga2@gmail.com>,
"'Simon Glass'" <sjg@chromium.org>,
"'Tom Rini'" <trini@konsulko.com>
Subject: RE: [PATCH 2/2] mmc: stm32_sdmmc2: Fix AARCH64 compilation warnings
Date: Wed, 17 Apr 2024 20:11:27 +0900 [thread overview]
Message-ID: <01e101da90b7$fe546690$fafd33b0$@samsung.com> (raw)
In-Reply-To: <8602799a-7c52-4308-a58e-4986de57210b@foss.st.com>
> -----Original Message-----
> From: Patrick DELAUNAY <patrick.delaunay@foss.st.com>
> Sent: Wednesday, April 17, 2024 6:02 PM
> To: Patrice Chotard <patrice.chotard@foss.st.com>; u-boot@lists.denx.de
> Cc: U-Boot STM32 <uboot-stm32@st-md-mailman.stormreply.com>; Jaehoon Chung <jh80.chung@samsung.com>;
> Peng Fan <peng.fan@nxp.com>; Sean Anderson <seanga2@gmail.com>; Simon Glass <sjg@chromium.org>; Tom
> Rini <trini@konsulko.com>
> Subject: Re: [PATCH 2/2] mmc: stm32_sdmmc2: Fix AARCH64 compilation warnings
>
> Hi,
>
> On 3/8/24 15:26, Patrice Chotard wrote:
> > When building with AARCH64 defconfig, we got warnings, fix them.
> >
> > Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
> > ---
> >
> > drivers/mmc/stm32_sdmmc2.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/mmc/stm32_sdmmc2.c b/drivers/mmc/stm32_sdmmc2.c
> > index d4982a14281..39ae79ba129 100644
> > --- a/drivers/mmc/stm32_sdmmc2.c
> > +++ b/drivers/mmc/stm32_sdmmc2.c
> > @@ -220,9 +220,9 @@ static void stm32_sdmmc2_start_data(struct udevice *dev,
> >
> > if (data->flags & MMC_DATA_READ) {
> > data_ctrl |= SDMMC_DCTRL_DTDIR;
> > - idmabase0 = (u32)data->dest;
> > + idmabase0 = (u32)(long)data->dest;
> > } else {
> > - idmabase0 = (u32)data->src;
> > + idmabase0 = (u32)(long)data->src;
> > }
> >
> > /* Set the SDMMC DataLength value */
> > @@ -463,8 +463,8 @@ retry_cmd:
> >
> > stm32_sdmmc2_start_cmd(dev, cmd, cmdat, &ctx);
> >
> > - dev_dbg(dev, "send cmd %d data: 0x%x @ 0x%x\n",
> > - cmd->cmdidx, data ? ctx.data_length : 0, (unsigned int)data);
> > + dev_dbg(dev, "send cmd %d data: 0x%x @ 0x%p\n",
> > + cmd->cmdidx, data ? ctx.data_length : 0, data);
> >
> > ret = stm32_sdmmc2_end_cmd(dev, cmd, &ctx);
> >
>
>
>
> Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
Best Regards,
Jaehoon Chung
>
> Thanks
> Patrick
next prev parent reply other threads:[~2024-04-17 11:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 14:26 [PATCH 1/2] mmc: stm32_sdmmc2: Add "st,stm32mp25-sdmmc2" compatible Patrice Chotard
2024-03-08 14:26 ` [PATCH 2/2] mmc: stm32_sdmmc2: Fix AARCH64 compilation warnings Patrice Chotard
2024-04-17 9:02 ` Patrick DELAUNAY
2024-04-17 11:11 ` Jaehoon Chung [this message]
2024-04-19 12:32 ` Patrice CHOTARD
2024-04-17 9:01 ` [PATCH 1/2] mmc: stm32_sdmmc2: Add "st,stm32mp25-sdmmc2" compatible Patrick DELAUNAY
2024-04-17 11:10 ` Jaehoon Chung
2024-04-19 12:32 ` Patrice CHOTARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01e101da90b7$fe546690$fafd33b0$@samsung.com' \
--to=jh80.chung@samsung.com \
--cc=patrice.chotard@foss.st.com \
--cc=patrick.delaunay@foss.st.com \
--cc=peng.fan@nxp.com \
--cc=seanga2@gmail.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=uboot-stm32@st-md-mailman.stormreply.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.