All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jaehoon Chung" <jh80.chung@samsung.com>
To: "'Shree Ramamoorthy'" <s-ramamoorthy@ti.com>,
	<u-boot@lists.denx.de>, <trini@konsulko.com>
Cc: <m-leonard@ti.com>, <praneeth@ti.com>
Subject: RE: [PATCH v1 1/2] power: regulator: replace printf() with pr_err()
Date: Thu, 19 Dec 2024 07:44:37 +0900	[thread overview]
Message-ID: <01e301db519e$6b18ed80$414ac880$@samsung.com> (raw)
In-Reply-To: <20241218171236.1022565-2-s-ramamoorthy@ti.com>



> -----Original Message-----
> From: Shree Ramamoorthy <s-ramamoorthy@ti.com>
> Sent: Thursday, December 19, 2024 2:13 AM
>
> Replace printf() with pr_err() because pr_err() has a uniform print format
> and takes into consideration the log levels supported.
>
> Signed-off-by: Shree Ramamoorthy <s-ramamoorthy@ti.com>

Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>

Best Regards,
Jaehoon Chung

> ---
>  drivers/power/regulator/tps65219_regulator.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/power/regulator/tps65219_regulator.c
> b/drivers/power/regulator/tps65219_regulator.c
> index b7124fed0245..4b0fb205909a 100644
> --- a/drivers/power/regulator/tps65219_regulator.c
> +++ b/drivers/power/regulator/tps65219_regulator.c
> @@ -250,7 +250,7 @@ static int tps65219_ldo_probe(struct udevice *dev)
>  	/* idx must be in 1..TPS65219_LDO_NUM */
>  	idx = dev->driver_data;
>  	if (idx < 1 || idx > TPS65219_LDO_NUM) {
> -		printf("Wrong ID for regulator\n");
> +		pr_err("Wrong ID for regulator\n");
>  		return -EINVAL;
>  	}
>
> @@ -271,7 +271,7 @@ static int tps65219_buck_probe(struct udevice *dev)
>  	/* idx must be in 1..TPS65219_BUCK_NUM */
>  	idx = dev->driver_data;
>  	if (idx < 1 || idx > TPS65219_BUCK_NUM) {
> -		printf("Wrong ID for regulator\n");
> +		pr_err("Wrong ID for regulator\n");
>  		return -EINVAL;
>  	}
>
> --
> 2.34.1




  reply	other threads:[~2024-12-18 22:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-18 17:12 [PATCH v1 0/2] TPS65219 U-Boot Driver Clean-Up Shree Ramamoorthy
2024-12-18 17:12 ` [PATCH v1 1/2] power: regulator: replace printf() with pr_err() Shree Ramamoorthy
2024-12-18 22:44   ` Jaehoon Chung [this message]
2024-12-18 17:12 ` [PATCH v1 2/2] power: replace magic numbers with macros Shree Ramamoorthy
2024-12-18 22:44   ` Jaehoon Chung
2024-12-18 22:55     ` Shree Ramamoorthy
2024-12-18 23:26       ` Jaehoon Chung
2024-12-19 17:47         ` Shree Ramamoorthy
2024-12-20  2:04           ` Jaehoon Chung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='01e301db519e$6b18ed80$414ac880$@samsung.com' \
    --to=jh80.chung@samsung.com \
    --cc=m-leonard@ti.com \
    --cc=praneeth@ti.com \
    --cc=s-ramamoorthy@ti.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.