From: "Frank Filz" <ffilzlnx@mindspring.com>
To: "'Bruce Fields'" <bfields@fieldses.org>
Cc: <linux-nfs@vger.kernel.org>
Subject: RE: Pull request for pynfs
Date: Mon, 19 Oct 2015 15:00:56 -0700 [thread overview]
Message-ID: <01e401d10ab9$a2691c00$e73b5400$@mindspring.com> (raw)
In-Reply-To: <20151019214801.GA16551@fieldses.org>
> On Fri, Oct 16, 2015 at 01:44:42PM -0700, Frank Filz wrote:
> > Bruce,
> >
> > Please pull the top patch from:
> >
> > https://github.com/ffilz/pynfs/commits/master
> >
> > It fixes CID2 to allow NFS4_OK when SETCLIENTID with a different
> > principal replaces a clientid that has no state, and adds CID2a which
> > expects NFS4ERR_CLID_INUSE since it does have state.
>
> Thanks!
>
> This leave us with two test functions both named "testInUse".
>
> I applied the following to get both tests working.
Oops, sorry...
Frank
> diff --git a/nfs4.0/servertests/st_setclientid.py
> b/nfs4.0/servertests/st_setclientid.py
> index 0fb59cd7f542..fbeab22e5026 100644
> --- a/nfs4.0/servertests/st_setclientid.py
> +++ b/nfs4.0/servertests/st_setclientid.py
> @@ -50,7 +50,7 @@ def testClientUpdateCallback(t, env):
> res = c.close_file(t.code, fh, stateid)
> check(res, msg="Close after updating callback info")
>
> -def testInUse(t, env):
> +def testNotInUse(t, env):
> """SETCLIENTID with same nfs_client_id.id should return NFS4ERR_OK
> if there is no active state
>
---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus
next prev parent reply other threads:[~2015-10-19 22:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 20:44 Pull request for pynfs Frank Filz
2015-10-19 21:48 ` Bruce Fields
2015-10-19 22:00 ` Frank Filz [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-08-14 23:55 Frank Filz
2017-08-24 19:51 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01e401d10ab9$a2691c00$e73b5400$@mindspring.com' \
--to=ffilzlnx@mindspring.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.