From: "Adam Kropelin" <akropel1@rochester.rr.com>
To: "Rusty Russell" <rusty@rustcorp.com.au>,
"Tim Bird" <tim.bird@am.sony.com>
Cc: "linux kernel" <linux-kernel@vger.kernel.org>,
"Andrew Morton" <akpm@osdl.org>
Subject: Re: [PATCH] - trivial comment fixups in init/main.c
Date: Tue, 17 Aug 2004 07:45:43 -0400 [thread overview]
Message-ID: <01f501c4844f$ba86dd60$03c8a8c0@kroptech.com> (raw)
In-Reply-To: 20040817095601.4E7F22BEC3@ozlabs.org
Rusty Russell wrote:
> In message <40F42C44.5010603@am.sony.com> you write:
>> This patch has some trivial comment fixups for init/main.c, to bring
>> the comments into consistency with the coding style of the kernel.
>
> Personally, I prefer my comments quiet and unobtrusive, and I think
> you'll find Linus' code tends to be the same.
>
> Not to start a flame war, but since I started using a colorizing
> editor for code, I found there was no need to waste vertical space
> with large banners. (This in my mind justifies the X project's entire
> existence).
Personally, I agree with you. Andrew specifically requested this patch to
bring a few oddball comments in line with those throughout the rest of the
file. I'd be happy to go the other way instead.
--Adam
next prev parent reply other threads:[~2004-08-17 12:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-13 18:39 [PATCH] - trivial comment fixups in init/main.c Tim Bird
2004-08-17 9:53 ` Rusty Russell
2004-08-17 11:45 ` Adam Kropelin [this message]
2004-08-17 17:31 ` Tim Bird
2004-08-17 17:42 ` Christoph Hellwig
2004-08-26 8:42 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01f501c4844f$ba86dd60$03c8a8c0@kroptech.com' \
--to=akropel1@rochester.rr.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=tim.bird@am.sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.