From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp-out06.msg.oleane.net ([62.161.7.4]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Z0rUi-0001an-1A for ath10k@lists.infradead.org; Fri, 05 Jun 2015 13:17:11 +0000 Received: from smtp29.msg.oleane.net (smtp29.mail.priv [172.17.20.151]) by smtp-out06.msg.oleane.net with ESMTP id t55B7KwB026547 for ; Fri, 5 Jun 2015 13:07:20 +0200 From: "voncken" References: <01eb01d09f64$fd522730$f7f67590$@acksys.fr> <01f701d09f71$47ae9910$d70bcb30$@acksys.fr> In-Reply-To: Subject: RE: ATH10K and VLAN : Frame with VLAN tag are not sent Date: Fri, 5 Jun 2015 12:46:11 +0200 Message-ID: <01fb01d09f7c$d6bdfa00$8439ee00$@acksys.fr> MIME-Version: 1.0 Content-Language: fr List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: 'Michal Kazior' Cc: 'linux-wireless' , ath10k@lists.infradead.org PiBEZSA6IGxpbnV4LXdpcmVsZXNzLW93bmVyQHZnZXIua2VybmVsLm9yZyBbbWFpbHRvOmxpbnV4 LXdpcmVsZXNzLQo+IG93bmVyQHZnZXIua2VybmVsLm9yZ10gRGUgbGEgcGFydCBkZSBNaWNoYWwg S2F6aW9yCj4gRW52b3nDqSA6IHZlbmRyZWRpIDUganVpbiAyMDE1IDExOjQ2Cj4gw4AgOiB2b25j a2VuCj4gQ2MgOiBsaW51eC13aXJlbGVzczsgYXRoMTBrQGxpc3RzLmluZnJhZGVhZC5vcmcKPiBP YmpldCA6IFJlOiBBVEgxMEsgYW5kIFZMQU4gOiBGcmFtZSB3aXRoIFZMQU4gdGFnIGFyZSBub3Qg c2VudAo+IAo+IFsuLi5dCj4gPj4gSSBzZWUgbm8gcmVhc29uIHdoeSB0aGlzIHNob3VsZCBmYWls LiBUaGUgZG90MXEgZW5jYXBzdWxhdGlvbgo+ID4+IHNob3VsZG4ndCBpbmZsdWVuY2UgaG93IGZp cm13YXJlIGJlaGF2ZXMuLiBidXQgbWF5YmUgSSdtIHdyb25nLgo+ID4+Cj4gPj4gSXQncyBzdGls bCB1bmNsZWFyIHRvIG1lIHdoYXQgeW91ciB0b3BvbG9neSBsb29rcyBsaWtlLiBQZXJoYXBzCj4g Pj4geW91J3JlIGhhdmluZyBwcm9ibGVtIHdpdGggZW52aXJvbm1lbnRhbCBjb25maWd1cmF0aW9u IGl0c2VsZj8gRGlkCj4gPj4geW91IHRyeSBvdGhlciBXaS1GaSBkZXZpY2UgKGUuZy4gYXRoOWsp IGluc3RlYWQgb2YgYXRoMTBrPwo+ID4gWWVzIEkgdGVzdGVkIHdpdGggYXRoOWsgd2lyZWxlc3Mg Y2FyZCwgdGhlIHNhbWUgY29uZmlndXJhdGlvbiB3b3Jrcy4KPiA+Cj4gPiBJIGRpZCBhbiBpbnRl cmVzdGluZyB0ZXN0LiBXaXRoIG9zdGluYXRvIHNvZnR3YXJlIEkgZ2VuZXJhdGUgYW4gSUNNUAo+ IGZyYW1lIHdpdGhvdXQgdmxhbiB0YWcuIEkgY2hhbmdlZCB0aGUgZXRoZXJ0eXBlIGluIHRoZSBm cmFtZS4KPiA+IEkgdHJpZWQgd2l0aCB0aGUgZXRoZXJ0eXBlIDB4ODAwIChJUCksIDB4ODAxLCAw eDg4OTIgKFBST0ZJTkVUKSwgMHg4MTAwCj4gKGRvdDFxKSwgMHgwNjAwLiBBbGwgZnJhbWVzIGFy ZSBzZW50IGV4Y2VwdCB3aGVuIHRoZSBldGhlcnR5cGUgaXMgc2V0IHRvCj4gMHg4MTAwLiBJdCBz ZWVtcyB0aGUgZmlybXdhcmUgZG8gbm90IGFjY2VwdCB0aGUgZXRoZXJ0eXBlIDB4ODEwMC4KPiAK PiBJbnRlcmVzdGluZy4gVGhpcyBtYXkgc3VnZ2VzdCBmaXJtd2FyZSBhY3R1YWxseSBkb2Vzbid0 IGhhbmRsZSBkb3QxcSBWTEFOCj4gdGFnZ2luZyBwcm9wZXJseSBpbiBOV2lmaSBUeCBlbmNhcCBt b2RlLiBDYW4geW91IHRyeSBjaGFuZ2luZyBpdCB0byA4MDIuMwo+IGVuY2FwIGFuZCByZS10ZXN0 LCBwbGVhc2U/Cj4gCj4gLS0tIGEvZHJpdmVycy9uZXQvd2lyZWxlc3MvYXRoL2F0aDEway9tYWMu Ywo+ICsrKyBiL2RyaXZlcnMvbmV0L3dpcmVsZXNzL2F0aC9hdGgxMGsvbWFjLmMKPiBAQCAtMzE3 Miw3ICszMTcyLDcgQEAgYXRoMTBrX3R4X2hfZ2V0X3R4bW9kZShzdHJ1Y3QgYXRoMTBrICphciwg c3RydWN0Cj4gaWVlZTgwMjExX3ZpZiAqdmlmLAo+ICAgICAgICAgaWYgKGllZWU4MDIxMV9pc19k YXRhX3ByZXNlbnQoZmMpICYmIHN0YSAmJiBzdGEtPnRkbHMpCj4gICAgICAgICAgICAgICAgIHJl dHVybiBBVEgxMEtfSFdfVFhSWF9FVEhFUk5FVDsKPiAKPiAtICAgICAgIHJldHVybiBBVEgxMEtf SFdfVFhSWF9OQVRJVkVfV0lGSTsKPiArICAgICAgIHJldHVybiBBVEgxMEtfSFdfVFhSWF9FVEhF Uk5FVDsKPiAgfQo+IAo+IE5vdGU6IFlvdXIgYmFja3BvcnRzIG1heSBub3QgaGF2ZSB0aGUgbmVj ZXNzYXJ5IGNvZGUuLiBJbiB3aGljaCBjYXNlCj4gaXQnbGwgYmUgZGlmZmljdWx0IHRvIGRvIHRo aXMgdGhlIGVhc3kgd2F5LiBJZiB0aGF0J3MgdGhlIGNhc2UgSSBzdWdnZXN0Cj4geW91IGdldCBs YXRlc3QgYmFja3BvcnRzIG9yIGdlbmVyYXRlIHRoZW0geW91cnNlbGYgZnJvbSB0aGUgbGF0ZXN0 Cj4ga3ZhbG8vYXRoIG1hc3Rlci4KSSB3aWxsIHRyeSB0byBjaGFuZ2UgbXkgYmFja3BvcnQuIEJ1 dCBpdCBpcyBub3QgZWFzeSwgYmVjYXVzZSBJIG5lZWQgdG8gdXNlIGEgY3Jvc3MtY29tcGlsZXIu IEZyb20gb3BlbndydCB3ZWJzaXRlIEkgY2FuIGRvd25sb2FkIGEgYmFja3BvcnQgMjAxNS0wNS0w OC4gSSB3aWxsIHRyeSB0byBpbnRlZ3JhdGUgaXQuCgpEbyB5b3Uga25vdyBob3cgSSBjYW4gZ2Vu ZXJhdGUgYSB0YXIgZmlsZSBmb3Igb3BlbndydCBmcm9tIGthbGUgZ2l0IGh1Yj8KQ2VkcmljCgo+ IAo+IAo+IE1pY2hhxYIKPiAtLQo+IFRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5k IHRoZSBsaW5lICJ1bnN1YnNjcmliZSBsaW51eC13aXJlbGVzcyIKPiBpbiB0aGUgYm9keSBvZiBh IG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZyBNb3JlIG1ham9yZG9tbyBpbmZv Cj4gYXQgIGh0dHA6Ly92Z2VyLmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbAoKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmF0aDEwayBtYWlsaW5n IGxpc3QKYXRoMTBrQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9hdGgxMGsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp29.msg.oleane.net ([62.161.4.29]:40899 "EHLO smtp29.msg.oleane.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751542AbbFEKrR convert rfc822-to-8bit (ORCPT ); Fri, 5 Jun 2015 06:47:17 -0400 From: "voncken" To: "'Michal Kazior'" Cc: "'linux-wireless'" , References: <01eb01d09f64$fd522730$f7f67590$@acksys.fr> <01f701d09f71$47ae9910$d70bcb30$@acksys.fr> In-Reply-To: Subject: RE: ATH10K and VLAN : Frame with VLAN tag are not sent Date: Fri, 5 Jun 2015 12:46:11 +0200 Message-ID: <01fb01d09f7c$d6bdfa00$8439ee00$@acksys.fr> (sfid-20150605_124721_057398_36BD862C) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Sender: linux-wireless-owner@vger.kernel.org List-ID: > De : linux-wireless-owner@vger.kernel.org [mailto:linux-wireless- > owner@vger.kernel.org] De la part de Michal Kazior > Envoyé : vendredi 5 juin 2015 11:46 > À : voncken > Cc : linux-wireless; ath10k@lists.infradead.org > Objet : Re: ATH10K and VLAN : Frame with VLAN tag are not sent > > [...] > >> I see no reason why this should fail. The dot1q encapsulation > >> shouldn't influence how firmware behaves.. but maybe I'm wrong. > >> > >> It's still unclear to me what your topology looks like. Perhaps > >> you're having problem with environmental configuration itself? Did > >> you try other Wi-Fi device (e.g. ath9k) instead of ath10k? > > Yes I tested with ath9k wireless card, the same configuration works. > > > > I did an interesting test. With ostinato software I generate an ICMP > frame without vlan tag. I changed the ethertype in the frame. > > I tried with the ethertype 0x800 (IP), 0x801, 0x8892 (PROFINET), 0x8100 > (dot1q), 0x0600. All frames are sent except when the ethertype is set to > 0x8100. It seems the firmware do not accept the ethertype 0x8100. > > Interesting. This may suggest firmware actually doesn't handle dot1q VLAN > tagging properly in NWifi Tx encap mode. Can you try changing it to 802.3 > encap and re-test, please? > > --- a/drivers/net/wireless/ath/ath10k/mac.c > +++ b/drivers/net/wireless/ath/ath10k/mac.c > @@ -3172,7 +3172,7 @@ ath10k_tx_h_get_txmode(struct ath10k *ar, struct > ieee80211_vif *vif, > if (ieee80211_is_data_present(fc) && sta && sta->tdls) > return ATH10K_HW_TXRX_ETHERNET; > > - return ATH10K_HW_TXRX_NATIVE_WIFI; > + return ATH10K_HW_TXRX_ETHERNET; > } > > Note: Your backports may not have the necessary code.. In which case > it'll be difficult to do this the easy way. If that's the case I suggest > you get latest backports or generate them yourself from the latest > kvalo/ath master. I will try to change my backport. But it is not easy, because I need to use a cross-compiler. From openwrt website I can download a backport 2015-05-08. I will try to integrate it. Do you know how I can generate a tar file for openwrt from kale git hub? Cedric > > > Michał > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" > in the body of a message to majordomo@vger.kernel.org More majordomo info > at http://vger.kernel.org/majordomo-info.html