From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Alejandro Vallejo <alejandro.garciavallejo@amd.com>,
xen-devel@lists.xenproject.org
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
"Jan Beulich" <jbeulich@suse.com>,
"Roger Pau Monné" <roger@xenproject.org>,
"Teddy Astie" <teddy.astie@vates.tech>
Subject: Re: [PATCH 2/5] x86/mtrr: Address MISRA C Rules 5.3, 8.3 and 8.4
Date: Wed, 18 Nov 2026 18:46:39 +0000 [thread overview]
Message-ID: <01fbbdff-ae80-4d83-b3ec-1cb290845939@citrix.com> (raw)
In-Reply-To: <20261118171758.1125066-3-alejandro.garciavallejo@amd.com>
On 18/11/2026 5:17 pm, Alejandro Vallejo wrote:
> diff --git a/xen/arch/x86/cpu/mtrr/main.c b/xen/arch/x86/cpu/mtrr/main.c
> index eff0500f0d..e49ac1b508 100644
> --- a/xen/arch/x86/cpu/mtrr/main.c
> +++ b/xen/arch/x86/cpu/mtrr/main.c
> @@ -50,9 +50,9 @@
> #define get_cpu() smp_processor_id()
> #define put_cpu() do {} while(0)
>
> -u32 __read_mostly num_var_ranges = 0;
> +unsigned int __read_mostly num_var_ranges = 0;
As you're editing the line anyway, the = 0 can be dropped. Can be fixed
on commit.
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
next prev parent reply other threads:[~2026-11-18 18:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 17:17 [PATCH 0/5] x86: Add in-scope files under cpu/ to MISRA scans Alejandro Vallejo
2026-11-18 17:17 ` [PATCH 1/5] x86/cpu: Add break to early_cpu_init() switch Alejandro Vallejo
2026-11-18 18:45 ` Andrew Cooper
2026-11-18 17:17 ` [PATCH 2/5] x86/mtrr: Address MISRA C Rules 5.3, 8.3 and 8.4 Alejandro Vallejo
2026-11-18 18:46 ` Andrew Cooper [this message]
2026-11-18 17:17 ` [PATCH 3/5] x86/cpu: Use U suffixes on integer constants Alejandro Vallejo
2026-11-18 18:49 ` Andrew Cooper
2026-11-19 7:51 ` Jan Beulich
2026-11-18 17:17 ` [PATCH 4/5] x86/amd: Make cpu_has_amd_erratum() non-variadic Alejandro Vallejo
2026-11-18 19:06 ` Andrew Cooper
2026-11-19 10:41 ` Alejandro Vallejo
2026-11-18 17:17 ` [PATCH 5/5] eclair/x86: Scan in-scope files inside cpu/ Alejandro Vallejo
2026-11-18 17:32 ` Nicola Vetrini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01fbbdff-ae80-4d83-b3ec-1cb290845939@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=alejandro.garciavallejo@amd.com \
--cc=jbeulich@suse.com \
--cc=roger@xenproject.org \
--cc=teddy.astie@vates.tech \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.