All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Begunkov <asml.silence@gmail.com>
To: Drew DeVault <sir@cmpwn.com>, io-uring@vger.kernel.org
Subject: Re: Polling on an io_uring file descriptor
Date: Fri, 22 Oct 2021 10:49:55 +0100	[thread overview]
Message-ID: <01fd5aeb-68c9-c30d-be9c-b8ce21f2f16b@gmail.com> (raw)
In-Reply-To: <CF5RZ29XMY8T.2FIJ64YU0UFJ7@taiga>

On 10/22/21 08:59, Drew DeVault wrote:
> On Wed Oct 20, 2021 at 2:00 PM CEST, Drew DeVault wrote:
>>> Surely should be updated if not mentioned
>>
>> That, or the constraint removed? The reasoning is a bit obscure and I
>> suspect that this case could be made possible.
> 
> So I dug into this a bit more, and the constraint seems to be to avoid a
> reference loop when CONFIG_UNIX=n. I grepped Google and SourceGraph for
> "CONFIG_UNIX=n" and only found two kernel configs with Unix sockets
> disabled, neither of which had io_uring enabled. Given the rather
> arbitrary restriction on registering io_urings with each other, and the
> apparent absence of a use-case for io_uring without Unix sockets, can we
> just require CONFIG_UNIX for io_uring and remove the limitation?

It's potentially problematic, even now we have a couple of other
spots relying on it. Is there a good reason why it's needed?

-- 
Pavel Begunkov

  reply	other threads:[~2021-10-22  9:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-20  9:21 Polling on an io_uring file descriptor Drew DeVault
2021-10-20 10:02 ` Drew DeVault
2021-10-20 10:15 ` Pavel Begunkov
2021-10-20 11:44   ` Drew DeVault
2021-10-20 11:58     ` Pavel Begunkov
2021-10-20 12:00       ` Drew DeVault
2021-10-22  7:59         ` Drew DeVault
2021-10-22  9:49           ` Pavel Begunkov [this message]
2021-10-22 10:26             ` Drew DeVault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01fd5aeb-68c9-c30d-be9c-b8ce21f2f16b@gmail.com \
    --to=asml.silence@gmail.com \
    --cc=io-uring@vger.kernel.org \
    --cc=sir@cmpwn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.