Re: [JFFS2] GC patch for eCos port

["Mark Hamilton" <mark_lee_hamilton@sbcglobal.net>]

Estelle,
  Sorry for not getting back to you sooner on this. I agree that ideally I
would prefer to see a fix done in the eCos port of JFFS2. I'll try your
suggestion and rerun my tests to make sure that something isn't overlooked.
Hopefully, I can resubmit a patch to the eCos group.
-Mark
----- Original Message ----- 
From: "Estelle HAMMACHE" <estelle.hammache@st.com>
To: "Mark Hamilton" <mhamilton@alliantnetworks.com>;
<linux-mtd@lists.infradead.org>
Sent: Monday, October 11, 2004 4:18 AM
Subject: Re: [JFFS2] GC patch for eCos port


> Estelle Hammache wrote:
> >
> > Hi Mark,
> >
> > isn't it cleaner (for compatibility with Linux) to modify
> > jffs2_gc_fetch_page so that it reads a
> > PAGE_CACHE_SIZE-aligned buffer ?
>
> Ok so this was discussed in the eCos mailing list, but I meant that
> jffs2_gc_fetch_page should call jffs2_read_inode with the reading
> offset set to the page boundary: (offset & ~(PAGE_CACHE_SIZE-1)).
> I believe this is the expected behavior for jffs2_gc_fetch_page.
>
> Estelle
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/