From mboxrd@z Thu Jan  1 00:00:00 1970
From: "chaithrika" <chaithrika@ti.com>
Subject: Re: [PATCH 1/2] ASoC: DaVinci: McASP driver enhacements
Date: Mon, 10 Aug 2009 10:37:58 +0530
Message-ID: <020201ca1978$86fb5a70$94f20f50$@com>
References: <1249654062-23634-1-git-send-email-chaithrika@ti.com>
	<20090808081158.GC4519@sirena.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from comal.ext.ti.com (comal.ext.ti.com [198.47.26.152])
	by alsa0.perex.cz (Postfix) with ESMTP id BBD30103802
	for <alsa-devel@alsa-project.org>;
	Mon, 10 Aug 2009 07:09:28 +0200 (CEST)
In-Reply-To: <20090808081158.GC4519@sirena.org.uk>
Content-Language: en-us
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
To: 'Mark Brown' <broonie@opensource.wolfsonmicro.com>
Cc: khilman@deeprootsystems.com, alsa-devel@alsa-project.org, davinci-linux-open-source@linux.davincidsp.com
List-Id: alsa-devel@alsa-project.org

On Sat, Aug 08, 2009 at 13:41:58, Mark Brown wrote:
> On Fri, Aug 07, 2009 at 10:07:42AM -0400, Chaithrika U S wrote:
> 
> > This patch adds support for FIFO configuration.The platform member has a

> > version field which differentiates the McASP on different SoCs. The
patch 
> > also adds another DAI format to the driver.
> 
> You really should split out the DAI format addition into another patch -
> there's no code overlap between that and the rest of your changes.
OK. I will post a separate patch for this change.

> Aside from the issue Troy raised everything seems fine except for one
OK. I will submit a patch for that issue.

> small issue:
> 
> > +
> > +	/* McASP FIFO related */
> > +	u8	txnumevt;
> > +	u8	rxnumevt;
> 
> These names don't seem particularly obvious.  If they were chosen to
> match the datasheet name then it probably won't be a problem but
> otherwise something more like tx_fifo_depth might be easier for people
> to figure out.
> 
Currently, the names are as per the peripheral datasheet. So, will 
retain the same name.

Regards, 
Chaithrika