From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp-out06.msg.oleane.net ([62.161.7.4]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Z0uxQ-0002Z9-JE for ath10k@lists.infradead.org; Fri, 05 Jun 2015 16:59:02 +0000 Received: from smtp29.msg.oleane.net (smtp29.mail.priv [172.17.20.151]) by smtp-out06.msg.oleane.net with ESMTP id t55ESKwk025958 for ; Fri, 5 Jun 2015 16:28:20 +0200 From: "voncken" References: <01eb01d09f64$fd522730$f7f67590$@acksys.fr> <01f701d09f71$47ae9910$d70bcb30$@acksys.fr> <01fb01d09f7c$d6bdfa00$8439ee00$@acksys.fr> In-Reply-To: Subject: RE: ATH10K and VLAN : Frame with VLAN tag are not sent Date: Fri, 5 Jun 2015 16:07:09 +0200 Message-ID: <020501d09f98$e9853150$bc8f93f0$@acksys.fr> MIME-Version: 1.0 Content-Language: fr List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: 'Michal Kazior' Cc: 'linux-wireless' , ath10k@lists.infradead.org PiA+Pj4gPgo+ID4+PiA+IEkgZGlkIGFuIGludGVyZXN0aW5nIHRlc3QuIFdpdGggb3N0aW5hdG8g c29mdHdhcmUgSSBnZW5lcmF0ZSBhbgo+ID4+PiA+IElDTVAKPiA+Pj4gZnJhbWUgd2l0aG91dCB2 bGFuIHRhZy4gSSBjaGFuZ2VkIHRoZSBldGhlcnR5cGUgaW4gdGhlIGZyYW1lLgo+ID4+PiA+IEkg dHJpZWQgd2l0aCB0aGUgZXRoZXJ0eXBlIDB4ODAwIChJUCksIDB4ODAxLCAweDg4OTIgKFBST0ZJ TkVUKSwKPiA+Pj4gPiAweDgxMDAKPiA+Pj4gKGRvdDFxKSwgMHgwNjAwLiBBbGwgZnJhbWVzIGFy ZSBzZW50IGV4Y2VwdCB3aGVuIHRoZSBldGhlcnR5cGUgaXMKPiA+Pj4gc2V0IHRvIDB4ODEwMC4g SXQgc2VlbXMgdGhlIGZpcm13YXJlIGRvIG5vdCBhY2NlcHQgdGhlIGV0aGVydHlwZQo+IDB4ODEw MC4KPiA+Pj4KPiA+Pj4gSW50ZXJlc3RpbmcuIFRoaXMgbWF5IHN1Z2dlc3QgZmlybXdhcmUgYWN0 dWFsbHkgZG9lc24ndCBoYW5kbGUgZG90MXEKPiA+Pj4gVkxBTiB0YWdnaW5nIHByb3Blcmx5IGlu IE5XaWZpIFR4IGVuY2FwIG1vZGUuIENhbiB5b3UgdHJ5IGNoYW5naW5nCj4gPj4+IGl0IHRvIDgw Mi4zIGVuY2FwIGFuZCByZS10ZXN0LCBwbGVhc2U/Cj4gPj4+Cj4gPj4+IC0tLSBhL2RyaXZlcnMv bmV0L3dpcmVsZXNzL2F0aC9hdGgxMGsvbWFjLmMKPiA+Pj4gKysrIGIvZHJpdmVycy9uZXQvd2ly ZWxlc3MvYXRoL2F0aDEway9tYWMuYwo+ID4+PiBAQCAtMzE3Miw3ICszMTcyLDcgQEAgYXRoMTBr X3R4X2hfZ2V0X3R4bW9kZShzdHJ1Y3QgYXRoMTBrICphciwKPiA+Pj4gc3RydWN0IGllZWU4MDIx MV92aWYgKnZpZiwKPiA+Pj4gICAgICAgICBpZiAoaWVlZTgwMjExX2lzX2RhdGFfcHJlc2VudChm YykgJiYgc3RhICYmIHN0YS0+dGRscykKPiA+Pj4gICAgICAgICAgICAgICAgIHJldHVybiBBVEgx MEtfSFdfVFhSWF9FVEhFUk5FVDsKPiA+Pj4KPiA+Pj4gLSAgICAgICByZXR1cm4gQVRIMTBLX0hX X1RYUlhfTkFUSVZFX1dJRkk7Cj4gPj4+ICsgICAgICAgcmV0dXJuIEFUSDEwS19IV19UWFJYX0VU SEVSTkVUOwo+ID4+PiAgfQo+ID4+Pgo+ID4+PiBOb3RlOiBZb3VyIGJhY2twb3J0cyBtYXkgbm90 IGhhdmUgdGhlIG5lY2Vzc2FyeSBjb2RlLi4gSW4gd2hpY2ggY2FzZQo+ID4+PiBpdCdsbCBiZSBk aWZmaWN1bHQgdG8gZG8gdGhpcyB0aGUgZWFzeSB3YXkuIElmIHRoYXQncyB0aGUgY2FzZSBJCj4g Pj4+IHN1Z2dlc3QgeW91IGdldCBsYXRlc3QgYmFja3BvcnRzIG9yIGdlbmVyYXRlIHRoZW0geW91 cnNlbGYgZnJvbSB0aGUKPiA+Pj4gbGF0ZXN0IGt2YWxvL2F0aCBtYXN0ZXIuCj4gPj4gSSB3aWxs IHRyeSB0byBjaGFuZ2UgbXkgYmFja3BvcnQuIEJ1dCBpdCBpcyBub3QgZWFzeSwgYmVjYXVzZSBJ IG5lZWQKPiB0byB1c2UgYSBjcm9zcy1jb21waWxlci4gRnJvbSBvcGVud3J0IHdlYnNpdGUgSSBj YW4gZG93bmxvYWQgYSBiYWNrcG9ydAo+IDIwMTUtMDUtMDguIEkgd2lsbCB0cnkgdG8gaW50ZWdy YXRlIGl0Lgo+ID4+Cj4gPj4gRG8geW91IGtub3cgaG93IEkgY2FuIGdlbmVyYXRlIGEgdGFyIGZp bGUgZm9yIG9wZW53cnQgZnJvbSBrYWxlIGdpdAo+IGh1Yj8KPiA+Cj4gPiBUaGF0J3Mgbm9uLXRy aXZpYWwgYXMgZmFyIGFzIEkgdW5kZXJzdGFuZC4gWW91IGNvdWxkIHRyeSBnZW5lcmF0aW5nIGEK PiA+IHF1aWx0IHBhdGNoIGluIG9wZW53cnQgdG8gdXBkYXRlIGF0aDEway4gRWl0aGVyIHNvbWUg c29ydCBvZiBtYW51YWwKPiA+IGNoZXJyeS1waWNraW5nIG9mIHRoZSB0eG1vZGUgcGF0Y2ggZm9y IGF0aDEwayBvciBjcmVhdGUgYSBwYXJ0aWFsIGRpZmYKPiA+IChlLmcuIG9ubHkgZHJpdmVycy9u ZXQvd2lyZWxlc3MvYXRoL2F0aDEwaykgYmV0d2VlbiBvcGVud3J0IGJhY2twb3J0cwo+ID4gYW5k IGt2YWxvL2F0aCBnZW5lcmF0ZWQgYmFja3BvcnRzLgo+IAo+IEkndmUgbWFuYWdlZCB0byByZXBy b2R1Y2UgeW91ciBwcm9ibGVtIGluIG15IHNldHVwLgo+IAo+IFdpdGggTldpZmkgVHhlZCBmcmFt ZXMgd2l0aCBkb3QxUSBWTEFOIHRhZ2dpbmcgYXJlbid0IGV2ZW4gc2VudCBPVEEgYW5kCj4gYXJl IHJlcG9ydGVkIGFzIG5vdCBhY2tlZCBieSBmaXJtd2FyZS4KPiAKPiBXaGVuIEkgY2hhbmdlZCB0 aGUgVHggZW5jYXAgbW9kZSB0byA4MDIuMyAoZXRoZXJuZXQpIEkgY2FuIHNlZSBmcmFtZXMgT1RB Cj4gYnV0IHRoZXkgYXJlIGNvcnJ1cHRlZCAzYWRkciBmcmFtZXMgd2l0aCBpbnZhbGlkIFNBL0RB IGFkZHJlc3Nlcy4KPiBJJ20gZ3Vlc3NpbmcgdGhpcyBpcyBiZWNhdXNlIGZpcm13YXJlIGV4cGVj dHMgZXhwbGljaXQKPiBXTUlfUEVFUl9BRERfV0RTX0VOVFJZX0NNRElEIHRvIGJlIGlzc3VlZCB3 aGVuIHRyeWluZyB0b28gdXNlIDgwMi4zIFR4Cj4gZW5jYXAgd2l0aCA0YWRkciBmcmFtZXMuCj4g CgpUaGFua3MgZm9yIHRoZXNlIGluZm9ybWF0aW9ucywgYnV0IHdoZXJlIEkgbmVlZCB0byBzZXQg dGhlIGZsYWcgV01JX1BFRVJfQUREX1dEU19FTlRSWV9DTURJRD8KVGhlIGJhY2twb3J0IDIwMTUt MDUtMDggc2hvdWxkIHN1cHBvcnQgeW91ciBtb2RpZmljYXRpb24uIEknbSB0cnlpbmcgZHUgY29t cGlsZSBpdC4KCj4gCj4gTWljaGHFggoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmF0aDEwayBtYWlsaW5nIGxpc3QKYXRoMTBrQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9hdGgxMGsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp29.msg.oleane.net ([62.161.4.29]:55181 "EHLO smtp29.msg.oleane.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422897AbbFEOIO convert rfc822-to-8bit (ORCPT ); Fri, 5 Jun 2015 10:08:14 -0400 From: "voncken" To: "'Michal Kazior'" Cc: "'linux-wireless'" , References: <01eb01d09f64$fd522730$f7f67590$@acksys.fr> <01f701d09f71$47ae9910$d70bcb30$@acksys.fr> <01fb01d09f7c$d6bdfa00$8439ee00$@acksys.fr> In-Reply-To: Subject: RE: ATH10K and VLAN : Frame with VLAN tag are not sent Date: Fri, 5 Jun 2015 16:07:09 +0200 Message-ID: <020501d09f98$e9853150$bc8f93f0$@acksys.fr> (sfid-20150605_160920_896411_67489C78) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Sender: linux-wireless-owner@vger.kernel.org List-ID: > >>> > > >>> > I did an interesting test. With ostinato software I generate an > >>> > ICMP > >>> frame without vlan tag. I changed the ethertype in the frame. > >>> > I tried with the ethertype 0x800 (IP), 0x801, 0x8892 (PROFINET), > >>> > 0x8100 > >>> (dot1q), 0x0600. All frames are sent except when the ethertype is > >>> set to 0x8100. It seems the firmware do not accept the ethertype > 0x8100. > >>> > >>> Interesting. This may suggest firmware actually doesn't handle dot1q > >>> VLAN tagging properly in NWifi Tx encap mode. Can you try changing > >>> it to 802.3 encap and re-test, please? > >>> > >>> --- a/drivers/net/wireless/ath/ath10k/mac.c > >>> +++ b/drivers/net/wireless/ath/ath10k/mac.c > >>> @@ -3172,7 +3172,7 @@ ath10k_tx_h_get_txmode(struct ath10k *ar, > >>> struct ieee80211_vif *vif, > >>> if (ieee80211_is_data_present(fc) && sta && sta->tdls) > >>> return ATH10K_HW_TXRX_ETHERNET; > >>> > >>> - return ATH10K_HW_TXRX_NATIVE_WIFI; > >>> + return ATH10K_HW_TXRX_ETHERNET; > >>> } > >>> > >>> Note: Your backports may not have the necessary code.. In which case > >>> it'll be difficult to do this the easy way. If that's the case I > >>> suggest you get latest backports or generate them yourself from the > >>> latest kvalo/ath master. > >> I will try to change my backport. But it is not easy, because I need > to use a cross-compiler. From openwrt website I can download a backport > 2015-05-08. I will try to integrate it. > >> > >> Do you know how I can generate a tar file for openwrt from kale git > hub? > > > > That's non-trivial as far as I understand. You could try generating a > > quilt patch in openwrt to update ath10k. Either some sort of manual > > cherry-picking of the txmode patch for ath10k or create a partial diff > > (e.g. only drivers/net/wireless/ath/ath10k) between openwrt backports > > and kvalo/ath generated backports. > > I've managed to reproduce your problem in my setup. > > With NWifi Txed frames with dot1Q VLAN tagging aren't even sent OTA and > are reported as not acked by firmware. > > When I changed the Tx encap mode to 802.3 (ethernet) I can see frames OTA > but they are corrupted 3addr frames with invalid SA/DA addresses. > I'm guessing this is because firmware expects explicit > WMI_PEER_ADD_WDS_ENTRY_CMDID to be issued when trying too use 802.3 Tx > encap with 4addr frames. > Thanks for these informations, but where I need to set the flag WMI_PEER_ADD_WDS_ENTRY_CMDID? The backport 2015-05-08 should support your modification. I'm trying du compile it. > > Michał