All of lore.kernel.org
 help / color / mirror / Atom feed
From: <markus.stockhausen@gmx.de>
To: "'Chris Packham'" <Chris.Packham@alliedtelesis.co.nz>,
	"'Rustam Adilov'" <adilov@disroot.org>,
	"'Daniel Lezcano'" <daniel.lezcano@kernel.org>,
	"'Thomas Gleixner'" <tglx@kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: AW: [PATCH] clocksource: rtl-otto: Change driver to use __raw reads and writes
Date: Thu, 14 May 2026 22:50:24 +0200	[thread overview]
Message-ID: <021301dce3e3$4a530b70$def92250$@gmx.de> (raw)
In-Reply-To: <c62aed0f-0eff-4c18-93ac-14a1013bf69d@alliedtelesis.co.nz>

> Von: Chris Packham <Chris.Packham@alliedtelesis.co.nz> 
> Gesendet: Mittwoch, 13. Mai 2026 23:05
> Betreff: Re: [PATCH] clocksource: rtl-otto: Change driver to use __raw reads and writes
> ...
>> Fix this by replacing all instances of ioread32 and iowrite32 with
>> __raw_readl and __raw_writel variants. Since they essentially do
>> the same register access, this shouldn't affect anything on other
>> machines.
>>
>> Signed-off-by: Rustam Adilov <adilov@disroot.org>

IIRC the current functions use memory barriers while the
new ones do not. Timers are critical and cost me a lot
of time in the past [1]. We nearly lost support for several
devices last year. So I like to have at least some stability 
confirmation from downstream.

Markus

[1] https://lkml.org/lkml/2025/8/4/240



  reply	other threads:[~2026-05-14 20:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11 13:15 [PATCH] clocksource: rtl-otto: Change driver to use __raw reads and writes Rustam Adilov
2026-05-13 18:31 ` Rustam Adilov
2026-05-13 21:05   ` Chris Packham
2026-05-14 20:50     ` markus.stockhausen [this message]
2026-05-15 14:32       ` AW: " Rustam Adilov
2026-05-15 17:18         ` AW: " markus.stockhausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='021301dce3e3$4a530b70$def92250$@gmx.de' \
    --to=markus.stockhausen@gmx.de \
    --cc=Chris.Packham@alliedtelesis.co.nz \
    --cc=adilov@disroot.org \
    --cc=daniel.lezcano@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.