From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chao Yu Subject: Re: [PATCH 9/9] f2fs: update extent tree in batches Date: Fri, 21 Aug 2015 20:54:44 +0800 Message-ID: <021801d0dc10$a4d36810$ee7a3830$@samsung.com> References: <017d01d0da71$5780e8d0$0682ba70$@samsung.com> <20150820174738.GD42028@jaegeuk-mac02.mot-mobility.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1ZSlr7-0007QL-FG for linux-f2fs-devel@lists.sourceforge.net; Fri, 21 Aug 2015 12:55:37 +0000 Received: from mailout4.samsung.com ([203.254.224.34]) by sog-mx-1.v43.ch3.sourceforge.com with esmtps (TLSv1:AES128-SHA:128) (Exim 4.76) id 1ZSlr5-0006UJ-GK for linux-f2fs-devel@lists.sourceforge.net; Fri, 21 Aug 2015 12:55:37 +0000 Received: from epcpsbgm2new.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout4.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NTF029INNWFX1C0@mailout4.samsung.com> for linux-f2fs-devel@lists.sourceforge.net; Fri, 21 Aug 2015 21:55:27 +0900 (KST) In-reply-to: <20150820174738.GD42028@jaegeuk-mac02.mot-mobility.com> Content-language: zh-cn List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: 'Jaegeuk Kim' Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Hi Jaegeuk, > -----Original Message----- > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org] > Sent: Friday, August 21, 2015 1:48 AM > To: Chao Yu > Cc: linux-f2fs-devel@lists.sourceforge.net; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 9/9] f2fs: update extent tree in batches > > Hi Chao, > > On Wed, Aug 19, 2015 at 07:21:48PM +0800, Chao Yu wrote: > > This patch introduce a new helper f2fs_update_extent_tree_range > > which can update extent nodes in extent tree in batches. > > > > Now, we use the function to invalidate blocks in batches instead of > > invalidating them one by one when truncating blocks. > > IMO, it's not clear the benefit of this patch in terms of performance and code > readability versus risky code changes. This is only used in truncate path, IMO, in theory, we can gain benefit from this batch mode operation when truncating frequently. I will test the patch for numbers. Thanks, ------------------------------------------------------------------------------ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752624AbbHUMzb (ORCPT ); Fri, 21 Aug 2015 08:55:31 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:58293 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751126AbbHUMza (ORCPT ); Fri, 21 Aug 2015 08:55:30 -0400 X-AuditID: cbfee61b-f79706d000001b96-5f-55d71fbffb18 From: Chao Yu To: "'Jaegeuk Kim'" Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <017d01d0da71$5780e8d0$0682ba70$@samsung.com> <20150820174738.GD42028@jaegeuk-mac02.mot-mobility.com> In-reply-to: <20150820174738.GD42028@jaegeuk-mac02.mot-mobility.com> Subject: RE: [PATCH 9/9] f2fs: update extent tree in batches Date: Fri, 21 Aug 2015 20:54:44 +0800 Message-id: <021801d0dc10$a4d36810$ee7a3830$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AQLNlFL34fZWxqU7h2EUoA+g4rYsxAEyoVBOnBNijKA= Content-language: zh-cn X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrMLMWRmVeSWpSXmKPExsVy+t9jQd398tdDDVpea1g8WT+L2eLSIneL y7vmsDkwe2xa1cnmsXvBZyaPz5vkApijuGxSUnMyy1KL9O0SuDI67t1mK9jOXrH/3EXmBsaf rF2MnBwSAiYSLzqPM0HYYhIX7q1n62Lk4hASmMUoseTiNUYI5xWjxJsX18A62ARUJJZ3/Afr EBFQk+jdNwXMZhbwkGjs+A5WIyRQLNH0eyU7iM0p4CIxecFKoEEcHMICNhILt4GFWQRUJY7u 6mIGsXkFLCV27vgNZQtK/Jh8jwVipJbE+p3HocbLS2xe85YZ4lAFiR1nXzNCnGAlsXXrVWaI GnGJjUdusUxgFJqFZNQsJKNmIRk1C0nLAkaWVYwSqQXJBcVJ6blGeanlesWJucWleel6yfm5 mxjBQf9Megfj4V3uhxgFOBiVeHhnRF4LFWJNLCuuzD3EKMHBrCTCu1P2eqgQb0piZVVqUX58 UWlOavEhRmkOFiVxXn2TTaFCAumJJanZqakFqUUwWSYOTqkGRsX6r/5mZxo4BGyK11240Ogb l+XEKRH6Uf5AAuuSFI32NflWRpOXbFip0Lr0V5KN1Cf37z5Cabdv/xASuvn+Ua9wTheD9sXu jpldegxn675pNL+dOYFXYdnGnlvs9+Z9ldot9eZ91cHZJn4KplFihm/nLPxtOeOPwBLVK/Wb ndqsMuMqvTarK7EUZyQaajEXFScCAPLxXTR2AgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jaegeuk, > -----Original Message----- > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org] > Sent: Friday, August 21, 2015 1:48 AM > To: Chao Yu > Cc: linux-f2fs-devel@lists.sourceforge.net; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 9/9] f2fs: update extent tree in batches > > Hi Chao, > > On Wed, Aug 19, 2015 at 07:21:48PM +0800, Chao Yu wrote: > > This patch introduce a new helper f2fs_update_extent_tree_range > > which can update extent nodes in extent tree in batches. > > > > Now, we use the function to invalidate blocks in batches instead of > > invalidating them one by one when truncating blocks. > > IMO, it's not clear the benefit of this patch in terms of performance and code > readability versus risky code changes. This is only used in truncate path, IMO, in theory, we can gain benefit from this batch mode operation when truncating frequently. I will test the patch for numbers. Thanks,