All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Frank Filz" <ffilzlnx@mindspring.com>
To: "'J. Bruce Fields'" <bfields@redhat.com>,
	"'Lu Xinyu'" <luxy.fnst@cn.fujitsu.com>
Cc: <linux-nfs@vger.kernel.org>
Subject: RE: Questions about pynfs:testLargeData-WRT5
Date: Fri, 9 Feb 2018 09:53:09 -0800	[thread overview]
Message-ID: <021c01d3a1ce$d9919cd0$8cb4d670$@mindspring.com> (raw)
In-Reply-To: <20180209144942.GB30030@parsley.fieldses.org>

> On Fri, Feb 09, 2018 at 09:27:00AM +0800, Lu Xinyu wrote:
> > I ran pynfs on the RHEL7.4GA with different
> > kernels(3.10.0-830.el7,4.15). The testLargeData:WRT5 failed with
> > broken pipe. I investigated pynfs code and got the following
> > questions.
> >
> > 1.The intent of WRT5 To check whether the server could handle a
> > too-large value over NFSSVC_MAXBLKSIZE.
> >
> > 2.The expected procedure when test gets passed The server could write
> > down the oversize data successfully sent by client and return NFS4_OK.
> > Then, client could read back the data from server.
> 
> Yes, that test is definitely wrong.  It might happen to work on servers
that
> support larger IO size, but the Linux server doesn't.  And, anyway, it's
perfectly
> legal for a server to only support lower read/write size.

The test does happen to pass on Ganesha.

> So, the test needs check the server's advertised maximum read and write
sizes,
> and then either:
> 
> 	1) use that maximum size, and expect success, or
> 	2) use a larger size and expect some sort of error.
> 
> > (Actually, the test failed with broken pipe and did not return packet
> > information.)
> >
> > 3.The nfs server's standrd procedure of handling oversize data It
> > seems that the related error is not defined in the RFC3530. Whether
> > the server should return any NFSERR before ceasing receving ?
> 
> I'm not sure if the RFC's specify the behavior here.  I'll go do some
research.  I
> have a feeling they don't.  In that case I think the best option will be
1) above.

That's probably the right thing to do.

Frank


---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus


      parent reply	other threads:[~2018-02-09 20:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-09  1:27 Questions about pynfs:testLargeData-WRT5 Lu Xinyu
2018-02-09 14:49 ` J. Bruce Fields
2018-02-09 15:04   ` Trond Myklebust
2018-02-09 18:31     ` J. Bruce Fields
     [not found]       ` <6c3159af-17c5-5556-d416-574968bb5e14@cn.fujitsu.com>
2018-02-13  3:19         ` Seiichi Ikarashi
2018-02-13 16:15           ` J. Bruce Fields
2018-02-14 15:49             ` J. Bruce Fields
2018-02-14 16:20               ` Daniel Gryniewicz
2018-02-15  2:08               ` Seiichi Ikarashi
2018-02-15 16:03                 ` J. Bruce Fields
2018-02-09 17:53   ` Frank Filz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='021c01d3a1ce$d9919cd0$8cb4d670$@mindspring.com' \
    --to=ffilzlnx@mindspring.com \
    --cc=bfields@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=luxy.fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.