All of lore.kernel.org
 help / color / mirror / Atom feed
From: Herve Jourdain <herve.jourdain@neuf.fr>
To: "'Andreas Müller'" <schnitzeltony@googlemail.com>
Cc: 'Yocto Project' <yocto@yoctoproject.org>
Subject: Re: [meta-raspberrypi][PATCH] Add networkd as default for RaspberryPi
Date: Fri, 24 Jul 2015 00:50:14 +0200	[thread overview]
Message-ID: <021f01d0c599$f338f9d0$d9aaed70$@neuf.fr> (raw)
In-Reply-To: <CALbNGRRgRKX0Rh08gWPJ496oc9AY9e5XEJ6foN9m6fKcrpUgGw@mail.gmail.com>

Indeed, it's a valid point, and I should probably be more cautious in the naming of the bbappend.
This said, I - maybe wrongfully - assumed that anyone including the meta-raspberrypi layer would actually want to run on a raspberrypi, which does have an Ethernet interface I believe on all machines - I only have a RaspberryPi 2, so I didn't check all other devices, so might assumption might be wrong there.
Is there any version of raspberrypi without an Ethernet interface?

BR,

Herve

-----Original Message-----
From: Andreas Müller [mailto:schnitzeltony@googlemail.com] 
Sent: jeudi 23 juillet 2015 18:39
To: Herve Jourdain
Cc: Andrei Gherzan; Petter Mabäcker; Yocto Project
Subject: Re: [yocto] [meta-raspberrypi][PATCH] Add networkd as default for RaspberryPi

On Thu, Jul 23, 2015 at 5:32 PM, Herve Jourdain <herve.jourdain@neuf.fr> wrote:
> This patch adds systemd-networkd for RaspberryPi in the 
> meta-raspberrypi layer, in order to have Ethernet and Networking work out of the box.
>
>
>
> This said, I’m not 100% sure if it should be enabled in 
> meta-raspberrypi, instead of another custom layer.
>
> But something similar needs to be added somewhere, and with the 
> current version of Yocto on RaspberryPi, without this patch, network 
> just doesn’t start…
>
>
>
> Signed-off-by: Herve Jourdain <herve.jourdain@neuf.fr>
>
> ---
>
> diff -Naur 
> meta-raspberrypi.orig/recipes-core/systemd/files/eth.network
> meta-raspberrypi/recipes-core/systemd/files/eth.network
>
> --- meta-raspberrypi.orig/recipes-core/systemd/files/eth.network
> 1970-01-01 08:00:00.000000000 +0800
>
> +++ meta-raspberrypi/recipes-core/systemd/files/eth.network    2015-07-22
> 12:01:53.587830690 +0800
>
> @@ -0,0 +1,6 @@
>
> +[Match]
>
> +Name=eth*
>
> +
>
> +[Network]
>
> +DHCP=v4
>
> +
>
> diff -Naur 
> meta-raspberrypi.orig/recipes-core/systemd/systemd_%.bbappend
> meta-raspberrypi/recipes-core/systemd/systemd_%.bbappend
>
> --- meta-raspberrypi.orig/recipes-core/systemd/systemd_%.bbappend
> 1970-01-01 08:00:00.000000000 +0800
>
> +++ meta-raspberrypi/recipes-core/systemd/systemd_%.bbappend
> 2015-07-22 12:05:07.307838546 +0800
>
> @@ -0,0 +1,17 @@
>
> +FILESEXTRAPATHS_prepend := "${THISDIR}/files:"
>
> +
>
> +EXTRA_OECONF += "--disable-ldconfig"
>
> +
>
> +PACKAGECONFIG += "networkd resolved"
>
> +
>
> +CFLAGS_append_arm = " -fno-lto"
>
> +
>
> +SRC_URI += "file://eth.network"
>
> +
>
> +FILES_${PN} += "{sysconfdir}/systemd/network/*"
>
> +
>
> +do_install_append() {
>
> +    install -d ${D}${sysconfdir}/systemd/network/
>
> +    install -m 0644 ${WORKDIR}/*.network 
> + ${D}${sysconfdir}/systemd/network/
>
> +}
>
> +
Please don't modify these kind of settings in a BSP. Even worse by doing it as suggested all machines will get this modification. This for sake that you have no network. Why not add networkmanager or whatever and being fine?

Andreas



  reply	other threads:[~2015-07-23 22:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-23 15:32 [meta-raspberrypi][PATCH] Add networkd as default for RaspberryPi Herve Jourdain
2015-07-23 16:00 ` Mauro Carvalho Chehab
2015-07-23 16:25   ` Herve Jourdain
2015-07-23 18:28     ` Mauro Carvalho Chehab
2015-07-23 22:45       ` Herve Jourdain
2015-07-23 22:52         ` Burton, Ross
2015-07-23 23:06           ` Herve Jourdain
2015-07-29  9:58             ` Burton, Ross
2015-07-23 16:38 ` Andreas Müller
2015-07-23 22:50   ` Herve Jourdain [this message]
2015-07-23 22:53     ` Burton, Ross
2015-07-23 22:59       ` Herve Jourdain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='021f01d0c599$f338f9d0$d9aaed70$@neuf.fr' \
    --to=herve.jourdain@neuf.fr \
    --cc=schnitzeltony@googlemail.com \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.