From: swise@opengridcomputing.com (Steve Wise)
Subject: crash when connecting to targets using nr_io_queues < num cpus
Date: Thu, 22 Sep 2016 19:01:05 -0500 [thread overview]
Message-ID: <022301d2152d$94c202e0$be4608a0$@opengridcomputing.com> (raw)
In-Reply-To: <024201d2151d$28013b90$7803b2b0$@opengridcomputing.com>
> > On Thu, Sep 22, 2016@04:38:48PM -0500, Steve Wise wrote:
> > > > Steve,
> > > >
> > > > can you test if the patch below properly fails the connect and
> avoids
> > > > the crash?
> > > >
> > >
> > > Is this the expected error?
> >
> > Yes.
> >
>
> Ok then. Tested-by: Steve Wise <swise at opengridcomputing.com>
>
> I haven't tried ignoring this error when connecting yet...
>
> Stevo
This patch seems to work:
@@ -639,6 +639,8 @@ static int nvme_rdma_connect_io_queues(struct
nvme_rdma_ctrl *ctrl)
for (i = 1; i < ctrl->queue_count; i++) {
ret = nvmf_connect_io_queue(&ctrl->ctrl, i);
+ if (ret == -EXDEV)
+ ret = 0;
if (ret)
break;
}
The fabrics module displays these errors. But the 28 rdma connections still
get setup. I'm not sure this is what we want, but it does avoid failing the
connect altogether...
[ 9438.483765] nvme nvme1: creating 28 I/O queues.
[ 9438.619877] nvme nvme1: Connect command failed, error wo/DNR bit: -16402
[ 9438.632542] nvme nvme1: Connect command failed, error wo/DNR bit: -16402
[ 9438.644857] nvme nvme1: Connect command failed, error wo/DNR bit: -16402
[ 9438.662090] nvme nvme1: Connect command failed, error wo/DNR bit: -16402
[ 9438.667138] nvme nvme1: Connect command failed, error wo/DNR bit: -16402
[ 9438.671875] nvme nvme1: Connect command failed, error wo/DNR bit: -16402
[ 9438.681345] nvme nvme1: Connect command failed, error wo/DNR bit: -16402
[ 9438.690364] nvme nvme1: Connect command failed, error wo/DNR bit: -16402
[ 9438.697611] nvme nvme1: Connect command failed, error wo/DNR bit: -16402
[ 9438.712055] nvme nvme1: Connect command failed, error wo/DNR bit: -16402
[ 9438.719229] nvme nvme1: Connect command failed, error wo/DNR bit: -16402
[ 9438.726399] nvme nvme1: Connect command failed, error wo/DNR bit: -16402
[ 9438.726406] nvme nvme1: new ctrl: NQN "test-ram0", addr 10.0.1.14:4420
next prev parent reply other threads:[~2016-09-23 0:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 20:12 crash when connecting to targets using nr_io_queues < num cpus Steve Wise
2016-09-01 9:32 ` Sagi Grimberg
2016-09-01 14:10 ` Steve Wise
2016-09-01 19:01 ` Steve Wise
2016-09-04 8:46 ` Sagi Grimberg
2016-09-13 14:21 ` Steve Wise
2016-09-13 17:14 ` Ming Lin
2016-09-13 17:52 ` Keith Busch
2016-09-13 19:43 ` Steve Wise
2016-09-16 14:10 ` Steve Wise
2016-09-16 14:26 ` 'Christoph Hellwig'
2016-09-22 21:02 ` 'Christoph Hellwig'
2016-09-22 21:38 ` Steve Wise
2016-09-22 21:48 ` 'Christoph Hellwig'
2016-09-22 22:03 ` Steve Wise
[not found] ` <024201d2151d$28013b90$7803b2b0$@opengridcomputing.com>
2016-09-23 0:01 ` Steve Wise [this message]
2016-09-23 3:31 ` 'Christoph Hellwig'
2016-09-23 13:58 ` Steve Wise
2016-09-23 16:21 ` Jens Axboe
2016-09-23 16:23 ` 'Christoph Hellwig'
2016-09-23 16:24 ` Jens Axboe
2016-09-23 16:26 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='022301d2152d$94c202e0$be4608a0$@opengridcomputing.com' \
--to=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.