From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a05:6512:204:0:0:0:0 with SMTP id a4csp2898954lfo; Tue, 15 Mar 2022 07:07:56 -0700 (PDT) X-Received: by 2002:a17:90b:228a:b0:1bc:7ca4:efaf with SMTP id kx10-20020a17090b228a00b001bc7ca4efafmr4807959pjb.245.1647353276302; Tue, 15 Mar 2022 07:07:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647353276; cv=none; d=google.com; s=arc-20160816; b=tZv9FisdT4u3Ebcd3MNUzl8qDgHA2aXOrw5aKEh7jd4FNa5xgQsfox93urFAhepAwX LJB/xuv+tRGRj5iKA6cWPhqmS5gUKcFVyNcHwfy2CagJ9ME1w6Sdj0ruQR6hhOp20vOI +eaYVwG1/G0qDAdaOb6MUkFhAdH+TsGk2QMgJHcW5rMA7w9C0p2pOkaIohkHu44rEQpd NWhjSdw+qkMTZ3DDz+l5bOD6TXC0E8gOGS1Un3Z/qJcGFzmMlY8xaNlQg15FInnZKBt7 kyKHFHnj7419O+MoQ1LvEgMYK77UF2derw3f2wrSGc70SHwdcXvNVbTimQZX1w99Kd/x 33uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :dkim-signature; bh=n5RJV7EKOnS1kazx80dECSrxKL3JUdNPyUQ+rH9sbVY=; b=SGoOzPO57UmGl0bP8u+jCFQ+Is+tmOBV+0xVnW5M6Vz2RwPXgVrcJHUCQG1AiTJJfy WVQTMcypYqGiyhowX7UM+Xuwjw5NgIFAjYGhIGf4J4qrfSBZmPI4f/7Aet/MkaSPCHjm jG3FC1RsZfQ4BOhDu+zHogH3XwnDVWik5iVSrvxJJ9HzpcOg7DOUZ+x+AshwDc3SrzxW z+LrbAKt2PpyKmFZXlKq5Z+3ZyrLTCAFihTVyMz7Qe+l8fnO4dJ+p9MwPo0uWu2Vefgo qXf5VUNBQfsMkdd93T7qoUPD+lL/dJFXKAJtemUE97z4cu7m9K2GO7CfeGm7LMdMTXBc BHLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=HJForaCG; spf=pass (google.com: domain of philippe.mathieu.daude@gmail.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id q5-20020a170902eb8500b0014fe92899fdsor6725995plg.173.2022.03.15.07.07.56 (Google Transport Security); Tue, 15 Mar 2022 07:07:56 -0700 (PDT) Received-SPF: pass (google.com: domain of philippe.mathieu.daude@gmail.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=HJForaCG; spf=pass (google.com: domain of philippe.mathieu.daude@gmail.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=n5RJV7EKOnS1kazx80dECSrxKL3JUdNPyUQ+rH9sbVY=; b=HJForaCGjZ8+I/OPktEd9hFdMN585TTk+jl0Z7jRfAN/CjsP95sSEv7t3CUHUya9Fq cmUxhqCxwnY8Jq9ZkM9jf+mTNdryW8tioEHIGLTnxomd2LGvSvmFeOEFu1+TJUQv/gsA YaORRHawDzG1lXX9EHWybS1bRAYDLNtJF2kJHqL54XciTXijv6ZA3GOWFkvtFiHLZ+SA 4kf26f+rEExuA6NlZ1qB3stka8I1CYBJz/5JQegh/lDX4u2BnNEce4wHmJ5LrJiopGsP QZQsfwz8N7g6wzUwgwsojTXJm7WfA39eegwwQBtQsfwcFCsGITjD3GnOhrtFtvdHKflj KUvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=n5RJV7EKOnS1kazx80dECSrxKL3JUdNPyUQ+rH9sbVY=; b=jpsl1W5QGkrLp/r4vSdNRW84ATAieW5SJRQ7DkanVFdquY2OctvbBO4H1ztoTmeXyy PzzqeGhnUfS02F0tLKh/E12FsQ3+Y3IgUAGckxbmw/NmS6iTVeHd/1yfBQwExruXQU8Z gA9MEV/8uc1jwbkCzeg5xvH5SNMbrE+iRaJQ4OUyf2V9IDzZrYp++Zq5un62LMHkS5H8 46LC+okW8mu44glySW8LP1H89VYquwiBSCDUdQBePpaq0HDms35MsXN+Sob5McPANNhm nI6mYHngLLQgP69eCYQ2pLX9bhU2tkE502yGYpmVhcSp+A0oxD7X0tHNFrFIA1+yYgBK snmw== X-Gm-Message-State: AOAM531pqbJyHTCf64IhbW85GB4syplJYCbZdpX3+mI5ZMpl7wznuGX7 ZK0seHcB+9ymCs7ouyIiYII= X-Google-Smtp-Source: ABdhPJzx03KXda7KzQgJ08jUr9c6CHZ/lPdQQFMd5dF0oFpdZHS7Vx/Bjs3VhxRjXoejIy7drn4agA== X-Received: by 2002:a17:902:9b97:b0:153:85ac:abc0 with SMTP id y23-20020a1709029b9700b0015385acabc0mr7132480plp.100.1647353275700; Tue, 15 Mar 2022 07:07:55 -0700 (PDT) Return-Path: Received: from [192.168.1.115] ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id m125-20020a628c83000000b004f7baad5c20sm10671055pfd.144.2022.03.15.07.07.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Mar 2022 07:07:55 -0700 (PDT) Message-ID: <02307072-4bff-dbbb-67fb-ca9800c34b3c@gmail.com> Date: Tue, 15 Mar 2022 15:07:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 3/3] Use g_new() & friends where that makes obvious sense Content-Language: en-US To: Markus Armbruster , =?UTF-8?Q?Alex_Benn=c3=a9e?= Cc: qemu-devel@nongnu.org, Paolo Bonzini , Richard Henderson , Gerd Hoffmann , Christian Schoenebeck , "Gonglei (Arei)" , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , "Michael S. Tsirkin" , Igor Mammedov , Ani Sinha , Laurent Vivier , Amit Shah , Peter Maydell , Stefano Stabellini , Anthony Perard , Paul Durrant , =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Aleksandar Rikalo , Corey Minyard , Patrick Venture , Eduardo Habkost , Marcel Apfelbaum , Peter Xu , Jason Wang , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Daniel Henrique Barboza , David Gibson , Greg Kurz , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Jean-Christophe Dubois , Keith Busch , Klaus Jensen , Yuval Shaia , Yoshinori Sato , Magnus Damm , Fabien Chouteau , KONRAD Frederic , Mark Cave-Ayland , Artyom Tarasenko , Alex Williamson , Eric Auger , Max Filippov , Juan Quintela , "Dr. David Alan Gilbert" , Konstantin Kostiuk , Michael Roth , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Pavel Dovgalyuk , David Hildenbrand , Wenchao Wang , Colin Xu , Kamil Rytarowski , Reinoud Zandijk , Sunil Muthuswamy , Cornelia Huck , Thomas Huth , Eric Blake , Vladimir Sementsov-Ogievskiy , John Snow , kvm@vger.kernel.org, qemu-arm@nongnu.org, xen-devel@lists.xenproject.org, qemu-ppc@nongnu.org, qemu-block@nongnu.org, haxm-team@intel.com, qemu-s390x@nongnu.org References: <20220314160108.1440470-1-armbru@redhat.com> <20220314160108.1440470-4-armbru@redhat.com> <87y21c401e.fsf@linaro.org> <875yofl3k3.fsf@pond.sub.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <875yofl3k3.fsf@pond.sub.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TUID: v9W0ieFSB0Mi On 15/3/22 14:59, Markus Armbruster wrote: > Alex Bennée writes: > >> Markus Armbruster writes: >> >>> g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer, >>> for two reasons. One, it catches multiplication overflowing size_t. >>> Two, it returns T * rather than void *, which lets the compiler catch >>> more type errors. >>> >> >>> diff --git a/semihosting/config.c b/semihosting/config.c >>> index 137171b717..6d48ec9566 100644 >>> --- a/semihosting/config.c >>> +++ b/semihosting/config.c >>> @@ -98,7 +98,7 @@ static int add_semihosting_arg(void *opaque, >>> if (strcmp(name, "arg") == 0) { >>> s->argc++; >>> /* one extra element as g_strjoinv() expects NULL-terminated array */ >>> - s->argv = g_realloc(s->argv, (s->argc + 1) * sizeof(void *)); >>> + s->argv = g_renew(void *, s->argv, s->argc + 1); >> >> This did indeed break CI because s->argv is an array of *char: >> >> ../semihosting/config.c:101:17: error: assignment to ‘const char **’ from incompatible pointer type ‘void **’ [-Werror=incompatible-pointer-types] >> 101 | s->argv = g_renew(void *, s->argv, s->argc + 1); >> | ^ >> cc1: all warnings being treated as errors >> >> So it did the job of type checking but failed to build ;-) > > You found a hole in my compile testing, thanks! > > I got confused about the configuration of my build trees. Catching such > mistakes is what CI is for :) FYI Alex fixed this here: https://lore.kernel.org/qemu-devel/20220315121251.2280317-8-alex.bennee@linaro.org/ So your series could go on top (modulo the Coverity change). From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD8DDC433F5 for ; Tue, 15 Mar 2022 14:09:40 +0000 (UTC) Received: from localhost ([::1]:57350 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nU7rn-0001Fj-W8 for qemu-devel@archiver.kernel.org; Tue, 15 Mar 2022 10:09:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49930) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nU7qF-000851-Gm; Tue, 15 Mar 2022 10:08:03 -0400 Received: from [2607:f8b0:4864:20::102c] (port=43579 helo=mail-pj1-x102c.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nU7qA-0004HP-O1; Tue, 15 Mar 2022 10:08:03 -0400 Received: by mail-pj1-x102c.google.com with SMTP id z12-20020a17090ad78c00b001bf022b69d6so2518327pju.2; Tue, 15 Mar 2022 07:07:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=n5RJV7EKOnS1kazx80dECSrxKL3JUdNPyUQ+rH9sbVY=; b=HJForaCGjZ8+I/OPktEd9hFdMN585TTk+jl0Z7jRfAN/CjsP95sSEv7t3CUHUya9Fq cmUxhqCxwnY8Jq9ZkM9jf+mTNdryW8tioEHIGLTnxomd2LGvSvmFeOEFu1+TJUQv/gsA YaORRHawDzG1lXX9EHWybS1bRAYDLNtJF2kJHqL54XciTXijv6ZA3GOWFkvtFiHLZ+SA 4kf26f+rEExuA6NlZ1qB3stka8I1CYBJz/5JQegh/lDX4u2BnNEce4wHmJ5LrJiopGsP QZQsfwz8N7g6wzUwgwsojTXJm7WfA39eegwwQBtQsfwcFCsGITjD3GnOhrtFtvdHKflj KUvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=n5RJV7EKOnS1kazx80dECSrxKL3JUdNPyUQ+rH9sbVY=; b=FqP4nlQr5bRdJPrcjqyQTLiQDopDh1wPSDFC+WrNsJEE5pu9EK8jGLG2dhneO7WIQr fV5I9egx/4kGVRqaQP2O/j7FT59siss/jXScQPWU0/xLf8loJffKdtpJsFhtZyx0mG9f 8choZAU3lYB2OKG1XyFMIxcqMT0DWuoPxuyLmfciQmN2OSFTs+I44Rx49VbbjBq3RjL2 fZ91ncBiDWDJozwqWg+vcp52VGgYWZuXBN+c65tD6NzM+qBd7uhpyWVPff4t7Ds3JJDA jp3x7FbnhVN+ZsxRAwN0+sdR/8vQxzv44kZIj1xE9WbnI/vzM1iTCRN7ow9WZu4SDe28 Qmjg== X-Gm-Message-State: AOAM530zXE0PSLBJKy6rTUjZbnflHzxUJS7TjZCQwrQbCRxf0N/GI5C+ /z9nACkiR6dr7h/3X0zR/2o= X-Google-Smtp-Source: ABdhPJzx03KXda7KzQgJ08jUr9c6CHZ/lPdQQFMd5dF0oFpdZHS7Vx/Bjs3VhxRjXoejIy7drn4agA== X-Received: by 2002:a17:902:9b97:b0:153:85ac:abc0 with SMTP id y23-20020a1709029b9700b0015385acabc0mr7132480plp.100.1647353275700; Tue, 15 Mar 2022 07:07:55 -0700 (PDT) Received: from [192.168.1.115] ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id m125-20020a628c83000000b004f7baad5c20sm10671055pfd.144.2022.03.15.07.07.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Mar 2022 07:07:55 -0700 (PDT) Message-ID: <02307072-4bff-dbbb-67fb-ca9800c34b3c@gmail.com> Date: Tue, 15 Mar 2022 15:07:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 3/3] Use g_new() & friends where that makes obvious sense Content-Language: en-US To: Markus Armbruster , =?UTF-8?Q?Alex_Benn=c3=a9e?= References: <20220314160108.1440470-1-armbru@redhat.com> <20220314160108.1440470-4-armbru@redhat.com> <87y21c401e.fsf@linaro.org> <875yofl3k3.fsf@pond.sub.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <875yofl3k3.fsf@pond.sub.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::102c (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::102c; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-pj1-x102c.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Daniel Henrique Barboza , kvm@vger.kernel.org, "Michael S. Tsirkin" , Jason Wang , Christian Schoenebeck , qemu-devel@nongnu.org, Peter Xu , Klaus Jensen , KONRAD Frederic , Konstantin Kostiuk , Gerd Hoffmann , Ani Sinha , Reinoud Zandijk , Eric Blake , Sunil Muthuswamy , Stefano Stabellini , xen-devel@lists.xenproject.org, Yoshinori Sato , Juan Quintela , Paul Durrant , Magnus Damm , Kamil Rytarowski , "Gonglei \(Arei\)" , =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Michael Roth , Anthony Perard , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Artyom Tarasenko , Laurent Vivier , Aleksandar Rikalo , Amit Shah , Mark Cave-Ayland , haxm-team@intel.com, Richard Henderson , Greg Kurz , Fabien Chouteau , Yuval Shaia , Thomas Huth , Eric Auger , Alex Williamson , qemu-arm@nongnu.org, =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Pavel Dovgalyuk , Paolo Bonzini , Keith Busch , qemu-ppc@nongnu.org, David Hildenbrand , John Snow , David Gibson , Eduardo Habkost , Vladimir Sementsov-Ogievskiy , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , qemu-block@nongnu.org, Max Filippov , qemu-s390x@nongnu.org, Patrick Venture , Cornelia Huck , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Jean-Christophe Dubois , Corey Minyard , Wenchao Wang , Igor Mammedov , "Dr. David Alan Gilbert" , Colin Xu Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 15/3/22 14:59, Markus Armbruster wrote: > Alex Bennée writes: > >> Markus Armbruster writes: >> >>> g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer, >>> for two reasons. One, it catches multiplication overflowing size_t. >>> Two, it returns T * rather than void *, which lets the compiler catch >>> more type errors. >>> >> >>> diff --git a/semihosting/config.c b/semihosting/config.c >>> index 137171b717..6d48ec9566 100644 >>> --- a/semihosting/config.c >>> +++ b/semihosting/config.c >>> @@ -98,7 +98,7 @@ static int add_semihosting_arg(void *opaque, >>> if (strcmp(name, "arg") == 0) { >>> s->argc++; >>> /* one extra element as g_strjoinv() expects NULL-terminated array */ >>> - s->argv = g_realloc(s->argv, (s->argc + 1) * sizeof(void *)); >>> + s->argv = g_renew(void *, s->argv, s->argc + 1); >> >> This did indeed break CI because s->argv is an array of *char: >> >> ../semihosting/config.c:101:17: error: assignment to ‘const char **’ from incompatible pointer type ‘void **’ [-Werror=incompatible-pointer-types] >> 101 | s->argv = g_renew(void *, s->argv, s->argc + 1); >> | ^ >> cc1: all warnings being treated as errors >> >> So it did the job of type checking but failed to build ;-) > > You found a hole in my compile testing, thanks! > > I got confused about the configuration of my build trees. Catching such > mistakes is what CI is for :) FYI Alex fixed this here: https://lore.kernel.org/qemu-devel/20220315121251.2280317-8-alex.bennee@linaro.org/ So your series could go on top (modulo the Coverity change).