From: William Zhang <william.zhang@broadcom.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] drivers: nand: brcmnand: fix nand_chip ecc layout structure
Date: Sun, 20 Oct 2019 16:40:19 -0700 [thread overview]
Message-ID: <023a06f52a999929fc8536025d6bbcdc@mail.gmail.com> (raw)
In-Reply-To: <9160c138-26d1-363d-1fda-db713210411a@gmail.com>
Thank you Daniel!
-----Original Message-----
From: Daniel Schwierzeck [mailto:daniel.schwierzeck at gmail.com]
Sent: Friday, October 18, 2019 4:37 AM
To: William Zhang; philippe.reynes at softathome.com
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH] drivers: nand: brcmnand: fix nand_chip ecc
layout structure
Am 04.09.19 um 19:51 schrieb William Zhang:
> The current brcmnand driver is based on 4.18 linux kernel which uses
> mtd_set_ooblayout to set ecc layout. But nand base code in u-boot is from
> old kernel which does not use this new API and expect nand_chip.ecc.layout
> structure to be set. This cause nand_scan_tail function running into a bug
> check if the device has a different oob size than the default ones.
>
> This patch ports the brcmstb_choose_ecc_layout function from kernel 4.6.7
> that supports the ecc layout struture and replaces the mtd_set_ooblayout
> method
>
> Signed-off-by: William Zhang <william.zhang@broadcom.com>
> ---
> drivers/mtd/nand/raw/brcmnand/brcmnand.c | 260 +++++++++--------------
> 1 file changed, 104 insertions(+), 156 deletions(-)
>
applied to u-boot-mips, thanks.
--
- Daniel
prev parent reply other threads:[~2019-10-20 23:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 17:51 [U-Boot] [PATCH] drivers: nand: brcmnand: fix nand_chip ecc layout structure William Zhang
2019-09-05 12:46 ` Philippe REYNES
2019-10-18 11:36 ` Daniel Schwierzeck
2019-10-20 23:40 ` William Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=023a06f52a999929fc8536025d6bbcdc@mail.gmail.com \
--to=william.zhang@broadcom.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.