From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35303)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <syeon.hwang@samsung.com>) id 1XoRuh-000739-VF
	for qemu-devel@nongnu.org; Wed, 12 Nov 2014 02:00:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <syeon.hwang@samsung.com>) id 1XoRub-0002dx-Vt
	for qemu-devel@nongnu.org; Wed, 12 Nov 2014 02:00:23 -0500
Received: from mailout2.samsung.com ([203.254.224.25]:12257)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <syeon.hwang@samsung.com>) id 1XoRub-0002di-Mx
	for qemu-devel@nongnu.org; Wed, 12 Nov 2014 02:00:17 -0500
Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26])
	by mailout2.samsung.com
	(Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit
	(built Nov
	17 2011)) with ESMTP id <0NEW001GDZGC8Y20@mailout2.samsung.com> for
	qemu-devel@nongnu.org; Wed, 12 Nov 2014 16:00:12 +0900 (KST)
From: SeokYeon Hwang <syeon.hwang@samsung.com>
References: <1415598889-11244-1-git-send-email-syeon.hwang@samsung.com>
	<5460E461.6020509@redhat.com>
In-reply-to: <5460E461.6020509@redhat.com>
Date: Wed, 12 Nov 2014 16:00:11 +0900
Message-id: <024701cffe46$4dcd26d0$e9677470$@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=UTF-8
Content-transfer-encoding: 7bit
Content-language: ko
Subject: Re: [Qemu-devel] [PATCH v3] error: passing a negative value to an
	os_errno is wrong
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: 'Eric Blake' <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: kongjianjun@gmail.com, paolo.bonzini@gmail.com, armbru@redhat.com, mreitz@redhat.com

> -----Original Message-----
> From: Eric Blake [mailto:eblake@redhat.com]
> Sent: Tuesday, November 11, 2014 1:14 AM
> To: SeokYeon Hwang; qemu-devel@nongnu.org
> Cc: paolo.bonzini@gmail.com; armbru@redhat.com; mreitz@redhat.com;
> kongjianjun@gmail.com
> Subject: Re: [PATCH v3] error: passing a negative value to an os_errno is
> wrong
> 
> On 11/09/2014 10:54 PM, SeokYeon Hwang wrote:
> > Added 'assert(os_errno > 0)' in 'error_set_errno()'.
> 
> Commit message...
> 
> > Fixed errno since it passes wrong value to 'error_set_errno()'.
> >
> > Signed-off-by: SeokYeon Hwang <syeon.hwang@samsung.com>
> > ---
> >  hw/pci/pcie.c | 2 +-
> 
> > +++ b/util/error.c
> > @@ -62,6 +62,7 @@ void error_set_errno(Error **errp, int os_errno,
> ErrorClass err_class,
> >          return;
> >      }
> >      assert(*errp == NULL);
> > +    assert(os_errno >= 0);
> 
> ...does not match code. (Code is correct).
> 
> --
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org

You're right. Thank you.