From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36072) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlXuf-000099-7M for qemu-devel@nongnu.org; Tue, 04 Nov 2014 01:48:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XlXuX-0007A7-Ei for qemu-devel@nongnu.org; Tue, 04 Nov 2014 01:48:21 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:44171) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlXuX-00079r-5a for qemu-devel@nongnu.org; Tue, 04 Nov 2014 01:48:13 -0500 Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NEI00CSV5KALF60@mailout2.samsung.com> for qemu-devel@nongnu.org; Tue, 04 Nov 2014 15:48:10 +0900 (KST) From: SeokYeon Hwang References: <1414731433-13257-1-git-send-email-syeon.hwang@samsung.com> <5457AA5B.50100@redhat.com> In-reply-to: <5457AA5B.50100@redhat.com> Date: Tue, 04 Nov 2014 15:48:12 +0900 Message-id: <024e01cff7fb$4db0ad30$e9120790$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit Content-language: ko Subject: Re: [Qemu-devel] [PATCH] smbios: fixed compiler warning on clang > 3.4 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Paolo Bonzini' , qemu-devel@nongnu.org Cc: armbru@redhat.com, alex.williamson@hp.com > -----Original Message----- > From: Paolo Bonzini [mailto:paolo.bonzini@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Tuesday, November 04, 2014 1:16 AM > To: SeokYeon Hwang; qemu-devel@nongnu.org > Cc: armbru@redhat.com; alex.williamson@hp.com > Subject: Re: [PATCH] smbios: fixed compiler warning on clang > 3.4 > > On 31/10/2014 05:57, SeokYeon Hwang wrote: > > Explicit casting to 'ram_addr_t' in order to avoid "-Wconstant- > conversion" on clang 3.4 or later. > > > > Signed-off-by: SeokYeon Hwang > > --- > > hw/i386/smbios.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/hw/i386/smbios.c b/hw/i386/smbios.c index > > e3fa1b2..ace9c44 100644 > > --- a/hw/i386/smbios.c > > +++ b/hw/i386/smbios.c > > @@ -836,7 +836,7 @@ void smbios_get_tables(uint8_t **tables, size_t > *tables_len, > > smbios_build_type_16_table(dimm_cnt); > > > > for (i = 0; i < dimm_cnt; i++) { > > - smbios_build_type_17_table(i, GET_DIMM_SZ); > > + smbios_build_type_17_table(i, (ram_addr_t)GET_DIMM_SZ); > > } > > > > for (i = 0, instance = 0; i < e820_get_num_entries(); i++) { > > > > I'm not sure what the problem is. Can you instead do something like: > > for (i = 0; i < dimm_cnt; i++) { > - smbios_build_type_17_table(i, GET_DIMM_SZ); > + uint64_t sz = (i < dimm_cnt - 1) ? MAX_DIMM_SZ : ram_size % > MAX_DIMM_SZ; > + smbios_build_type_17_table(i, sz); > } > > and change smbios_build_type_17_table to take simply a uint64_t? > Using ram_addr_t is probably wrong. > > Paolo You are right. "smbios_build_type_17_table()" should take uint64_t. I will post patch v2. Thanks.