From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jun Guo <jun.guo@cixtech.com>,
peter.chen@cixtech.com, fugang.duan@cixtech.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, vkoul@kernel.org,
ychuang3@nuvoton.com, schung@nuvoton.com, robin.murphy@arm.com
Cc: dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, cix-kernel-upstream@cixtech.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] dt-bindings: dma: arm-dma350: update DT binding docs
Date: Mon, 17 Nov 2025 08:11:12 +0100 [thread overview]
Message-ID: <024eb64f-74bd-4170-a6c1-09c4af647926@kernel.org> (raw)
In-Reply-To: <aea1429d-b67e-4c42-ad19-88d04f69467b@cixtech.com>
On 17/11/2025 08:07, Jun Guo wrote:
>
> On 11/17/2025 2:11 PM, Krzysztof Kozlowski wrote:
>> On 17/11/2025 02:59, Jun Guo wrote:
>>> - Add new compatible strings to the DT binding documents to support
>> This is not a list.
>>
>> Also, subject is completely redundant. Everything is an update. Why are
>> you repeating DT binding docs?
>>
> Thank you. I will incorporate your feedback in the next version.>> cix
> sky1 SoC.
>>>
>>> Signed-off-by: Jun Guo<jun.guo@cixtech.com>
>>> ---
>> You just broke all existing platforms. Please test your code properly.
> The patch includes proper checks. Since this platform is the first user
Nah, tests are here incomplete - look at the binding and DTS users...
nothing there, so you cannot test it.
> of the driver in the current codebase, the change won't affect other
> platforms.
NAK, and you keep pushing... I just told you it will break everyone,
which is obvious from the diff.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-11-17 7:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 1:59 [PATCH 0/3] dmaengine: arm-dma350: add support for shared interrupt mode Jun Guo
2025-11-17 1:59 ` [PATCH 1/3] dt-bindings: dma: arm-dma350: update DT binding docs Jun Guo
2025-11-17 6:11 ` Krzysztof Kozlowski
2025-11-17 7:07 ` Jun Guo
2025-11-17 7:11 ` Krzysztof Kozlowski [this message]
2025-11-17 7:13 ` Krzysztof Kozlowski
2025-11-17 12:51 ` Jun Guo
2025-11-17 13:29 ` Krzysztof Kozlowski
2025-11-18 1:37 ` Jun Guo
2025-11-17 1:59 ` [PATCH 2/3] dma: arm-dma350: add support for shared interrupt mode Jun Guo
2025-11-17 6:13 ` Krzysztof Kozlowski
2025-11-17 7:18 ` Jun Guo
2025-11-17 11:37 ` Jun Guo
2025-11-17 11:44 ` Krzysztof Kozlowski
2025-11-17 11:52 ` Jun Guo
2025-11-17 11:32 ` Robin Murphy
2025-11-17 11:57 ` Jun Guo
2025-11-17 1:59 ` [PATCH 3/3] arm64: dts: cix: add DT nodes for DMA Jun Guo
2025-11-17 6:14 ` Krzysztof Kozlowski
2025-11-17 7:08 ` Jun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=024eb64f-74bd-4170-a6c1-09c4af647926@kernel.org \
--to=krzk@kernel.org \
--cc=cix-kernel-upstream@cixtech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=fugang.duan@cixtech.com \
--cc=jun.guo@cixtech.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.chen@cixtech.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=schung@nuvoton.com \
--cc=vkoul@kernel.org \
--cc=ychuang3@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.