All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Inbaraj E" <inbaraj.e@samsung.com>
To: "'Krzysztof Kozlowski'" <krzk@kernel.org>
Cc: <rmfrfs@gmail.com>, <laurent.pinchart@ideasonboard.com>,
	<martink@posteo.de>, <kernel@puri.sm>, <mchehab@kernel.org>,
	<robh@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
	<shawnguo@kernel.org>, <s.hauer@pengutronix.de>,
	<kernel@pengutronix.de>, <festevam@gmail.com>,
	<linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<imx@lists.linux.dev>, <linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-samsung-soc@vger.kernel.org>, <pankaj.dubey@samsung.com>,
	<ravi.patel@samsung.com>, <shradha.t@samsung.com>
Subject: RE: [PATCH v3 2/7] dt-bindings: media: fsd: Add CSIS video capture interface
Date: Wed, 17 Sep 2025 17:43:10 +0530	[thread overview]
Message-ID: <025001dc27cc$72be7b90$583b72b0$@samsung.com> (raw)
In-Reply-To: <20250901-rousing-orange-crab-c05fdf@kuoka>

Hi Krzysztof,

Thanks for the review.

> > +title: Tesla FSD SoC MIPI CSI-2 video capture interface(Bridge device).
> 
> Drop final full stop. Also missing space before (

Will take care in next patchset.

> 
> 
> > +
> > +maintainers:
> > +  - Inbaraj E <inbaraj.e@samsung.com>
> > +
> > +description:
> > +  The Tesla FSD CSIS has an internal video capture interface to
> > +capture
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/clock/fsd-clk.h>
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > +    csis0: csis@12641000 {
> 
> Incorrect unit address.

Thanks for pointing out.
Unit address is correct. Address in reg is wrong here I'll fix in next patchset.

> 
> > +        compatible = "tesla,fsd-csis-media";
> > +        reg = <0x12661000 0x44c>;
> 
> 

Regards,
Inbaraj E



  reply	other threads:[~2025-09-17 12:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20250828085921epcas5p44f9371fb004fe0aa8bf68d1230e01861@epcas5p4.samsung.com>
2025-08-28  8:59 ` [PATCH v3 0/7] Add FSD CSIS support Inbaraj E
2025-08-28  8:59   ` [PATCH v3 1/7] dt-bindings: media: nxp: Add support for FSD SoC Inbaraj E
2025-08-29 17:46     ` Rob Herring
2025-09-17 12:09       ` Inbaraj E
2025-09-18  0:01         ` Krzysztof Kozlowski
2025-08-28  8:59   ` [PATCH v3 2/7] dt-bindings: media: fsd: Add CSIS video capture interface Inbaraj E
2025-09-01  4:55     ` Krzysztof Kozlowski
2025-09-17 12:13       ` Inbaraj E [this message]
2025-09-18  0:01         ` Krzysztof Kozlowski
2025-08-28  8:59   ` [PATCH v3 3/7] media: imx-mipi-csis: Move clk to mipi_csis_info structure Inbaraj E
2025-08-28  8:59   ` [PATCH v3 4/7] media: imx-mipi-csis: Move irq flag and handler " Inbaraj E
2025-08-28  8:59   ` [PATCH v3 5/7] media: imx-mipi-csis: Add support for dynamic VC selection Inbaraj E
2025-08-28  8:59   ` [PATCH v3 6/7] media: imx-mipi-csis: Add support for Telsa FSD CSIS Inbaraj E
2025-08-28  8:59   ` [PATCH v3 7/7] media: fsd-csis: Add FSD CSIS video capture interface support Inbaraj E

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='025001dc27cc$72be7b90$583b72b0$@samsung.com' \
    --to=inbaraj.e@samsung.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=kernel@puri.sm \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=martink@posteo.de \
    --cc=mchehab@kernel.org \
    --cc=pankaj.dubey@samsung.com \
    --cc=ravi.patel@samsung.com \
    --cc=rmfrfs@gmail.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=shradha.t@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.