From: Ping-Ke Shih <pkshih@realtek.com>
To: Ping-Ke Shih <pkshih@realtek.com>,
Bitterblue Smith <rtl8821cerfe2@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Sascha Hauer <sha@pengutronix.de>
Subject: RE: [PATCH] wifi: rtw88: Add USB PHY configuration
Date: Fri, 20 Dec 2024 01:44:12 +0000 [thread overview]
Message-ID: <0253941dda7841bd941beb58605062ab@realtek.com> (raw)
In-Reply-To: <8cc7b4d2051a4b2abe02f6359243bff4@realtek.com>
Ping-Ke Shih <pkshih@realtek.com> wrote:
> Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
> > +
> > +static void rtw_usb_phy_write(struct rtw_dev *rtwdev, u16 addr, u16 data,
> > + enum usb_device_speed speed)
> > +{
> > + if (speed == USB_SPEED_SUPER) {
> > + rtw_write8(rtwdev, 0xff0d, (u8)data);
> > + rtw_write8(rtwdev, 0xff0e, (u8)(data >> 8));
> > + rtw_write8(rtwdev, 0xff0c, addr | BIT(7));
>
> The casting of u8 is not unnecessary.
>
Sorry for the typo. I meant "... is not necessary."
prev parent reply other threads:[~2024-12-20 1:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-19 16:20 [PATCH] wifi: rtw88: Add USB PHY configuration Bitterblue Smith
2024-12-19 19:00 ` Kalle Valo
2024-12-20 0:42 ` Ping-Ke Shih
2024-12-20 1:44 ` Ping-Ke Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0253941dda7841bd941beb58605062ab@realtek.com \
--to=pkshih@realtek.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rtl8821cerfe2@gmail.com \
--cc=sha@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.