From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Damien Le Moal <dlemoal@kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH 1/2] nvme: Cleanup the definition of the controller config register fields
Date: Wed, 12 Feb 2025 18:26:30 +0000 [thread overview]
Message-ID: <025712da-2371-4282-9d3f-ef5b7ffddaaa@nvidia.com> (raw)
In-Reply-To: <20250210002935.1744249-2-dlemoal@kernel.org>
On 2/9/25 16:29, Damien Le Moal wrote:
> Reorganized the enum used to define the fields of the contrller
> configuration (CC) register in include/linux/nvme.h to:
> 1) Group together all the values defined for each field.
> 2) Add the missing field masks definitions.
>
> Signed-off-by: Damien Le Moal<dlemoal@kernel.org>
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2025-02-12 18:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 0:29 [PATCH 0/2] Cleanup controller configuration register handling Damien Le Moal
2025-02-10 0:29 ` [PATCH 1/2] nvme: Cleanup the definition of the controller config register fields Damien Le Moal
2025-02-12 18:26 ` Chaitanya Kulkarni [this message]
2025-02-13 6:00 ` Christoph Hellwig
2025-02-13 6:07 ` Damien Le Moal
2025-02-13 6:23 ` Christoph Hellwig
2025-02-13 6:24 ` Damien Le Moal
2025-02-10 0:29 ` [PATCH 2/2] nvmet: Use enum definitions instead of hardcoded values Damien Le Moal
2025-02-12 18:26 ` Chaitanya Kulkarni
2025-02-13 6:01 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=025712da-2371-4282-9d3f-ef5b7ffddaaa@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=dlemoal@kernel.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.