From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0DCE2C5B568 for ; Fri, 20 Feb 2026 22:15:57 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1237726.1539978 (Exim 4.92) (envelope-from ) id 1vtYmj-0002nr-NZ; Fri, 20 Feb 2026 22:15:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1237726.1539978; Fri, 20 Feb 2026 22:15:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vtYmj-0002nk-Kz; Fri, 20 Feb 2026 22:15:41 +0000 Received: by outflank-mailman (input) for mailman id 1237726; Fri, 20 Feb 2026 22:15:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vtYmi-0002ne-Ec for xen-devel@lists.xenproject.org; Fri, 20 Feb 2026 22:15:40 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id af73a640-0ea9-11f1-9ccf-f158ae23cfc8; Fri, 20 Feb 2026 23:15:38 +0100 (CET) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) (Authenticated sender: nicola) by support.bugseng.com (Postfix) with ESMTPA id 2913C4EE7806; Fri, 20 Feb 2026 23:15:37 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: af73a640-0ea9-11f1-9ccf-f158ae23cfc8 Authentication-Results: bugseng.com; arc=none smtp.remote-ip=162.55.131.47 ARC-Seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1771625737; b=Jy9PZvmv0XHVgphT6huxJqKJHg7OZZSYtrJ58L/2jzFt/YqsTne+vYgfWGGLKM22i5Mq IvdC/6tvJL1ex018at1UAQqRvIqHeSEPaFqTYL8piBixFDtBag0UOvWKggrtmDRC9R8ZZ jHc8hHztDy51mzS+kU66iPb/69Ri4hQ8PuyIoWAjrVqhHZsm0i0XlCS1vJSQfwI1goJtT tEgYsoAt+yej02GG57Cct4qIiH3m/r1dwRIiIdBAaO3s751DV2NnEMF4ridlJ82M5qF5K IcIpSVIIOLvgrM/o7BiJlZdd1BQ3HdHnkb3fz+tNOoqp/iPFz0Px4Tv9oWrEA8/AdQ4ka QOz+FApBNkSO78dspDVmm8Y/EV026u1hDTlJ2m2/Rnk5Aotd67kNTiiKPZ5bEj9iGYWia tqRxOR18T17afA9WK6JUtemRfOPjVdLlOTreGu3DcY06AQqKjl8uLMtLDQmzKZjqSphbE /1XRxDL/1JB4yqabdc4jBKAHWJKeMnKBzktuDlXiVipl0DOq8G4pevV5UUalLF4MaVyW5 4HvZwcIifLvTKrOrtooGSCAGKfS0z2lYr/wkwfIlgoENTrCpuFMamHnXnrp24CKMhZi7K gsRysVeUR+iaGUvJ7zFoxxvw1vJiEQH3dqltSTJeQlZSU4xsucp29n/2hAF3Jkc= ARC-Message-Signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1771625737; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:X-Sender:Organization:Content-Type: Content-Transfer-Encoding; bh=EN/3HH/VIPh5HXiOGshM4hir4fjZy/kgf/ECL5VqcoU=; b=stgJLXcEFrVbzWQkS6S+idXdJWZlb04/xrXTq516cPxVW5WRHYsuP1GfMhamv+qHm5Ix k3BguW5Sn0uvNQbGE6pSrTRFuiHjgr/WHaiv93gAzViCFxM6EMZaHnbxxv8qI5BnQC0yT dDg21o2ee1F0+ht6+ovXi7SLXt3BBUsNF9wDmkY5NEH1m3JT6gbwwyQ3RVax7ZRIQTbsM 6QWDmxFJ+ISU/N5Fj+Pw2YfXU/HLDImF+MdQqk2DWw4QOK/TrLqNTxHvRTZM2Ghpx1r2A dXp46bjKIEUIon0zdGJRXgVPW6K+zr7Bbhn9Xt2Pt9vX/6hZd/S/RWdOg7SFAaXB6YrP/ LEkGTH0H1l3+V0jd+N7oDlkCpVuVDmVm9GgSBZVF8pPeF6vgIy3o9Io/Tc+ywzZv66a8m Qm5h9a55pN7UEEZwJ9YHPzIgGSbEwx98t1ygyW7dTzh9MYYy6UGwmqNcVfef59l+LzGtE DMS45oINW7zuEVv4PmwmGhw0cayuDTzhkZoLO4aHc2xfqONDn6MQ43BGC7G+zU0F5ZzoE RkeRiKmler66ef6wREhPOSO/HFgvsaZAIjBnJiqHb8+tAjEH5IBrmh8cvlUA6FPV36+s7 N7eKezKMkJBVLryc73R7WW9NfspE/0hOO86hr0ETeeqhRBZ6DR7ub1CQ8w0/3U4= ARC-Authentication-Results: i=1; bugseng.com; arc=none smtp.remote-ip=162.55.131.47 MIME-Version: 1.0 Date: Fri, 20 Feb 2026 23:15:37 +0100 From: Nicola Vetrini To: Andrew Cooper Cc: Xen-devel , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Michal Orzel , "consulting @ bugseng . com" Subject: Re: [PATCH 08/12] arm/pci-designware: Fix MISRA violations In-Reply-To: <20260220214653.3497384-9-andrew.cooper3@citrix.com> References: <20260220214653.3497384-1-andrew.cooper3@citrix.com> <20260220214653.3497384-9-andrew.cooper3@citrix.com> Message-ID: <0261cb56885d241d010467e8ff24e169@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2026-02-20 22:46, Andrew Cooper wrote: > * Move includes inside the header guards (D4.10) > * Use NULL in preference to 0 (R11.9) > > No functional change. > > Signed-off-by: Andrew Cooper Reviewed-by: Nicola Vetrini > --- > CC: Jan Beulich > CC: Roger Pau Monné > CC: Stefano Stabellini > CC: Julien Grall > CC: Volodymyr Babchuk > CC: Bertrand Marquis > CC: Michal Orzel > CC: consulting@bugseng.com > CC: Nicola Vetrini > --- > xen/arch/arm/pci/pci-designware.c | 2 +- > xen/arch/arm/pci/pci-designware.h | 5 ++--- > 2 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/xen/arch/arm/pci/pci-designware.c > b/xen/arch/arm/pci/pci-designware.c > index 0bd67524ac8b..6b85213f637b 100644 > --- a/xen/arch/arm/pci/pci-designware.c > +++ b/xen/arch/arm/pci/pci-designware.c > @@ -285,7 +285,7 @@ void __iomem *dw_pcie_child_map_bus(struct > pci_host_bridge *bridge, > bridge->child_cfg->phys_addr, > busdev, > bridge->child_cfg->size); > if ( ret ) > - return 0; > + return NULL; > > return bridge->child_cfg->win + where; > } > diff --git a/xen/arch/arm/pci/pci-designware.h > b/xen/arch/arm/pci/pci-designware.h > index b9deb3b138ae..bd93dab6f2f1 100644 > --- a/xen/arch/arm/pci/pci-designware.h > +++ b/xen/arch/arm/pci/pci-designware.h > @@ -6,12 +6,11 @@ > * Based on xen/arch/arm/pci/pci-host-generic.c > */ > > -#include > -#include > - > #ifndef __PCI_DESIGNWARE_H__ > #define __PCI_DESIGNWARE_H__ > > +#include > +#include > > #define PCIE_ATU_VIEWPORT 0x900 > #define PCIE_ATU_REGION_OUTBOUND 0 -- Nicola Vetrini, B.Sc. Software Engineer BUGSENG (https://bugseng.com) LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253