diff for duplicates of <026501d8ea87$024d1400$06e73c00$@samsung.com> diff --git a/a/1.txt b/N1/1.txt index cf30657..3663442 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -296,52 +296,44 @@ ok. > and exynos5420.dtsi are using same compatible as "samsung,mfc-v7" but > there "clocks" property is different. That doesn't look correct. > This will cause issues when you convert s5p-mfc.txt to schema format. -> I don’t know why that was done that way, but surely this need to be _fixed_ -> first as h/w itself are different. -> -> So my suggestion is to fix exynos3250.dtsi and exynos5420.dtsi compatible -> and mfc driver for it first (as a separate patch series). -> You can use the same approach what was done for mfc-v8 and mfc-v8-5433. -> -> -ok will fix this issue . - -> >+ then: -> >+ properties: -> >+ memory-region: -> >+ maxItems: 1 -> >+ -> >+additionalProperties: false -> >+ -> >+examples: -> >+ - | -> >+ #include <dt-bindings/clock/exynos4.h> -> >+ #include <dt-bindings/clock/exynos-audss-clk.h> -> >+ #include <dt-bindings/interrupt-controller/arm-gic.h> -> >+ #include <dt-bindings/interrupt-controller/irq.h> -> >+ -> >+ codec@13400000 { -> >+ compatible = "samsung,mfc-v5"; -> >+ reg = <0x13400000 0x10000>; -> >+ interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>; -> >+ power-domains = <&pd_mfc>; -> >+ clocks = <&clock CLK_MFC>, <&clock CLK_SCLK_MFC>; -> >+ clock-names = "mfc", "sclk_mfc"; -> >+ iommus = <&sysmmu_mfc_l>, <&sysmmu_mfc_r>; -> >+ iommu-names = "left", "right"; -> >+ -> >+ }; -> >-- -> >2.17.1 -> -> - +> I don’t know why that was done that way, but surely this need to be _fixed_\r +> first as h/w itself are different.\r +> \r +> So my suggestion is to fix exynos3250.dtsi and exynos5420.dtsi compatible\r +> and mfc driver for it first (as a separate patch series).\r +> You can use the same approach what was done for mfc-v8 and mfc-v8-5433.\r +> \r +> \r +ok will fix this issue .\r + \r +> >+ then:\r +> >+ properties:\r +> >+ memory-region:\r +> >+ maxItems: 1\r +> >+\r +> >+additionalProperties: false\r +> >+\r +> >+examples:\r +> >+ - |\r +> >+ #include <dt-bindings/clock/exynos4.h>\r +> >+ #include <dt-bindings/clock/exynos-audss-clk.h>\r +> >+ #include <dt-bindings/interrupt-controller/arm-gic.h>\r +> >+ #include <dt-bindings/interrupt-controller/irq.h>\r +> >+\r +> >+ codec@13400000 {\r +> >+ compatible = "samsung,mfc-v5";\r +> >+ reg = <0x13400000 0x10000>;\r +> >+ interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>;\r +> >+ power-domains = <&pd_mfc>;\r +> >+ clocks = <&clock CLK_MFC>, <&clock CLK_SCLK_MFC>;\r +> >+ clock-names = "mfc", "sclk_mfc";\r +> >+ iommus = <&sysmmu_mfc_l>, <&sysmmu_mfc_r>;\r +> >+ iommu-names = "left", "right";\r +> >+\r +> >+ };\r +> >--\r +> >2.17.1\r +> \r +> \r +\r Thanks for the review. - - - - -_______________________________________________ -linux-arm-kernel mailing list -linux-arm-kernel@lists.infradead.org -http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/a/content_digest b/N1/content_digest index 5e61db9..77891dd 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -328,54 +328,46 @@ "> and exynos5420.dtsi are using same compatible as \"samsung,mfc-v7\" but\n" "> there \"clocks\" property is different. That doesn't look correct.\n" "> This will cause issues when you convert s5p-mfc.txt to schema format.\n" - "> I don\342\200\231t know why that was done that way, but surely this need to be _fixed_\n" - "> first as h/w itself are different.\n" - "> \n" - "> So my suggestion is to fix exynos3250.dtsi and exynos5420.dtsi compatible\n" - "> and mfc driver for it first (as a separate patch series).\n" - "> You can use the same approach what was done for mfc-v8 and mfc-v8-5433.\n" - "> \n" - "> \n" - "ok will fix this issue .\n" - " \n" - "> >+ then:\n" - "> >+ properties:\n" - "> >+ memory-region:\n" - "> >+ maxItems: 1\n" - "> >+\n" - "> >+additionalProperties: false\n" - "> >+\n" - "> >+examples:\n" - "> >+ - |\n" - "> >+ #include <dt-bindings/clock/exynos4.h>\n" - "> >+ #include <dt-bindings/clock/exynos-audss-clk.h>\n" - "> >+ #include <dt-bindings/interrupt-controller/arm-gic.h>\n" - "> >+ #include <dt-bindings/interrupt-controller/irq.h>\n" - "> >+\n" - "> >+ codec@13400000 {\n" - "> >+ compatible = \"samsung,mfc-v5\";\n" - "> >+ reg = <0x13400000 0x10000>;\n" - "> >+ interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>;\n" - "> >+ power-domains = <&pd_mfc>;\n" - "> >+ clocks = <&clock CLK_MFC>, <&clock CLK_SCLK_MFC>;\n" - "> >+ clock-names = \"mfc\", \"sclk_mfc\";\n" - "> >+ iommus = <&sysmmu_mfc_l>, <&sysmmu_mfc_r>;\n" - "> >+ iommu-names = \"left\", \"right\";\n" - "> >+\n" - "> >+ };\n" - "> >--\n" - "> >2.17.1\n" - "> \n" - "> \n" - "\n" - "Thanks for the review.\n" - "\n" - "\n" - "\n" - "\n" - "_______________________________________________\n" - "linux-arm-kernel mailing list\n" - "linux-arm-kernel@lists.infradead.org\n" - http://lists.infradead.org/mailman/listinfo/linux-arm-kernel + "> I don\342\200\231t know why that was done that way, but surely this need to be _fixed_\r\n" + "> first as h/w itself are different.\r\n" + "> \r\n" + "> So my suggestion is to fix exynos3250.dtsi and exynos5420.dtsi compatible\r\n" + "> and mfc driver for it first (as a separate patch series).\r\n" + "> You can use the same approach what was done for mfc-v8 and mfc-v8-5433.\r\n" + "> \r\n" + "> \r\n" + "ok will fix this issue .\r\n" + " \r\n" + "> >+ then:\r\n" + "> >+ properties:\r\n" + "> >+ memory-region:\r\n" + "> >+ maxItems: 1\r\n" + "> >+\r\n" + "> >+additionalProperties: false\r\n" + "> >+\r\n" + "> >+examples:\r\n" + "> >+ - |\r\n" + "> >+ #include <dt-bindings/clock/exynos4.h>\r\n" + "> >+ #include <dt-bindings/clock/exynos-audss-clk.h>\r\n" + "> >+ #include <dt-bindings/interrupt-controller/arm-gic.h>\r\n" + "> >+ #include <dt-bindings/interrupt-controller/irq.h>\r\n" + "> >+\r\n" + "> >+ codec@13400000 {\r\n" + "> >+ compatible = \"samsung,mfc-v5\";\r\n" + "> >+ reg = <0x13400000 0x10000>;\r\n" + "> >+ interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>;\r\n" + "> >+ power-domains = <&pd_mfc>;\r\n" + "> >+ clocks = <&clock CLK_MFC>, <&clock CLK_SCLK_MFC>;\r\n" + "> >+ clock-names = \"mfc\", \"sclk_mfc\";\r\n" + "> >+ iommus = <&sysmmu_mfc_l>, <&sysmmu_mfc_r>;\r\n" + "> >+ iommu-names = \"left\", \"right\";\r\n" + "> >+\r\n" + "> >+ };\r\n" + "> >--\r\n" + "> >2.17.1\r\n" + "> \r\n" + "> \r\n" + "\r\n" + Thanks for the review. -78c7286fbed62b0badfca52674aaac60c3a6ea473e6fa14948a49614485706f8 +ececdf5da026ec98a936f8c1598fe4a7fae425192843b130c04854efe376b599
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.