From: Sangbeom Kim <sbkim73@samsung.com>
To: 'Jassi Brar' <jassisinghbrar@gmail.com>
Cc: alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com,
lrg@slimlogic.co.uk
Subject: Re: [RESEND][PATCH v5 4/4] ASoC: SAMSUNG: Add I2S0 internal dma driver
Date: Mon, 18 Jul 2011 18:17:04 +0900 [thread overview]
Message-ID: <026701cc452b$75f51cd0$61df5670$@com> (raw)
In-Reply-To: <CABb+yY01c9WMfuGYpHZhAAvYiz=FH9bioQ=3Y4ioz7kz=9G3pQ@mail.gmail.com>
Hi,
On Mon, July 18, 2011 at 4:38 PM, Jassi Brar wrote:
> On Wed, Jul 13, 2011 at 10:29 AM, Sangbeom Kim <sbkim73@samsung.com> wrote:
> > I2S in Exynos4 and S5PC110(S5PV210) has a internal dma.
> > It can be used low power audio mode and 2nd channel transfer.
> > This patch can support idma.
> >
> > Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
> > ---
> > V2: change idma_new by new pcm_new api
> > add handling different idma address
> > as jassi comments, Modify the idma driver
> >
> > V3: merge idma_reg_int and idma_addr_init
> >
> > V4: move idma setting in i2s.c to idma_hw_params in idma.c
> > move idma_reg_addr_init calling
> > modify idma address handling error
> > modify module information
> > delete useless dev_dbg
> >
> > V5: delete redundant error print and check routine
> > modify irq handler as jassi comment
> > fix the indent error
> > modify period_bytes_max value to set half size of max buffer
>
> Perhaps you forgot to mention the reason for resend ?
Sorry, I changed MAX_IDMA_BUFFER value (128KB)
Because I used wrong MAX_IDMA_BUFFER value.
Thanks
SB Kim
next prev parent reply other threads:[~2011-07-18 9:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-13 4:59 [RESEND][PATCH v5 4/4] ASoC: SAMSUNG: Add I2S0 internal dma driver Sangbeom Kim
2011-07-18 7:38 ` Jassi Brar
2011-07-18 9:17 ` Sangbeom Kim [this message]
2011-07-18 11:47 ` Jassi Brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='026701cc452b$75f51cd0$61df5670$@com' \
--to=sbkim73@samsung.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jassisinghbrar@gmail.com \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.