RE: [PATCH v2] Hexagon: move GETPC() calls to top level helpers

[<ltaylorsimpson@gmail.com>]

> -----Original Message-----
> From: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
> Sent: Thursday, July 6, 2023 5:23 AM
> To: ltaylorsimpson@gmail.com
> Cc: bcain@quicinc.com; qemu-devel@nongnu.org;
> quic_mathbern@quicinc.com; quic_mliebel@quicinc.com;
> richard.henderson@linaro.org
> Subject: Re: [PATCH v2] Hexagon: move GETPC() calls to top level helpers
> 
> 
> > ltaylorsimpson@gmail.com wrote:
> >
> > > -----Original Message-----
> > > From: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
> > > Sent: Wednesday, July 5, 2023 12:35 PM
> > > To: qemu-devel@nongnu.org
> > > Cc: quic_mathbern@quicinc.com; bcain@quicinc.com;
> > > ltaylorsimpson@gmail.com; quic_mliebel@quicinc.com;
> > > richard.henderson@linaro.org
> > > Subject: [PATCH v2] Hexagon: move GETPC() calls to top level helpers
> > >
> > > a/target/hexagon/op_helper.h b/target/hexagon/op_helper.h index
> > > 8f3764d15e..7744e819ef 100644
> > > --- a/target/hexagon/op_helper.h
> > > +++ b/target/hexagon/op_helper.h
> > > +void check_noshuf(CPUHexagonState *env, bool pkt_has_store_s1,
> > > +                  uint32_t slot, target_ulong vaddr, int size,
> > > +uintptr_t ra);
> >
> > Are you sure this needs to be non-static?
> 
> Yeah, since we remove the mem_load*() functions, check_noshuf() must
> now be visible to the other compilation units that include macros.h, as we
will
> expand the fLOAD() macro to call it.

Since the generated helper functions are included at the bottom of
op_helper.c
    #include "helper_funcs_generated.c.inc"
it can be static.

It needs to be guarded with
    #ifndef CONFIG_HEXAGON_IDEF_PARSER
because it is not used when by any of the idef-parser functions.

Thanks,
Taylor