Re: [Qemu-devel] [PATCH 05/14] stream: Use BlockBackend for I/O

[Max Reitz <mreitz@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1005 bytes --]

On 04.05.2016 11:39, Kevin Wolf wrote:
> This changes the streaming block job to use the job's BlockBackend for
> performing the COR reads. job->bs isn't used by the streaming code any
> more afterwards.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  block/block-backend.c          | 15 +++++++++++++++
>  block/io.c                     |  9 ---------
>  block/stream.c                 | 14 ++++++++------
>  include/block/block.h          |  2 --
>  include/sysemu/block-backend.h |  2 ++
>  trace-events                   |  4 +++-
>  6 files changed, 28 insertions(+), 18 deletions(-)

Hm, I don't quite like adding a new sector-based BB function, but
changing *_co_copy_on_readv()'s interface doesn't seem too reasonable at
this point.

And I guess there are some bdrv_* functions in stream_run() for which a
blk_* equivalent exists, so it might have made sense to change those,
too (e.g. bdrv_getlength()).

Anyway:

Reviewed-by: Max Reitz <mreitz@redhat.com>


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]