All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Markus Stockhausen" <markus.stockhausen@gmx.de>
To: "'Andrew Lunn'" <andrew@lunn.ch>
Cc: <hkallweit1@gmail.com>, <linux@armlinux.org.uk>,
	<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
	<pabeni@redhat.com>, <netdev@vger.kernel.org>,
	<chris.packham@alliedtelesis.co.nz>, <daniel@makrotopia.org>,
	<mensi@mensi.ch>
Subject: AW: [PATCH net-next 1/8] net: mdio: realtek-rtl9300: Convert to fwnode API
Date: Tue, 2 Jun 2026 14:29:23 +0200	[thread overview]
Message-ID: <027401dcf28b$760ad6b0$62208410$@gmx.de> (raw)
In-Reply-To: <3b54c1f3-b60c-4e97-8e14-fec10cb1030a@lunn.ch>

> Von: Andrew Lunn <andrew@lunn.ch> 
> Gesendet: Dienstag, 2. Juni 2026 14:06
> An: Markus Stockhausen <markus.stockhausen@gmx.de>
> Betreff: Re: [PATCH net-next 1/8] net: mdio: realtek-rtl9300: Convert to
fwnode API
> 
> On Tue, Jun 02, 2026 at 07:26:33AM +0200, Markus Stockhausen wrote:
> > The driver still uses legacy "of_" functions to determine the port
mapping
> > during probing. Convert this to the modern fwnode API. With that also
fix
> > a subtle lookup bug in the original code.
>
> fwnode does not exist because it is modern. It allows you to have
> other bindings, like ACPI binding, using the same code. Do you need an
> ACPI binding? Have you documented this new ACPI binding? Has ACPI been
> tested? Are there any OF properties which as listed as deprecated
> which have been converted to fwnode? A new binding should not start
> out with deprecated properties.

As I'm no firmware expert, thanks for the note. 
I came across this mix in the old code:

	err = fwnode_property_read_u32(port, "reg", &pn);
	...
	err = of_property_read_u32(mdio_dn, "reg", &bus);

So I decided to get consistent and opt for the 
fwnode version. To be precise: We are using 
device tree only here and we do not need to 
change any structure or properties. 

Leave all as is then? If yes, do I use "of_" or "fwnode_" 
for new functions? E.g. for patch 2/8.

Markus




  reply	other threads:[~2026-06-02 12:29 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-02  5:26 [PATCH net-next 0/8] net: mdio: realtek-rtl9300: Refactor initialization and port lookup Markus Stockhausen
2026-06-02  5:26 ` [PATCH net-next 1/8] net: mdio: realtek-rtl9300: Convert to fwnode API Markus Stockhausen
2026-06-02 12:06   ` Andrew Lunn
2026-06-02 12:29     ` Markus Stockhausen [this message]
2026-06-02 12:50       ` Andrew Lunn
2026-06-02 18:05   ` Jakub Kicinski
2026-06-02 18:58     ` AW: " Markus Stockhausen
2026-06-02  5:26 ` [PATCH net-next 2/8] net: mdio: realtek-rtl9300: Correctly handle ethernet-phy-package Markus Stockhausen
2026-06-02  9:32   ` Jagielski, Jedrzej
2026-06-02 10:23     ` AW: " Markus Stockhausen
2026-06-02 11:22       ` Jagielski, Jedrzej
2026-06-02  5:26 ` [PATCH net-next 3/8] net: mdio: realtek-rtl9300: harden otto_emdio_map_ports() Markus Stockhausen
2026-06-02  9:38   ` Jagielski, Jedrzej
2026-06-02 10:42     ` AW: " Markus Stockhausen
2026-06-02 11:29       ` Jagielski, Jedrzej
2026-06-02 12:14   ` Andrew Lunn
2026-06-02  5:26 ` [PATCH net-next 4/8] net: mdio: realtek-rtl9300: harden otto_emdio_probe_one() Markus Stockhausen
2026-06-02  5:26 ` [PATCH net-next 5/8] net: mdio: realtek-rtl9300: adapt spaces for defines Markus Stockhausen
2026-06-02  9:42   ` Jagielski, Jedrzej
2026-06-02 10:18     ` AW: " Markus Stockhausen
2026-06-02 11:16       ` Jagielski, Jedrzej
2026-06-02 12:20   ` Andrew Lunn
2026-06-02  5:26 ` [PATCH net-next 6/8] net: mdio: realtek-rtl9300: relocate topology setup Markus Stockhausen
2026-06-02  9:50   ` Jagielski, Jedrzej
2026-06-02 10:50     ` AW: " Markus Stockhausen
2026-06-02 12:24   ` Andrew Lunn
2026-06-02 13:01     ` AW: " Markus Stockhausen
2026-06-02 15:17       ` Andrew Lunn
2026-06-02 18:48         ` AW: " Markus Stockhausen
2026-06-02 20:29           ` Andrew Lunn
2026-06-02  5:26 ` [PATCH net-next 7/8] net: mdio: realtek-rtl9300: reorder controller setup Markus Stockhausen
2026-06-02  5:26 ` [PATCH net-next 8/8] net: mdio: realtek-rtl9300: Convert port lookup from O(n) to O(1) Markus Stockhausen
2026-06-02 12:30   ` Andrew Lunn
2026-06-02 20:02     ` AW: " Markus Stockhausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='027401dcf28b$760ad6b0$62208410$@gmx.de' \
    --to=markus.stockhausen@gmx.de \
    --cc=andrew@lunn.ch \
    --cc=chris.packham@alliedtelesis.co.nz \
    --cc=daniel@makrotopia.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mensi@mensi.ch \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.