nvme-fabrics: crash at nvme connect-all

[swise@opengridcomputing.com (Steve Wise)]

> -----Original Message-----
> From: Ming Lin [mailto:mlin at kernel.org]
> Sent: Friday, June 10, 2016 4:21 PM
> To: Steve Wise
> Cc: Jens Axboe; ming l; Sagi Grimberg; Marta Rybczynska; linux-
> nvme at lists.infradead.org; Christoph Hellwig; james p freyensee; keith busch;
> armenx baloyan
> Subject: Re: nvme-fabrics: crash at nvme connect-all
> 
> On Fri, Jun 10, 2016 at 2:14 PM, Steve Wise <swise at opengridcomputing.com>
> wrote:
> >>
> >> Does Sagi's patch help?
> >>
> >> Author: Sagi Grimberg <sagi at grimberg.me>
> >> Date:   Thu Jun 9 13:20:09 2016 -0700
> >>
> >>     fabrics: Don't directly free opts->host
> >>
> >>     It might be the default host, so we need to call
> >>     nvmet_put_host (which is safe against NULL lucky for
> >>     us).
> >>
> >>     Reported-by: Alexander Nezhinsky <alexander.nezhinsky at excelero.com>
> >>     Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
> >>
> >
> > Yes!  Failures recover and subsequent connects work!
> >
> > Thanks for the help Ming!  Sorry I'm finding already fixed problems. :(
> 
> No problem :-)
> Can I have your Test-by tag?
> 

I can't reply directly to Sagi's because it wasn't posted to linux-rdma apparently, and it must have been posted to linux-nvme before I joined.  But for both:

Tested-by: Steve Wise <swise at opengridcomputing.com>


> Christoph,
> 
> Could you apply these 2 patches?
> 
> fabrics: Don't directly free opts->host
> nvme-rdma: correctly stop keep alive on error path