From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8875CC43331 for ; Tue, 31 Mar 2020 11:06:07 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6197B207FF for ; Tue, 31 Mar 2020 11:06:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6197B207FF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jJEiL-0005RK-ND; Tue, 31 Mar 2020 11:05:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jJEiK-0005RD-K8 for xen-devel@lists.xenproject.org; Tue, 31 Mar 2020 11:05:48 +0000 X-Inumbo-ID: 92a1d98a-733f-11ea-b4f4-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 92a1d98a-733f-11ea-b4f4-bc764e2007e4; Tue, 31 Mar 2020 11:05:47 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 691FEAD86; Tue, 31 Mar 2020 11:05:46 +0000 (UTC) Subject: Re: [PATCH 1/3] xen/x86: ioapic: Use true/false in bad_ioapic_register() To: Julien Grall References: <20200327190546.21580-1-julien@xen.org> <20200327190546.21580-2-julien@xen.org> <20200328110138.inohkfimiiij73vk@debian> From: Jan Beulich Message-ID: <0285ca55-ebaf-efad-efdb-418578034db5@suse.com> Date: Tue, 31 Mar 2020 13:05:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200328110138.inohkfimiiij73vk@debian> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Andrew Cooper Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 28.03.2020 12:01, Wei Liu wrote: > On Fri, Mar 27, 2020 at 07:05:44PM +0000, Julien Grall wrote: >> From: Julien Grall >> >> bad_ioapic_register() is return a bool, so we should switch to >> true/false. > > is return -> returns / is returning > >> >> Signed-off-by: Julien Grall > > Reviewed-by: Wei Liu Acked-by: Jan Beulich