Re: [PATCH v4 0/3] media: i2c: cvs: Add Intel CVS driver

["Vadillo, Miguel" <miguel.vadillo@intel.com>]

Hi Sakari,

On 5/27/26 2:01 AM, Sakari Ailus wrote:
> Hi Miguel,
> 
> On Tue, May 26, 2026 at 09:29:30AM -0700, Vadillo, Miguel wrote:
>> Hi Sakari,
>>
>> Thanks for checking this.
>>
>> On 5/26/26 8:53 AM, Sakari Ailus wrote:
>>> Hi Miguel,
>>>
>>> On Mon, May 25, 2026 at 07:25:05PM -0700, Miguel Vadillo wrote:
>>>> Cover Letter
>>>> ------------
>>>>
>>>> This patch series introduces support for Intel Computer Vision Sensing
>>>> (CVS) devices found on Intel Luna Lake (LNL), Panther Lake (PTL), and
>>>> Arrow Lake (ARL) platforms.
>>>
>>> Thanks for the update. I got from Media CI:
>>>
>>> drivers/media/i2c/cvs/core.c:909:12: warning: ‘cvs_resume’ defined but not used [-Wunused-function]
>>>     909 | static int cvs_resume(struct device *dev)
>>>         |            ^~~~~~~~~~
>>> drivers/media/i2c/cvs/core.c:892:12: warning: ‘cvs_suspend’ defined but not used [-Wunused-function]
>>>     892 | static int cvs_suspend(struct device *dev)
>>>         |            ^~~~~~~~~~~
>>>
>>> I suppose this happens when CONFIG_PM isn't defined
>>> <URL:https://gitlab.freedesktop.org/linux-media/users/sailus/-/jobs/100763316/artifacts/file/artifacts/no-PM.config>?
>>
>> My bad, that seems to be the case with CONFIG_PM disabled:
>> this fix will be needed, I will prepare this and send an update, waiting in
>> case there are more comments..
> 
> I think cvs_pm_ops also needs __maybe_unused.

I don't think so in this case, since I am using pm_ptr(...) for the 
cvs_pm_ops, this should take care of the ~CONFIG_PM. Just to be sure I 
recompiled with make drivers/media/i2c/cvs/ KCFLAGS="-UCONFIG_PM 
-UCONFIG_PM_SLEEP -UCONFIG_SUSPEND" and no ERR/WARN were generated.

I will send and update with this change if no other comments..
> 
--
regards,
Miguel