From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78ECE4A33; Sat, 23 Aug 2025 09:32:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755941550; cv=none; b=jzC0F9mC0l6mW/8ZxiDocjYSNKyIwk8kcaWIJWS5Y2kclRxyIKgulk1BwfCvMwvI71kxGy5mT+YZsueGmsrU61o2sPh//ujCe4sg41wc/c8A9uCiSyTBMy543NBZjooLM7irUxSczlZPoHMa5+1xMlWG0zqkoVy9bgc677PbSEs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755941550; c=relaxed/simple; bh=+gmaRG4bCJwAnZiedCk4uT+ovE7FPGaq2RQsy9fyihM=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=EMs7bwROMqY+sVejCCj18upGupFvCcM8Xnt0r3anWC/GN1meLirZeKCS13bdNwnYFN8zrwM7tW4vy4DNEwMhYDlGJOpcVshqh1q1qkFUDtEF54WGLtGPJ1G3/ifjvpiP1r99L74mJhzqaArx3j754zJWP2evx9JpgAddPCxAB/Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FhjPaQhP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FhjPaQhP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD2E1C4CEE7; Sat, 23 Aug 2025 09:32:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755941549; bh=+gmaRG4bCJwAnZiedCk4uT+ovE7FPGaq2RQsy9fyihM=; h=Date:From:Subject:To:Cc:References:In-Reply-To:From; b=FhjPaQhPe0F68Fk8Xg+5uYwyCCuS30Qb3gJ47QfVRuDzDVENxq/NbNpZI/Am7oLbf +aAUIa9Qk/rz5HZeQ2srhbwDNhMs/cz2aeDfaHpfYlAuH7f0T/JsyrArRXpNjEjjZs 6pbeqYT1CrU2lWc24aBYLB5HgJbetmavjZFWWVlV2Mcu7ZPGQMPItkt/9ww1vNnILp Jp/xLMUbklEpqp3VlycKxM4hbuQXSGOR4LeFtVIWnzuKJKQZPON9fEn6hcwHiCknk9 gAblSTs8LXPsE0SRQBdAECmv/RK3U3/rY8dhFXrA19yQ8eMUzUQiKYaXrJZfSFZVVf 7s3OE9FSPbxdg== Message-ID: <0289f92d-0d18-43d2-b98a-da8bb08e9342@kernel.org> Date: Sat, 23 Aug 2025 11:32:23 +0200 Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Sven Peter Subject: Re: [PATCH RFC 07/22] usb: dwc3: apple: Adjust vendor-specific registers during init To: Thinh Nguyen Cc: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Felipe Balbi , Janne Grunau , Alyssa Rosenzweig , Neal Gompa , Vinod Koul , Kishon Vijay Abraham I , Heikki Krogerus , Philipp Zabel , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "asahi@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" , "linux-phy@lists.infradead.org" , Hector Martin References: <20250821-atcphy-6-17-v1-0-172beda182b8@kernel.org> <20250821-atcphy-6-17-v1-7-172beda182b8@kernel.org> <20250821221832.zsn4rk7nomsbgytx@synopsys.com> Content-Language: en-US In-Reply-To: <20250821221832.zsn4rk7nomsbgytx@synopsys.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Thinh, On 22.08.25 00:18, Thinh Nguyen wrote: > For this patch, however, I'd prefer these vendor-specific settings to be > in their own glue driver. I can only imagine more changes will be > introduced in the future with this vendor. See if we can use the new > glue interface in glue.h (some call this the new "flatten" model) when > creating a glue driver. Nice, thanks! Hints like that are exactly what I was hoping for when I sent this RFC. When I originally started working on this I tried to use the parent/child model but didn't really get anywhere. This flattened model looks very useful though. I think I can even move some of logic from the previous commits to dwc3-apple.c if I extend the glue a little bit. I'll see how that works out and maybe do that for the next version then. Thanks, Sven From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 849D6CA0EFA for ; Sat, 23 Aug 2025 09:38:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject:From: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=l3eBguMDxgnib1/OZaPq5P1BT5fg0PHkxAwPdKNXNiw=; b=h3HdSAGtH/Ysga CfrhEOgOl/Z8YF6ph9KaNoqWAX1678+uAOcJruy4zHSiLSUqGG9gXBynht4ZuJd2bRqwbHlWMm42b 7UsdVY750SMA+n7KfHswqffahByjd9AxT5WlBP+cTzaSL5gXEcXAhAb0FXr39ixadKJZIW3dMUe8F KJILloVaNVhrdYgqHBoJSZuZvQ4L1LSgiq5u97MFk9u2DLN/ert+FMBU9haZMkNe6vVWTSQsHQ0Ak ZjsTwWF6Vmp/HmfY+QsxmNIXPmCyh4v+vd4P1GS8A8kho63Y2aQhF3oa+MDCfL9Sy9Xr1sKV6rmRf bJlA58WhA4VqaN1ESYBA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1upkhi-00000004Yha-0x57; Sat, 23 Aug 2025 09:38:30 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1upkbv-00000004S7d-3Yvq; Sat, 23 Aug 2025 09:32:32 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 57B7C5C4AD0; Sat, 23 Aug 2025 09:32:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD2E1C4CEE7; Sat, 23 Aug 2025 09:32:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755941549; bh=+gmaRG4bCJwAnZiedCk4uT+ovE7FPGaq2RQsy9fyihM=; h=Date:From:Subject:To:Cc:References:In-Reply-To:From; b=FhjPaQhPe0F68Fk8Xg+5uYwyCCuS30Qb3gJ47QfVRuDzDVENxq/NbNpZI/Am7oLbf +aAUIa9Qk/rz5HZeQ2srhbwDNhMs/cz2aeDfaHpfYlAuH7f0T/JsyrArRXpNjEjjZs 6pbeqYT1CrU2lWc24aBYLB5HgJbetmavjZFWWVlV2Mcu7ZPGQMPItkt/9ww1vNnILp Jp/xLMUbklEpqp3VlycKxM4hbuQXSGOR4LeFtVIWnzuKJKQZPON9fEn6hcwHiCknk9 gAblSTs8LXPsE0SRQBdAECmv/RK3U3/rY8dhFXrA19yQ8eMUzUQiKYaXrJZfSFZVVf 7s3OE9FSPbxdg== Message-ID: <0289f92d-0d18-43d2-b98a-da8bb08e9342@kernel.org> Date: Sat, 23 Aug 2025 11:32:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Sven Peter Subject: Re: [PATCH RFC 07/22] usb: dwc3: apple: Adjust vendor-specific registers during init To: Thinh Nguyen Cc: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Felipe Balbi , Janne Grunau , Alyssa Rosenzweig , Neal Gompa , Vinod Koul , Kishon Vijay Abraham I , Heikki Krogerus , Philipp Zabel , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "asahi@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" , "linux-phy@lists.infradead.org" , Hector Martin References: <20250821-atcphy-6-17-v1-0-172beda182b8@kernel.org> <20250821-atcphy-6-17-v1-7-172beda182b8@kernel.org> <20250821221832.zsn4rk7nomsbgytx@synopsys.com> Content-Language: en-US In-Reply-To: <20250821221832.zsn4rk7nomsbgytx@synopsys.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250823_023231_938061_ED6A9C9E X-CRM114-Status: GOOD ( 11.80 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Hi Thinh, On 22.08.25 00:18, Thinh Nguyen wrote: > For this patch, however, I'd prefer these vendor-specific settings to be > in their own glue driver. I can only imagine more changes will be > introduced in the future with this vendor. See if we can use the new > glue interface in glue.h (some call this the new "flatten" model) when > creating a glue driver. Nice, thanks! Hints like that are exactly what I was hoping for when I sent this RFC. When I originally started working on this I tried to use the parent/child model but didn't really get anywhere. This flattened model looks very useful though. I think I can even move some of logic from the previous commits to dwc3-apple.c if I extend the glue a little bit. I'll see how that works out and maybe do that for the next version then. Thanks, Sven -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy