From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C52678BE9 for ; Thu, 4 Jun 2026 12:32:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.20 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780576355; cv=none; b=L7bKlrsFXvX9miw7l4jdRCyAKy+RF8KDgz7IA2TJgI/1I9UN7KFLRbVwIok+7IIqgfLPMjwY4Lw4V/xdHvyG7fDl9tg1mhUFWvmSBAUJOKAXbekyEpWg9lVsyA9rwMcMMwKftzg0yV4bt4Cx9rS2JmFXKqBgkCNqGKlfIQw6iFg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780576355; c=relaxed/simple; bh=CieiAfFRzQdnCrxeCukMFsCDwovM4ykXKDTjq+n0PAM=; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID: MIME-Version:Content-Type; b=InfDkKm//EUyvnKiV+ydc/WnPFZtSevbpwiOqRFrUZA28xQnYR/HZuQW5N6OcBxzqjbLNTcCAe9mMJEwrjX4R5cmEyFkSpWTrVYLM4oWbAfhGrJrrm3ood8HZO2+RqB8UAXn88I+Qx2/ia0MIhE72tCD8xlW5k7lkwpg2zpRNPU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de; spf=pass smtp.mailfrom=gmx.de; dkim=pass (2048-bit key) header.d=gmx.de header.i=markus.stockhausen@gmx.de header.b=PCPjBAM4; arc=none smtp.client-ip=212.227.17.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.de header.i=markus.stockhausen@gmx.de header.b="PCPjBAM4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1780576346; x=1781181146; i=markus.stockhausen@gmx.de; bh=QxN6h7zWjSYNxrAjrAjK52RvuKRubfin9VdwGTB0CBo=; h=X-UI-Sender-Class:From:To:Cc:References:In-Reply-To:Subject:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=PCPjBAM4VQXmBHupPZm8Jy1CIqPnCxLdmnhl425wyOVvAT6RqvL+wfsOi/bl/DLd Ji2XfnM2QXBUtUU2ApxSxQO7wYEVjpoqeGhMkmvglB2ckQpJwq5w7hiBMN5CcjHcx 0R2Qx0GhNpqwbnZLtS2iXQUt6IrzxbC7PYlVeLYURka0oQABHARS7KPaCZQNHwJg0 fREaUF/1GKRSwq4A9KuBtzQs+HU52jtY+z+U8cPl6BQC48vkelE27CBU9iFhzg7pQ TNHioP8HO4RA1eClM8wgHuLfrS5ge7WHXs5eCCIQrLPArEqSPCKOgCrn2Nl77dyrL y6PRyn+tSD7FLYdKDA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from client.hidden.invalid by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MvbBu-1xNdbo29Zu-015O5K; Thu, 04 Jun 2026 14:32:26 +0200 From: "Markus Stockhausen" To: "'Thomas Gleixner'" Cc: References: <20260512184646.1896480-1-markus.stockhausen@gmx.de> <20260512184646.1896480-2-markus.stockhausen@gmx.de> <87wlwf62hr.ffs@fw13> In-Reply-To: <87wlwf62hr.ffs@fw13> Subject: AW: [PATCH 1/2] irqchip/irq-realtek-rtl: Add/simplify register helpers Date: Thu, 4 Jun 2026 14:32:26 +0200 Message-ID: <029301dcf41e$337ae300$9a70a900$@gmx.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQILRM3F3YDAPBcJAUGwUCqM0KVYoAGmAsnQAgCZ2zW1tHlL8A== Content-Language: de X-Provags-ID: V03:K1:CNl6TeYKxoBcHTX1IoPqrhNjwc5teyYc3ICvt4eV/H82cd2BTHZ Ujd884LoR3ijn8VKEGdgaCN6u1pmbqkE5cLiVWwMi0nr6NoKwH1ZbdK7EsdqSikOfBkBoWG 1kivsDlHcGBdUlZJyNBKZil89g03ClcEAxc0yCviV4jmgt06eqi9bYheOOGI1q2GgNV/bN8 YCga6IMJVDyncadhGGRWg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:O+5XcnTSRCc=;McoGli53/IX5mU14jSOcuJLgmtd gPzrR3PG9oezLjzHk4fjXaOk+4V9bQwTIpyysTwShEavlzsM322WXQ2NyhbDGWzXtbFlM53IQ EHmymnUmIn6M1yRFGs1/+OiNt3+Sv9mpaT0nTamjhCRuAq/7UsUs1w/JZXOD3wqeXDaarMsjB 4amiVnxtxbEtG4VJtxvYC/9SnyzbjGoKRdYKLSv28XNVPayGuzZueuQtxqdff2YE5TJTh759S 5mJ9t8aMSopb09LyvFIAgtZF/w7cX4EfcZ7mwy7NxqHQYWxmI8xreFLM8ePjY5XaewpLIsmoQ rJ1fapvr69iXl0Vdmsx1EKWoglgzrCvtqP8qAOVTlCjjMZ6vtGiLgP3hf2aDguNdaHjzJqnrN fxjRCImA23IMxTQAiHvAIqvif1mXG3xUSkStOvAVn0hm2NowIc6UPvSc59mZGszvewdIFYYjJ CvhAVl5V8Kzy0TBH5cjv5oM745HpUZeuRfzOxj6zRj2c8a8b3pLHrIHksaZYKrg5kz/y98iMH WsAiE//7omYA4+FUH1K783kawT6We2WUDMy5/ssQZNMioGHT5ddVKDzGbcnG+x6b+5jXRVnZB DegWdd5/Tpft//p7AjtfYtXdIYENhIBJXqqzNRH7qftgnU8qhc5dhZhQdhnvgQcpW0jhO8yOu n72b6ctA3Vkok+LPbNdOMIialVNTe9ikUw+Kgorl5P/3yIXdi1tSURkRn6UexaFz+czScdF7C fpZWJFTlXmdAKRMBVKJJHuSL7zTKFoF7dJ3OpYMCunyhsOf6tUfhchYqPeulohOXTTcmL2Cu7 Ve1XLUB0yaku7xfseYMRpalTUeL0kDsCUan9/QM6Js3ZIxf3TvQXlSRKXL7Va/GbpgFES9Jm2 YtHANKyFbZ/ulZliv7xFAStrclpkJbE1cB4Du16br3MOiyjTxtYt2bUMyBnE4p9m2lE3UrVb0 uwpkf6G1IMlcuLXHKWliIWn4j6FiIIcPvMjBRTdVBJ+D9dtmkIZzaNF3NK5YtRcmvS8dm4FoB /aAfAXYBj2BMfjhbIrTtXz4p6wKujRA1aJm8Xj3yQ9LSnjMXNSfERwKW2o6xmp+fN2SfBub0/ WiOiL3gQ2c/LT8/W9Hmx4v1o4VLP9rSdOUSSuGmPEDp5Ygd5NDBxBGy2nMEMNoTKZABZb4T+V OkQCl3llQLJB/MKnj3ibGZ91BG4ZAR4syvJ37vZHXB6TgYJRDY4pbkJZMuvOxF5kNzTW5rnGi OtDSF/m1aHJoAyiccaNgpsA3RiHD3zlr5RIbCOydE+BhD6JmPsWDLleiywyAZHRdiPpcGQ7OJ JTXYK06byQ0KLB7tS5ANttSgIQVqXnbhh/LU7kAP7o7HW5am/hWj5Xinvy2punfpH4iy0llEH lG1pFLzIAgPAY6oTrd0GeNXMWbi1Qvdo48wQRC7JjgxWj/IIye+zTZVU7UmxyHRzTPRBZx5eL hXzsLr88lW0rQW8UwkEEJNUKjHgUYluibR0S2iZZjIrXIKfuA/rjd1ePviLMmq4y6TUijGrH8 ANg3UGXkfmw/hJqcqMThpyAGQG2DskmL6PbUb53cSE/qPQVzLA6tFSOXrZ8sxQ7APAPJXc6dw wL+Pc/bC0AaseHM13SoKRDnpst7oZf/qgpBA+Y7pAaelkROLjMyyhvklUB19L15elpCKHd31S qVQQFoLFcPw2/ijWc6cEGVS9oJw2WX6dQOunrjlADQ6alVZafNtXyn0h9IP2pszsKRIbc3XUb 6zLK7+Yd/31ovDEb//Hj0R35H+gNjXO/5fyGmuKi7Bg0ZLXbVSXcKnuQJQD4NJxppcaUW8s2Z Cev1kqq6PXRhxpOarjzU1O5LVO1opuF1xFDw1pNKcHk08AgJ/dfu62kllCRpxzF8wQeFFDifa VK63p6VOYoyfKEv1lPjVjZhUMgII1/7hkWgZFuZ+8xSndtxd508sSQ8iqWcX971Ki8zUrVtJH 6rOevfMtQ1S7iwgn2qbXrnTE82cKu3n5sbLBpllcod5OpBJJTxzXEw7diJxWtuA0K+xM/ZqzA HtQc4IEhFURLtRSzRJdCTq1PSthxpZNadlf7/eeziXpiZVpfJw7rdQoekuVoTYS4MCJ5uPDxC P9/BHj+uE0VrYEuwTqmXzcTeWTPVgih6LUhcy+ywwYQEYM9KQ+QFnPbGIp7sb3uhCa5mGCb/Y U+YzrgQ/ForW36gq6MFZZniEe1tfxSDJNWfjgyRdUGtHQXYmhe6tnmTfymlTvQ2Ti/pzUR6LV j1NZM1ix4YKbIBmhDo4iCkX16f2wpsLoe7/v8DFfLa6arPeiq3xViyQDpoBA7BRmEmrX8EkPe mze6tnquyxB8148m8uR7cqCY/Xxkoqubyg+WXKsYjUCeEtC7z0uZKG/2gQ3HTVZGMXv/gWGbP qF+DFd0P7G2AKcKKtmCDUiodPRmm5VPo8zEUl9uAtyBRQbaGU9sBGmr5zb0G2PzCClxtlek2i 2P+2kTr8Nl9HBqVz9kuJnAUphvT6gVhnZpptXWnJVO9XyEkrA3qQhy2mgm7dksVt4SZWDb0Qh R3bSakgZBg7nbbiGdOFaSu8yg2WHYdcPuyMe3lfiiT8nZRETQDrFkzCg2S36vvrvYOnAbLBvK VLF4+8aefVu5MoatUVQQ0JUCatFh2k8d5XIuRqYhj0aCmIQ8FugqIy5HLBoIiNHSx9D4mAZPn 5tdP0nlEEuNLk/r6yZouFXTw2MGCm5aHQA5Wq3UVFtuxtsDccm74NNLnNrNTBPiZLHyxD6na0 bNRJs6Xwp7FXfQfgF6U68HliU8WUT0LYF9epZHdfXL9JjJjYGqrIl2liv0UgT7x6JjFecSTd1 /EOOn11QwYwlPwq0lGsv//TX6RrgTnOHKWMujCprCJdTxCuzDCZyrzBZMIMCN9Gc8e9k4Jyfh z9O89u24Aof8y2cY3pzlE4/FsUGWZgC+H7rnnPQDTZzLvlVFbb8xy4cxOpCxerj/0HXj2nF5W iqCjuQ+b00C16R/OE5Pq8E8HI4qeDjMvM/k1BIR7bnZPrejotpjVztPl1swI4gy2rm3pQQm+E ExRHsswZEL/NMB4U8pYPnyV9xPEk/F1ro4/0mHIxz9udSah8Y4NXIpNhnu2Ag2OlplviVJP2E Hyx92schWa/pIzaBtTTDdGUehEylCa2tSax+Fq0d59VEDkaQet/PoM5635IEkfNWqcwcmKmZG gaViEOdnIl6R3XE41lpvG6mbU8s41rO8XOxC6vqVeMndscMI+P8s2ZVRB0MXMGYF8ZOvThV+b NYNQsyjVZLzW5mI766JTvnPUSCBF6GQkAB6KkRE4vfLISTbOFfpJlwcwSFW2lq8RDUGq1kV73 T6RqZFlvFJzbeWppJBLMF8RNipe3x6HDbigkaJWF8fh7Q/WcOWqiq4FDUfioRnrb+lbMRc2Tl jHi4zqZWSuoJpMeHu2hPgUcrS5oeZazExSK6r+X27qRyjgo0ulkKrnlfiacAbJxBImcp4mx1c 3qPNZTuLy7GaYjt94wczhrXlmdeiIfaYFm0uKq5F8WzBbtetShSKj1cEebpku0bjDYq/EdL3i 86PbbklKEk6Ht6xkPSHw8GzDFTT1Q4i0L4puEBBbimku8IbU++jfhP0am/Zcze/cAiJs2HPwX 1Dl7wPofHgloeuecrYDZWLss7+qspBhnqI+dYDfEBdW+2P5zgpe3qhDEIw/qz8RhImcMjogqo 8I6rhu1Jf6SsYZ7WRiWEjk4KN/wjZPNkj233l5aybU9aDeutLA9Et5s+lsfRpenfEqyXWqwr2 s6naRRB874+57J0dWmAb7tVONXOPv9+GMrKFSquY9m00LwHnvsAZ55YT+nB8eC1b5Qj93dN+S bUevxLUXMP57t3R3l/RHhO9pWKs1bwrHehD6Sc2AAU+82QLHjNpHbTsyox7VH+J8pblMEEbt2 wqMhgxRFrhtPGwJifk8ylhoUnzpQzjApKvHudHYwDvyC9qr+vSo1OFvJdJG0R/fa3YhM44H5L CKEC4joIVxmFC9lgaJLx7Fa/OmOTupGxgFfvUHQysETE7564ywtBjPZE22zUOUeVOWsQyQWof YLofvO9D+l8pJpT8EiVUp1EXzkzfzCvO81mLqI2nUH0DfiPDg0oNUYhASLfNUD/c9rB0bAkK6 zj5zFilEXW0p/L/YP69pmoFKTb5e9tt/R9shRiBsw1QOQcDu4pBmhsL8rpGtDUm3UxZS0bdbd Tnl3PmAG+8vQ4fpRYwCQZakjQae8Bg9aUfrlm9irbwHomrBFTnELDXCIFmueW+3SZ8GZ7K3no gUDwWZAoEfYzwrpRFtpQnubzGvg78BYPVSWb6q3gsL2R28jGfMYTsXBd1XwGmk8DQbgXtgwdy DIMrlk73v7Jt2bNhg/7BOKebyu6cpnePzsla5DfwlgsknQCg8s2BuDtnioIdEZvPl3SwCXVK5 4bSsW7QGYOejDgGrl55Ua3KNQHaNCUVfzDG+Neh4FVyBA13LFaNhMgaNwezgXTsWShRiypAPO HWmmz/WWZQgbdjS5TvM1HM92IaKuHD1Qfjhi6Xl/ck+UlzpkYdqdoLHH4CjNeupDouAVJIjVf QPcT6rHYVtVvbxM64rw5NGSsgFmlZ2mN81ZQt5J8DmKYT6zmYE4DfWwNM+/VPxZ77uacdKAhd Qbp+3OC/fQF1HriksuzMlarB8qybgYLac2IuhTMjrlGobQANu6XMsgH0RgYQKcEWqKswF3gb4 pT84yhURPoEZC1fj+7dpShr7dqAo6zSZaXyv/QzuYqgRARVAshoDj4p8utB9oSduHJQKNtJ4p x2CWvwcyR4SPZ+HAqcUYoZve6P1HUkWoeAMqMFzUj7wd5XgcjzwYtXMaJNLRdxpReXt5aPt5g D8oH/B1Udupqb+464ysPyAQzRd1YK1rpeHL/ws/kvNT/NHnq/BgiBL3F6fDppA/iuxO0oGNz5 J7D9GR/wcuzz9sxlWyt4Nm1fQ440ID+6vwhC1VRoQ8mXtNR+WMEn7QUDYT0cm4ULn3WWB9vcN vgXjR3PPjs/GkgGG2cEgbPdMibXQdC0zrEhZrzRF6T7o7bMPmtlTYtaESDamGlo+kgVA1ExQS vz7H0e51nGBfr2y5MfjURGgDqJcluVXylfEHQVsrAMSEQZqI1DQL1jMt8B7NF4yswUGO8nRPQ xNUfh7Ssjo7SeYjuS/Ahj1+uT4JE0+zf39ROkB2acza1xR/flaJE17pgfTqeEzfZCmagMwbfe qvW7IALZfazIfqz9az5K8OWxbYXxzYBiOYI9DaKFN2JyGDB7AClaEoSlBV8qpJ34lo6WtlA6F wFPeVqZiz8PCxN3rvRP0GaGFxhwJ7bGf28slHYpxwwbb8Xk//yg9HK+qG340UL6d7VUxTgRIK hezG67+ujvmtphuNoGhs5Ce/suH/YVw7HxlSatrbHkC40IGNLawCwpOGh86X0e9oLcKpohHzF 9q086WIucajCesAT9PLnsBm6KpfdlPfLKToPtJFeKaj9hOQt6kXTbSglma3txlnt8AvwRV5Pi /CW/wNjOLVMNnnY3HoX9VthgcWdlzz8y7QI0NMTDErzjWZQTC5edGc+anClfhKbDDWnmwEjOU IfyVNB0eQTUYLcAuO6+1HKD5Ct+7SZWtjpoc5rsejrfuue+6bMR8oHjcpc9/7yNRPrEXwg== > Von: Thomas Gleixner =20 > Gesendet: Mittwoch, 3. Juni 2026 17:57 > An: Markus Stockhausen ; linux-kernel@vger.kernel.org > Cc: Markus Stockhausen > Betreff: Re: [PATCH 1/2] irqchip/irq-realtek-rtl: Add/simplify register helpers > ... > > - > > - value =3D readl(REG(RTL_ICTL_GIMR)); > > - value &=3D ~BIT(i->hwirq); > > - writel(value, REG(RTL_ICTL_GIMR)); > > - > > + disable_gimr(i->hwirq); > > raw_spin_unlock_irqrestore(&irq_lock, flags); > > } > > =20 > > @@ -89,7 +98,7 @@ static int intc_map(struct irq_domain *d, unsigned i= nt irq, irq_hw_number_t hw) > > irq_set_chip_and_handler(irq, &realtek_ictl_irq, handle_level_irq); > > =20 > guard(raw_spinlock_irq)(&lock); > > _irq because this is task context. > > > raw_spin_lock_irqsave(&irq_lock, flags); > > - write_irr(REG(RTL_ICTL_IRR0), hw, 1); > > + write_irr(hw, 1); > > raw_spin_unlock_irqrestore(&irq_lock, flags); > > =20 > > return 0; The above is the only one of your guides I'm unsure about.=20 With the whole series adapted and applied I finally get=20 static int intc_map(struct irq_domain *d, unsigned int irq, irq_hw_number_= t hw) { unsigned int cpu; irq_set_chip_and_handler(irq, &realtek_ictl_irq, handle_level_irq); guard(raw_spinlock_irq)(&irq_lock); for_each_cpu(cpu, &realtek_ictl_cpu_configurable) write_irr(cpu, hw, 1); return 0; } Boot gives a warning. [ 0.009035] ------------[ cut here ]------------ [ 0.014075] WARNING: CPU: 0 PID: 0 at init/main.c:1059 start_kernel+0x3a0/0x510 [ 0.022115] Interrupts were enabled early [ 0.026483] Modules linked in: [ 0.029846] CPU: 0 UID: 0 PID: 0 Comm: swapper/0 Not tainted 6.18.33 #0 NONE [ 0.029871] Hardware name: Linksys LGS328C [ 0.029878] Stack : 80b7dddc 00000031 00000000 00000001 00000000 000000= 00 00000000 00000000 [ 0.029929] 00000000 00000000 00000000 00000000 00000000 000000= 01 80b7dd98 00000000 [ 0.029975] 00000000 00000000 80a846d4 80b7dc30 00000000 ffffef= ff 00000001 00000031 [ 0.030022] 00000033 80b7dbf4 00000033 00000264 00000001 000000= 00 80a846d4 80b7dea8 [ 0.030069] 00000000 80c23ec4 80b95238 80100000 00000000 80b9d4= d0 00000000 813a0000 [ 0.030116] ... [ 0.030125] Call Trace: [ 0.030129] [<80114e38>] show_stack+0x28/0xf0 [ 0.030163] [<8010e0ec>] dump_stack_lvl+0x70/0xb0 [ 0.030197] [<801390cc>] __warn+0x9c/0x114 [ 0.030227] [<801392c4>] warn_slowpath_fmt+0x180/0x188 [ 0.030246] [<80c23ec4>] start_kernel+0x3a0/0x510 This goes away with switching to guard(raw_spinlock_irqsave)(). Anything I'm missing here? Thanks in advance. Markus