From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-184.mta0.migadu.com (out-184.mta0.migadu.com [91.218.175.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 989F923C506 for ; Tue, 3 Jun 2025 15:07:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.184 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748963242; cv=none; b=oqFp1p0D8pxdLZXZ317b7AcmWjZ3Uc4iOBGGhzNm7O2Jf8RLsHpTPdvPJyc5/HrX8Q8CVU6ITjXM5CerSfKCm7SVH0G0bTq/MYcaWeOxclAfThSEUOlXQJF2cht5adj4UDAD2FevmPx9X1YQ/2AELdAuayM1TUkkNHeW0+nR8NQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748963242; c=relaxed/simple; bh=RRUIgBZA7/RZuCTepb8TfhL+tkUhWcimMhe1FoMS5Uk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YQSGSNckruFvudaLTJRxn9UT8JG/XN0C8KKtsMRGeN1revOgD+heWRSW5BNN1ckSho9ZR3c6FLVv+h4dLwMG6Ek8GaLW8/RceoFKFse0ECswzeRDJt3JhNGKbZQByv8Q1+lkI+2WzzUfqvROt9DGa3WDTzda5KTBi+0+zoGbsuE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=WnbNpVT1; arc=none smtp.client-ip=91.218.175.184 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="WnbNpVT1" Message-ID: <029e657a-cbf5-4db1-9ddb-5fbf75ea8f4e@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1748963236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H/S8RT0q+1oRhcL15WhoKhfpGElrxWknt11mPVDpvpM=; b=WnbNpVT1Sydsz6sSCFK8n9wJMC4R0fge4PL9E1PGhGFHbo/rMlIy11Aj7TyISgwm6Bifm8 6HfqOTUd38BaDNZ8nOWjK3JFU5H6N0XNp7ci9md+59/Kc6QopugCH5ZBZ0fF9XxP2gp98l c+e4s6HA+Ntv9pGntr2IWEKllpTv0Is= Date: Tue, 3 Jun 2025 23:07:03 +0800 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH bpf-next v2 1/3] bpf: Add cookie to raw_tp bpf_link_info To: Yonghong Song , ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me, qmo@kernel.org, jolsa@kernel.org Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250603022610.3005963-1-chen.dylane@linux.dev> <48e85d82-e5c7-463a-aef3-f1ecbe863524@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Tao Chen In-Reply-To: <48e85d82-e5c7-463a-aef3-f1ecbe863524@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT 在 2025/6/3 22:52, Yonghong Song 写道: > > > On 6/2/25 7:26 PM, Tao Chen wrote: >> After commit 68ca5d4eebb8 ("bpf: support BPF cookie in raw tracepoint >> (raw_tp, tp_btf) programs"), we can show the cookie in bpf_link_info >> like kprobe etc. >> >> Signed-off-by: Tao Chen >> --- >>   include/uapi/linux/bpf.h       | 2 ++ >>   kernel/bpf/syscall.c           | 1 + >>   tools/include/uapi/linux/bpf.h | 2 ++ >>   3 files changed, 5 insertions(+) >> >> Change list: >> - v1 -> v2: >>      - fill the hole in bpf_link_info.(Jiri) >> - v1: >>      https://lore.kernel.org/bpf/20250529165759.2536245-1- >> chen.dylane@linux.dev >> >> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h >> index 07ee73cdf9..f3e2aae302 100644 >> --- a/include/uapi/linux/bpf.h >> +++ b/include/uapi/linux/bpf.h >> @@ -6644,6 +6644,8 @@ struct bpf_link_info { >>           struct { >>               __aligned_u64 tp_name; /* in/out: tp_name buffer ptr */ >>               __u32 tp_name_len;     /* in/out: tp_name buffer len */ >> +            __u32 reserved; /* just fill the hole */ > > See various examples in uapi/linux/bpf.h, '__u32 :32;' is the preferred > apporach to fill the hole. Well, it looks better, will change it in v3, thanks. > >> +            __u64 cookie; >>           } raw_tracepoint; >>           struct { >>               __u32 attach_type; >> diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c >> index 9794446bc8..1c3dbe44ac 100644 >> --- a/kernel/bpf/syscall.c >> +++ b/kernel/bpf/syscall.c >> @@ -3687,6 +3687,7 @@ static int bpf_raw_tp_link_fill_link_info(const >> struct bpf_link *link, >>           return -EINVAL; >>       info->raw_tracepoint.tp_name_len = tp_len + 1; >> +    info->raw_tracepoint.cookie = raw_tp_link->cookie; >>       if (!ubuf) >>           return 0; >> diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/ >> linux/bpf.h >> index 07ee73cdf9..f3e2aae302 100644 >> --- a/tools/include/uapi/linux/bpf.h >> +++ b/tools/include/uapi/linux/bpf.h >> @@ -6644,6 +6644,8 @@ struct bpf_link_info { >>           struct { >>               __aligned_u64 tp_name; /* in/out: tp_name buffer ptr */ >>               __u32 tp_name_len;     /* in/out: tp_name buffer len */ >> +            __u32 reserved; /* just fill the hole */ >> +            __u64 cookie; >>           } raw_tracepoint; >>           struct { >>               __u32 attach_type; > -- Best Regards Tao Chen