From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [PATCH v13 0/6] Introduce the STACKLEAK feature and a test for it References: <1527365430-8303-1-git-send-email-alex.popov@linux.com> <20180622013339.GA10129@gmail.com> <20180622031645.GA26826@gmail.com> <20180624071817.GA32154@gmail.com> From: Alexander Popov Message-ID: <02a4e913-ff52-405f-c8ea-61efd6d6af73@linux.com> Date: Thu, 28 Jun 2018 18:48:37 +0300 MIME-Version: 1.0 In-Reply-To: <20180624071817.GA32154@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Ingo Molnar Cc: Kees Cook , Laura Abbott , Kernel Hardening , PaX Team , Brad Spengler , Andy Lutomirski , Tycho Andersen , Mark Rutland , Ard Biesheuvel , Borislav Petkov , Richard Sandiford , Thomas Gleixner , "H . Peter Anvin" , Peter Zijlstra , "Dmitry V . Levin" , Emese Revfy , Jonathan Corbet , Andrey Ryabinin , "Kirill A . Shutemov" , Thomas Garnier , Andrew Morton , Alexei Starovoitov , Josef Bacik , Masami Hiramatsu , Nicholas Piggin , Al Viro , "David S . Miller" , Ding Tianhong , David Woodhouse , Josh Poimboeuf , Steven Rostedt , Dominik Brodowski , Juergen Gross , Linus Torvalds , Greg Kroah-Hartman , Dan Williams , Dave Hansen , Mathias Krause , Vikas Shivappa , Kyle Huey , Dmitry Safonov , Will Deacon , Arnd Bergmann , Florian Weimer , Boris Lukashev , Andrey Konovalov , X86 ML , LKML List-ID: Hello Ingo, On 24.06.2018 10:18, Ingo Molnar wrote: > > * Alexander Popov wrote: > >> On 22.06.2018 06:16, Ingo Molnar wrote: >>> >>> * Kees Cook wrote: >>> >>>> On Thu, Jun 21, 2018 at 7:07 PM, Kees Cook wrote: >>>>> It needs rebasing to -rc1 (which I've done already, but I'm still >>>>> doing build tests on it). >>>> >>>> It's passed basic allmodconfig builds: >>>> >>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git >>>> branch: for-next/stackleak >>> >>> Ok, that's 6 patches - please send the latest for review as emails to lkml the >>> usual. Thanks! >> >> I'll resend the rebased v13 shortly. > > Well, I assume there were v12->v13 changes, correct? > > If yes, and if it's on a different base krnel, then why did you call it a > 'resend'? That will only get fewer people to review it ... Please don't do that > for future iterations. Let me recall the timeline: - I sent the v12 on May 16 [1]; - you gave a detailed feedback on v12 on May 18 [2]; - I fixed the series according to your feedback and sent v13 on May 26 [3]; - ... merge window for 4.18 is closed; - I re-sent the rebased v13 on June 22 [4], because you asked to do so in this thread. That's why I called it 'resend'. May I ask for your feedback on v13? Do you have any objections? Would you give your "Reviewed-by" or "Acked-by"? Thanks in advance. Best regards, Alexander [1]: http://www.openwall.com/lists/kernel-hardening/2018/05/16/1 [2]: http://www.openwall.com/lists/kernel-hardening/2018/05/18/2 [3]: http://www.openwall.com/lists/kernel-hardening/2018/05/26/6 [4]: http://www.openwall.com/lists/kernel-hardening/2018/06/22/8